linux/net/llc
Stephen Hemminger 30a584d944 [LLX]: SOCK_DGRAM interface fixes
The datagram interface of LLC is broken in a couple of ways.
These were discovered when trying to use it to build an out-of-kernel
version of STP.

First it didn't pass the source address of the received packet
in recvfrom(). It needs to copy the source address of received LLC packets
into the socket control block. At the same time fix a security issue
because there was uninitialized data leakage. Every recvfrom call
was just copying out old data.

Second, LLC should not merge multiple packets in one receive call
on datagram sockets. LLC should preserve packet boundaries on
SOCK_DGRAM.

This fix goes against the old historical comments about UNIX98 semantics
but without this fix SOCK_DGRAM is broken and useless. So either ANK's
interpretation was incorect or UNIX98 standard was wrong.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Acked-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2006-08-04 22:59:50 -07:00
..
Kconfig Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Makefile [LLC]: Add sysctl support for the LLC timeouts 2005-09-22 04:30:44 -03:00
af_llc.c [LLX]: SOCK_DGRAM interface fixes 2006-08-04 22:59:50 -07:00
llc_c_ac.c [LLC]: llc_mac_hdr_init const arguments 2006-03-20 22:59:36 -08:00
llc_c_ev.c [LLC]: Remove unused functions from llc_c_ev.c 2005-09-22 04:19:52 -03:00
llc_c_st.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
llc_conn.c [PATCH] gfp flags annotations - part 1 2005-10-08 15:00:57 -07:00
llc_core.c [NET]: Conversions from kmalloc+memset to k(z|c)alloc. 2006-07-21 14:51:30 -07:00
llc_if.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
llc_input.c [LLC]: Fix double receive of SKB. 2006-06-17 21:29:19 -07:00
llc_output.c [LLC]: llc_mac_hdr_init const arguments 2006-03-20 22:59:36 -08:00
llc_pdu.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
llc_proc.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
llc_s_ac.c [LLC]: llc_mac_hdr_init const arguments 2006-03-20 22:59:36 -08:00
llc_s_ev.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
llc_s_st.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
llc_sap.c [LLX]: SOCK_DGRAM interface fixes 2006-08-04 22:59:50 -07:00
llc_station.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
sysctl_net_llc.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00