linux/drivers/scsi/device_handler
Phil Carmody 497888cf69 treewide: fix potentially dangerous trailing ';' in #defined values/expressions
All these are instances of
  #define NAME value;
or
  #define NAME(params_opt) value;

These of course fail to build when used in contexts like
  if(foo $OP NAME)
  while(bar $OP NAME)
and may silently generate the wrong code in contexts such as
  foo = NAME + 1;    /* foo = value; + 1; */
  bar = NAME - 1;    /* bar = value; - 1; */
  baz = NAME & quux; /* baz = value; & quux; */

Reported on comp.lang.c,
Message-ID: <ab0d55fe-25e5-482b-811e-c475aa6065c3@c29g2000yqd.googlegroups.com>
Initial analysis of the dangers provided by Keith Thompson in that thread.

There are many more instances of more complicated macros having unnecessary
trailing semicolons, but this pile seems to be all of the cases of simple
values suffering from the problem. (Thus things that are likely to be found
in one of the contexts above, more complicated ones aren't.)

Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2011-07-21 14:10:00 +02:00
..
Kconfig [SCSI] scsi_dh: add generic SPC-3 alua handler 2008-07-26 15:14:52 -04:00
Makefile [SCSI] scsi_dh: add generic SPC-3 alua handler 2008-07-26 15:14:52 -04:00
scsi_dh.c [SCSI] scsi_dh: fix reference counting in scsi_dh_activate error path 2011-04-24 11:02:09 -05:00
scsi_dh_alua.c [SCSI] scsi_dh_alua: Attach to UNAVAILABLE/OFFLINE AAS devices 2011-05-01 12:05:40 -05:00
scsi_dh_emc.c [SCSI] scsi_dh: cosmetic change to sizeof() 2011-02-12 14:13:34 -06:00
scsi_dh_hp_sw.c [SCSI] scsi_dh: cosmetic change to sizeof() 2011-02-12 14:13:34 -06:00
scsi_dh_rdac.c treewide: fix potentially dangerous trailing ';' in #defined values/expressions 2011-07-21 14:10:00 +02:00