openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
linux/drivers/s390/char
History
Jiri Slaby fe2fc9ca5d TTY: con3215, centralize allocation 
There are two copies of allocations of device information. One of them
is totally broken. See:
raw->cdev = cdev;
raw->inbuf = (char *) raw + sizeof(struct raw3215_info);
memset(raw, 0, sizeof(struct raw3215_info));

It suggests that this path was never executed. The code uses both
raw->cdev and raw->inbuf all over. And it is NULL due to the memset
here, so it would panic immediately. I believe nobody used that driver
without being a system console.

Either way, let us fix it by moving the allocations (and
initializations) to a single place. This will save us some double
initializations later too.

And while at it, initialize the timer properly -- once, at the
allocation.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux390@de.ibm.com
Cc: linux-s390@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2012-04-09 11:27:28 -07:00
..
Kconfig [S390] kconfig: remove tape interface support comment 2011-07-24 10:48:00 +02:00
Makefile [S390] get CPC image name 2011-05-23 10:24:32 +02:00
con3215.c TTY: con3215, centralize allocation 2012-04-09 11:27:28 -07:00
con3270.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
ctrlchar.c Input: sysrq - drop tty argument form handle_sysrq() 2010-08-21 00:34:45 -07:00
ctrlchar.h
…
defkeymap.c
…
defkeymap.map
…
fs3270.c compat: fix compile breakage on s390 2012-02-27 07:54:27 -08:00
keyboard.c Merge branch 'tty-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty-2.6 2011-03-16 15:11:04 -07:00
keyboard.h tty: phase out of ioctl file pointer for tty3270 as well 2011-02-25 09:56:13 -08:00
monreader.c llseek: automatically add .llseek fop 2010-10-15 15:53:27 +02:00
monwriter.c [S390] monwriter: fix return code handling 2011-05-23 10:24:29 +02:00
raw3270.c module_param: make bool parameters really bool (drivers & misc) 2012-01-13 09:32:20 +10:30
raw3270.h [S390] pm: con3270 power management callbacks. 2009-06-16 10:31:20 +02:00
sclp.c [S390] irq: external interrupt code passing 2012-03-11 11:59:29 -04:00
sclp.h [S390] get CPC image name 2011-05-23 10:24:32 +02:00
sclp_async.c [S390] sclp_async: Use kstrtoul_from_user 2011-08-03 16:44:20 +02:00
sclp_cmd.c Disintegrate and delete asm/system.h 2012-03-28 15:58:21 -07:00
sclp_con.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
sclp_config.c cpu: convert 'cpu' and 'machinecheck' sysdev_class to a regular subsystem 2011-12-21 14:29:42 -08:00
sclp_cpi.c
…
sclp_cpi_sys.c s390: add missing module.h/export.h includes 2011-10-31 19:30:58 -04:00
sclp_cpi_sys.h
…
sclp_ocf.c [S390] get CPC image name 2011-05-23 10:24:32 +02:00
sclp_quiesce.c [S390] rework smp code 2012-03-11 11:59:28 -04:00
sclp_rw.c [S390] pm: power management support for SCLP drivers. 2009-06-16 10:31:16 +02:00
sclp_rw.h [S390] sclp: fix compile error for !SCLP_CONSOLE 2009-07-07 16:37:50 +02:00
sclp_sdias.c [S390] zfcpdump: Implement async sdias event processing 2012-03-11 11:59:28 -04:00
sclp_tty.c TTY: remove re-assignments to tty_driver members 2012-03-08 11:37:58 -08:00
sclp_tty.h [S390] sclp_tty: remove ioctl interface. 2008-07-14 10:02:25 +02:00
sclp_vt220.c TTY: remove re-assignments to tty_driver members 2012-03-08 11:37:58 -08:00
tape.h [S390] tape: deadlock on system work queue 2011-03-03 17:56:14 +01:00
tape_34xx.c [S390] fix mismatch in summation of I/O IRQ statistics 2011-10-30 15:16:15 +01:00
tape_3590.c [S390] fix mismatch in summation of I/O IRQ statistics 2011-10-30 15:16:15 +01:00
tape_3590.h
…
tape_char.c Fix common misspellings 2011-03-31 11:26:23 -03:00
tape_class.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
tape_class.h s390: tape_class.h: remove kobj_map.h inclusion 2011-12-13 11:17:40 -08:00
tape_core.c [S390] fix mismatch in summation of I/O IRQ statistics 2011-10-30 15:16:15 +01:00
tape_proc.c [S390] tape: Add pr_fmt() macro to all tape source files 2009-12-18 17:43:32 +01:00
tape_std.c [S390] tape: remove unused/not handled return codes 2011-05-23 10:24:29 +02:00
tape_std.h
…
tty3270.c TTY: remove re-assignments to tty_driver members 2012-03-08 11:37:58 -08:00
tty3270.h
…
vmcp.c compat: fix compile breakage on s390 2012-02-27 07:54:27 -08:00
vmcp.h
…
vmlogrdr.c atomic: use <linux/atomic.h> 2011-07-26 16:49:47 -07:00
vmur.c Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux 2011-11-06 19:44:47 -08:00
vmur.h
…
vmwatchdog.c module_param: make bool parameters really bool (drivers & misc) 2012-01-13 09:32:20 +10:30
zcore.c [S390] rework smp code 2012-03-11 11:59:28 -04:00