openkylin
/
platform_build
mirror of https://gitee.com/openkylin/platform_build.git
9
0
Fork 1
Code Issues Projects Releases Wiki Activity
platform_build/core/config_sanitizers.mk

108 lines
3.2 KiB
Makefile
Raw Normal View History

Add a SANITIZE_HOST flag. We had discussed the idea of making all host tools default to using ASAN. Even if we don't make it the default, this makes it easy for the user to switch all host binaries over. Change-Id: I64a5c741b1b4e9aefed3a6be8dcd4f386e06b29c
2014-11-01 07:23:08 +08:00
##############################################
## Perform configuration steps for sanitizers.
##############################################
Clean up sanitizer configuration. * Refactor a few pieces to avoid deeply nested conditionals. * LOCAL_SANITIZE := never replaces LOCAL_ADDRESS_SANITIZER := false. Change-Id: I68bb8c5edda6ecd40179c5ba9f18d06e96aaa260
2015-04-17 07:21:02 +08:00
my_sanitize := $(strip $(LOCAL_SANITIZE))
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
# Don't apply sanitizers to NDK code.
ifdef LOCAL_SDK_VERSION
Clean up sanitizer configuration. * Refactor a few pieces to avoid deeply nested conditionals. * LOCAL_SANITIZE := never replaces LOCAL_ADDRESS_SANITIZER := false. Change-Id: I68bb8c5edda6ecd40179c5ba9f18d06e96aaa260
2015-04-17 07:21:02 +08:00
my_sanitize := never
endif
Fix misuse of my_sanitize_host. Ying pointed out in https://android-review.googlesource.com/#/c/147290 that my_sanitize_host would be read as some garbage value for target builds. Move the configuration later and don't use the local at all. Change-Id: Id8a095821d000a184e72f950b9481597073a7044
2015-04-18 02:04:06 +08:00
# Configure SANITIZE_HOST.
ifdef LOCAL_IS_HOST_MODULE
ifeq ($(my_sanitize),)
my_sanitize := $(strip $(SANITIZE_HOST))
# SANTIZIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
ifeq ($(my_sanitize),true)
my_sanitize := address
endif
# SANITIZE_HOST is only in effect if the module is already using clang (host
# modules that haven't set `LOCAL_CLANG := false` and device modules that
# have set `LOCAL_CLANG := true`.
ifneq ($(my_clang),true)
my_sanitize :=
endif
endif
Clean up sanitizer configuration. * Refactor a few pieces to avoid deeply nested conditionals. * LOCAL_SANITIZE := never replaces LOCAL_ADDRESS_SANITIZER := false. Change-Id: I68bb8c5edda6ecd40179c5ba9f18d06e96aaa260
2015-04-17 07:21:02 +08:00
endif
ifeq ($(my_sanitize),never)
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
my_sanitize :=
endif
Make use of sanitizers without clang an error. Previously using a sanitizer would imply clang. It should be an error instead so it's more obvious. Change-Id: I67c949bfda3718a0d19da7e358b5fde447fce334
2015-04-18 00:48:33 +08:00
# Sanitizers can only be used with clang.
ifneq ($(my_clang),true)
ifneq ($(my_sanitize),)
$(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of sanitizers requires LOCAL_CLANG := true)
endif
endif
Add support for a partial ubsan build. Some of the ubsan checks expose a few pathological performance cases in clang, and thus aren't suited to be used in SANITIZE_HOST. This mode is also supported on the target despite not having the target runtime libraries for ubsan by generating traps. Change-Id: I0b0f0a08ca84d72e44e2174a66726b1c5e5cad7e
2015-04-17 09:07:07 +08:00
ifneq ($(filter default-ub,$(my_sanitize)),)
my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
Add support for a partial ubsan build. Some of the ubsan checks expose a few pathological performance cases in clang, and thus aren't suited to be used in SANITIZE_HOST. This mode is also supported on the target despite not having the target runtime libraries for ubsan by generating traps. Change-Id: I0b0f0a08ca84d72e44e2174a66726b1c5e5cad7e
2015-04-17 09:07:07 +08:00
ifdef LOCAL_IS_HOST_MODULE
my_cflags += -fno-sanitize-recover=all
Fix libdl inclusion for default-ub. We shouldn't be using ldlibs for target libraries because it doesn't add a real dependency. Change-Id: Ib1ec40b95356feb521e95674b64d04d5ecc06332
2015-06-16 02:39:29 +08:00
my_ldlibs += -ldl
Add support for a partial ubsan build. Some of the ubsan checks expose a few pathological performance cases in clang, and thus aren't suited to be used in SANITIZE_HOST. This mode is also supported on the target despite not having the target runtime libraries for ubsan by generating traps. Change-Id: I0b0f0a08ca84d72e44e2174a66726b1c5e5cad7e
2015-04-17 09:07:07 +08:00
else
my_cflags += -fsanitize-undefined-trap-on-error
Fix libdl inclusion for default-ub. We shouldn't be using ldlibs for target libraries because it doesn't add a real dependency. Change-Id: Ib1ec40b95356feb521e95674b64d04d5ecc06332
2015-06-16 02:39:29 +08:00
my_shared_libraries += libdl
Add support for a partial ubsan build. Some of the ubsan checks expose a few pathological performance cases in clang, and thus aren't suited to be used in SANITIZE_HOST. This mode is also supported on the target despite not having the target runtime libraries for ubsan by generating traps. Change-Id: I0b0f0a08ca84d72e44e2174a66726b1c5e5cad7e
2015-04-17 09:07:07 +08:00
endif
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
endif
ifneq ($(my_sanitize),)
fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize)),
my_cflags += -fsanitize=$(fsanitize_arg)
ifdef LOCAL_IS_HOST_MODULE
my_ldflags += -fsanitize=$(fsanitize_arg)
endif
endif
ifneq ($(filter address,$(my_sanitize)),)
Add a SANITIZE_HOST flag. We had discussed the idea of making all host tools default to using ASAN. Even if we don't make it the default, this makes it easy for the user to switch all host binaries over. Change-Id: I64a5c741b1b4e9aefed3a6be8dcd4f386e06b29c
2014-11-01 07:23:08 +08:00
# Frame pointer based unwinder in ASan requires ARM frame setup.
LOCAL_ARM_MODE := arm
my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
ifdef LOCAL_IS_HOST_MODULE
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
# -nodefaultlibs (provided with libc++) prevents the driver from linking
# libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Make asan more closely match clang behavior. Always link libm with asan. Hasn't been a problem before because ASAN was only ever used when libc++ was as well, which already links libm. Pass --no-as-needed for host modules. These aren't needed for the target builds because the target uses the shared RTL. Change-Id: I5d6a3c2dd557b5231be2b7711df6438693753a88
2015-04-29 04:23:36 +08:00
my_ldlibs += -lm -ldl -lpthread
--no-as-needed needs -Wl. Not sure why my checkbuild passed. Change-Id: Iead84121daaaa32c5dd1f0712e9b7caaffd58352
2015-04-29 05:55:50 +08:00
my_ldflags += -Wl,--no-as-needed
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
else
Fix AddressSanitizer link order and multilib setup. ASan runtime library (when using dynamic linking) must be the first dependency of the main executable to achieve correct symbol interposition. This matches how the clang driver works. In multilib setup, ASan-RT name depends on the target arch: /system/lib/libclang_rt.asan-arm-android.so /system/lib64/libclang_rt.asan-arm64-android.so We also set RPATH to /system/lib/asan or /system/lib64/asan to have a place for ASan-only versions of system libraries. Change-Id: I5c0cdb89e5e08a1950eb276e406da9f31a6e52dd
2015-04-25 07:34:47 +08:00
# ASan runtime library must be the first in the link order.
my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
$(my_shared_libraries) \
$(ADDRESS_SANITIZER_CONFIG_EXTRA_SHARED_LIBRARIES)
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
my_static_libraries += $(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES)
Fix AddressSanitizer link order and multilib setup. ASan runtime library (when using dynamic linking) must be the first dependency of the main executable to achieve correct symbol interposition. This matches how the clang driver works. In multilib setup, ASan-RT name depends on the target arch: /system/lib/libclang_rt.asan-arm-android.so /system/lib64/libclang_rt.asan-arm64-android.so We also set RPATH to /system/lib/asan or /system/lib64/asan to have a place for ASan-only versions of system libraries. Change-Id: I5c0cdb89e5e08a1950eb276e406da9f31a6e52dd
2015-04-25 07:34:47 +08:00
my_ldflags += -Wl,-rpath,$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RPATH)
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
endif
endif
ifneq ($(filter undefined,$(my_sanitize)),)
Add LOCAL_SANITIZE_RECOVER. This is needed for projects that have known ubsan issues that we can't fix right away (perhaps because it's an upstream project that we're diligent about keeping in sync with upsteam). Also make the normal ubsan use -fno-sanitize-recover=all by default. Change-Id: I1b0f3309792f32dbd08c18816d7306e76c8d7c30
2015-04-17 09:08:44 +08:00
my_cflags += -fno-sanitize-recover=all
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
ifdef LOCAL_IS_HOST_MODULE
my_ldlibs += -ldl
Add a SANITIZE_HOST flag. We had discussed the idea of making all host tools default to using ASAN. Even if we don't make it the default, this makes it easy for the user to switch all host binaries over. Change-Id: I64a5c741b1b4e9aefed3a6be8dcd4f386e06b29c
2014-11-01 07:23:08 +08:00
else
Add support for ubsan. Rather than adding LOCAL_UB_SANITIZER, LOCAL_THREAD_SANITIZER, etc for each new sanitizer, deprecate LOCAL_ADDRESS_SANITIZER in favor of LOCAL_SANITZE that mirrors the behavior of -fsanitize=<sanitizers>. For example, the following will use both asan and ubsan: LOCAL_SANITIZE := address undefined We'll leave LOCAL_ADDRESS_SANITIZER around for compatibility until we can clean up the tree. Change-Id: I8a62315129d4753f8e992584ca6db1e5dfdd4d2a
2014-12-12 10:56:26 +08:00
$(error ubsan is not yet supported on the target)
Add a SANITIZE_HOST flag. We had discussed the idea of making all host tools default to using ASAN. Even if we don't make it the default, this makes it easy for the user to switch all host binaries over. Change-Id: I64a5c741b1b4e9aefed3a6be8dcd4f386e06b29c
2014-11-01 07:23:08 +08:00
endif
endif
Add LOCAL_SANITIZE_RECOVER. This is needed for projects that have known ubsan issues that we can't fix right away (perhaps because it's an upstream project that we're diligent about keeping in sync with upsteam). Also make the normal ubsan use -fno-sanitize-recover=all by default. Change-Id: I1b0f3309792f32dbd08c18816d7306e76c8d7c30
2015-04-17 09:08:44 +08:00
Fix bad variable names. My working tree was still dirty when I verified the original change. Change-Id: I3e6fa6908b809c016231b398c5d30d8cce3b87ab
2015-04-29 02:26:45 +08:00
ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Add LOCAL_SANITIZE_RECOVER. This is needed for projects that have known ubsan issues that we can't fix right away (perhaps because it's an upstream project that we're diligent about keeping in sync with upsteam). Also make the normal ubsan use -fno-sanitize-recover=all by default. Change-Id: I1b0f3309792f32dbd08c18816d7306e76c8d7c30
2015-04-17 09:08:44 +08:00
my_cflags += -fsanitize-recover=$(recover_arg)
endif
Add support for LOCAL_DETECT_INTEGER_OVERFLOWS Add build system support for LOCAL_DETECT_INTEGER_OVERFLOWS. When enabled, an attempt to perform an integer arithmetic operation which overflows will result in a call to abort(). This is intended for security sensitive code, where integer overflow operations are not expected nor desirable. Two classes of underflows/overflows are detected and blocked: 1) Signed integer underflow/overflow. 2) Unsigned integer underflow/overflows. Signed integer overflows are undefined behavior, according to the C standard. Unsigned integer overflows are defined behavior, but still undesirable in security sensitive code. Only clang is supported today. gcc has -ftrapv for handling signed integer overflow, but it's widely considered broken (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35412) and we're deliberately avoiding it's use here. Change-Id: Ib4918dc84e37e83d4205e5035544545d91671e5f Vaguely-Related-Bug: 11859726
2015-06-15 02:38:30 +08:00
ifeq ($(strip $(LOCAL_DETECT_INTEGER_OVERFLOWS)),true)
ifeq ($(my_clang),true)
my_cflags += -fsanitize=signed-integer-overflow,unsigned-integer-overflow
my_cflags += -ftrap-function=abort
my_cflags += -fsanitize-undefined-trap-on-error
else
$(error $(LOCAL_MODULE): You must enable LOCAL_CLANG:=true to use LOCAL_DETECT_INTEGER_OVERFLOWS)
endif
endif