Define DEFAULT_TIDY_HEADER_DIRS.

Let clang-tidy report warnings in header files in the
system and current directories but not the external
and vendor directories.

Test: build with WITH_TIDY=1
Change-Id: I1723b8eb95948961fb7164a19989e0a926e5bf8a
This commit is contained in:
Chih-Hung Hsieh 2016-09-06 20:06:28 -07:00
parent a5b02ff1ef
commit 0a33f65cc8
2 changed files with 23 additions and 1 deletions

View File

@ -1649,7 +1649,7 @@ ifneq (,$(filter 1 true,$(my_tidy_enabled)))
endif
# If tidy flags are not specified, default to check all header files.
ifeq ($(my_tidy_flags),)
my_tidy_flags := -header-filter=.*
my_tidy_flags := $(call default_tidy_header_filter,$(LOCAL_PATH))
endif
endif
endif

View File

@ -73,3 +73,25 @@ $(lastword \
) \
)
endef
# Give warnings to header files only in selected directories.
# Do not give warnings to external or vendor header files,
# which contain too many warnings.
DEFAULT_TIDY_HEADER_DIRS := \
art/ \
|bionic/ \
|bootable/ \
|build/ \
|cts/ \
|dalvik/ \
|developers/ \
|development/ \
|frameworks/ \
|libcore/ \
|libnativehelper/ \
|system/
# Default filter contains current directory $1 and DEFAULT_TIDY_HEADER_DIRS.
define default_tidy_header_filter
-header-filter="($(subst $(space),,$1|$(DEFAULT_TIDY_HEADER_DIRS)))"
endef