From 33fdd8c4efe40dbe4434aba4f3e5e5924f5e4ff9 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Thu, 9 Nov 2017 10:15:31 -0800 Subject: [PATCH] Break up PRODUCT_FULL_TREBLE into variables. PRODUCT_SEPOLICY_SPLIT PRODUCT_TREBLE_LINKER_NAMESPACES PRODUCT_ENFORCE_VINTF_MANIFEST Being able to selectively toggle these does several things: - it's better software engineering (no longer conflating vars) - easier bringup for devices. - devices which don't require full Treble can opt out of only parts of it and still get the benefits of others. Bug: 62019611 Test: manual Merged-In: I728e32869baf043ae9a54e83e513fb99e560c827 Change-Id: I728e32869baf043ae9a54e83e513fb99e560c827 --- core/config.mk | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/core/config.mk b/core/config.mk index 86fc3997b..aaeda70df 100644 --- a/core/config.mk +++ b/core/config.mk @@ -700,6 +700,25 @@ else ifneq ($(call math_gt_or_eq,$(PRODUCT_SHIPPING_API_LEVEL),26),) PRODUCT_FULL_TREBLE := true endif +requirements := \ + PRODUCT_TREBLE_LINKER_NAMESPACES \ + PRODUCT_SEPOLICY_SPLIT \ + PRODUCT_ENFORCE_VINTF_MANIFEST \ + +# If it is overriden, then the requirement override is taken, otherwise it's +# PRODUCT_FULL_TREBLE +$(foreach req,$(requirements),$(eval \ + $(req) := $(if $($(req)_OVERRIDE),$($(req)_OVERRIDE),$(PRODUCT_FULL_TREBLE)))) +# If the requirement is false for any reason, then it's not PRODUCT_FULL_TREBLE +$(foreach req,$(requirements),$(eval \ + PRODUCT_FULL_TREBLE := $(if $(filter false,$($(req))),false,$(PRODUCT_FULL_TREBLE)))) + +.KATI_READONLY := \ + $(requirements) \ + PRODUCT_FULL_TREBLE + +requirements := + # The default key if not set as LOCAL_CERTIFICATE ifdef PRODUCT_DEFAULT_DEV_CERTIFICATE DEFAULT_SYSTEM_DEV_CERTIFICATE := $(PRODUCT_DEFAULT_DEV_CERTIFICATE)