From 606c9f4d0da979b1fc910cf9d5e60e205727fce4 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Fri, 17 May 2019 15:51:39 -0700 Subject: [PATCH] Move check-all-partition-sizes to a non-phony rule Phony rules with recipes run on every build, move the recipe for check-all-partition-sizes to a rule with an output. Fixes: 132900128 Test: m && m Change-Id: I9b4d335bf269cd09a01094e895fc15053b410415 --- core/Makefile | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/core/Makefile b/core/Makefile index 57a05d4b1..c042315da 100644 --- a/core/Makefile +++ b/core/Makefile @@ -3381,8 +3381,12 @@ droid_targets: check-all-partition-sizes .PHONY: check-all-partition-sizes check-all-partition-sizes-nodeps +check_all_partition_sizes_file := $(call intermediates-dir-for,PACKAGING,check-all-partition-sizes)/timestamp + +check-all-partition-sizes: $(check_all_partition_sizes_file) + # Add image dependencies so that generated_*_image_info.txt are written before checking. -check-all-partition-sizes: \ +$(check_all_partition_sizes_file): \ build/make/tools/releasetools/sparse_img.py \ $(call images-for-partitions,$(BOARD_SUPER_PARTITION_PARTITION_LIST)) @@ -3450,7 +3454,12 @@ define check-all-partition-sizes-target fi endef -check-all-partition-sizes check-all-partition-sizes-nodeps: +$(check_all_partition_sizes_file): + $(call check-all-partition-sizes-target) + $(call check-super-partition-size) + touch $@ + +check-all-partition-sizes-nodeps: $(call check-all-partition-sizes-target) $(call check-super-partition-size)