From b3113da54236b93957a3dde639d896149bc2d5dd Mon Sep 17 00:00:00 2001 From: Jaewoong Jung Date: Wed, 28 Nov 2018 15:19:46 -0800 Subject: [PATCH] Use debug mode when running R8 for eng builds. Bug: 119601874 Test: Built for different variants. Change-Id: Icaf300c944b1d0594f524a11999cc5a8229919eb --- core/definitions.mk | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/core/definitions.mk b/core/definitions.mk index 0d4b6c492..38ff62bd8 100644 --- a/core/definitions.mk +++ b/core/definitions.mk @@ -2752,6 +2752,14 @@ endef ########################################################### ## Commands to call R8 ########################################################### + +# Use --debug flag for eng builds by default +ifeq (eng,$(TARGET_BUILD_VARIANT)) +R8_DEBUG_MODE := --debug +else +R8_DEBUG_MODE := +endif + define transform-jar-to-dex-r8 @echo R8: $@ $(hide) rm -f $(PRIVATE_PROGUARD_DICTIONARY) @@ -2759,6 +2767,7 @@ $(hide) $(R8_COMPAT_PROGUARD) -injars '$<' \ --min-api $(PRIVATE_MIN_SDK_VERSION) \ --no-data-resources \ --force-proguard-compatibility --output $(subst classes.dex,,$@) \ + $(R8_DEBUG_MODE) \ $(PRIVATE_PROGUARD_FLAGS) \ $(addprefix -injars , $(PRIVATE_EXTRA_INPUT_JAR)) \ $(PRIVATE_DX_FLAGS)