openkylin
/
platform_build
mirror of https://gitee.com/openkylin/platform_build.git
9
0
Fork 1
Code Issues Projects Releases Wiki Activity

Merge "Add new Java/Kotlin/Make warning patterns"

This commit is contained in:
Chih-hung Hsieh 2020-02-04 18:41:57 +00:00 committed by Gerrit Code Review
parent 644ed279eb a7f5f3fcbb
commit 9f7a42025d
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/warn/java_warn_patterns.py
View File

@ -461,12 +461,15 @@ warn_patterns = [
[r".*: warning: \[WaitNotInLoop\] .+"]), [r".*: warning: \[WaitNotInLoop\] .+"]),
java_medium('A wakelock acquired with a timeout may be released by the system before calling `release`, even after checking `isHeld()`. If so, it will throw a RuntimeException. Please wrap in a try/catch block.', java_medium('A wakelock acquired with a timeout may be released by the system before calling `release`, even after checking `isHeld()`. If so, it will throw a RuntimeException. Please wrap in a try/catch block.',
[r".*: warning: \[WakelockReleasedDangerously\] .+"]), [r".*: warning: \[WakelockReleasedDangerously\] .+"]),
java_medium_type('AbstractInner'),
java_medium_type('CallbackName'), java_medium_type('CallbackName'),
java_medium_type('ExecutorRegistration'), java_medium_type('ExecutorRegistration'),
java_medium_type('ListenerLast'), java_medium_type('ListenerLast'),
java_medium_type('MissingBuildMethod'), java_medium_type('MissingBuildMethod'),
java_medium_type('NoByteOrShort'), java_medium_type('NoByteOrShort'),
java_medium_type('OverlappingConstants'),
java_medium_type('SetterReturnsThis'), java_medium_type('SetterReturnsThis'),
java_medium_type('Typo'),
java_medium_type('UseIcu'), java_medium_type('UseIcu'),
java_high('AndroidInjection.inject() should always be invoked before calling super.lifecycleMethod()', java_high('AndroidInjection.inject() should always be invoked before calling super.lifecycleMethod()',
[r".*: warning: \[AndroidInjectionBeforeSuper\] .+"]), [r".*: warning: \[AndroidInjectionBeforeSuper\] .+"]),

3
tools/warn/make_warn_patterns.py
View File

@ -53,6 +53,9 @@ warn_patterns = [
{'category': 'make', 'severity': Severity.MEDIUM, {'category': 'make', 'severity': Severity.MEDIUM,
'description': 'make: please convert to soong', 'description': 'make: please convert to soong',
'patterns': [r".*: warning: .* has been deprecated. Please convert to Soong."]}, 'patterns': [r".*: warning: .* has been deprecated. Please convert to Soong."]},
{'category': 'make', 'severity': Severity.MEDIUM,
'description': 'make: deprecated macros',
'patterns': [r".*\.mk:.* warning:.* [A-Z_]+ (is|has been) deprecated."]},
] ]

8
tools/warn/other_warn_patterns.py
View File

@ -112,8 +112,16 @@ warn_patterns = [
kotlin('never used parameter or variable', kotlin('never used parameter or variable',
[r".*\.kt:.*: warning: (parameter|variable) '.*' is never used$", [r".*\.kt:.*: warning: (parameter|variable) '.*' is never used$",
r".*\.kt:.*: warning: (parameter|variable) '.*' is never used, could be renamed to _$"]), r".*\.kt:.*: warning: (parameter|variable) '.*' is never used, could be renamed to _$"]),
kotlin('initializer is redundant',
[r".*\.kt:.*: warning: .* initializer is redundant$"]),
kotlin('elvis operator always returns ...',
[r".*\.kt:.*: warning: elvis operator \(\?:\) always returns .+"]),
kotlin('shadowed name',
[r".*\.kt:.*: warning: name shadowed: .+"]),
kotlin('unchecked cast', kotlin('unchecked cast',
[r".*\.kt:.*: warning: unchecked cast: .* to .*$"]), [r".*\.kt:.*: warning: unchecked cast: .* to .*$"]),
kotlin('unnecessary safe call on a non-null receiver',
[r".*\.kt:.*: warning: unnecessary safe call on a non-null receiver"]),
kotlin('Deprecated in Java', kotlin('Deprecated in Java',
[r".*\.kt:.*: warning: '.*' is deprecated. Deprecated in Java"]), [r".*\.kt:.*: warning: '.*' is deprecated. Deprecated in Java"]),
kotlin('library has Kotlin runtime', kotlin('library has Kotlin runtime',