openkylin
/
platform_build
mirror of https://gitee.com/openkylin/platform_build.git
9
0
Fork 1
Code Issues Projects Releases Wiki Activity

Merge "Add phony target to check all PCF ELF prebuilts"

This commit is contained in:
Yo Chiang 2020-12-04 02:49:33 +00:00 committed by Gerrit Code Review
parent 789c57ee04 336883a64f
commit ad4dae71cf
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/Makefile
View File

@ -40,6 +40,10 @@ $(if $(filter true,$(BUILD_BROKEN_VINTF_PRODUCT_COPY_FILES)),, \
)
endef
# Phony target to check PRODUCT_COPY_FILES copy pairs don't contain ELF files
.PHONY: check-elf-prebuilt-product-copy-files
check-elf-prebuilt-product-copy-files:
check_elf_prebuilt_product_copy_files := true
ifneq (,$(filter true,$(BUILD_BROKEN_ELF_PREBUILT_PRODUCT_COPY_FILES)))
check_elf_prebuilt_product_copy_files :=

20
core/definitions.mk
View File

@ -2493,15 +2493,25 @@ endef
# $(2): destination file
# $(3): message to print on error
define copy-non-elf-file-checked
$(2): $(1) $(LLVM_READOBJ)
@echo "Copy non-ELF: $$@"
$(eval check_non_elf_file_timestamp := \
$(call intermediates-dir-for,FAKE,check-non-elf-file-timestamps)/$(2).timestamp)
$(check_non_elf_file_timestamp): $(1) $(LLVM_READOBJ)
@echo "Check non-ELF: $$<"
$(hide) mkdir -p "$$(dir $$@)"
$(hide) rm -f "$$@"
$(hide) \
if $(LLVM_READOBJ) -h $$< >/dev/null 2>&1; then \
$(call echo-error,$$@,$(3)); \
$(call echo-error,$$@,found ELF file: $$<); \
if $(LLVM_READOBJ) -h "$$<" >/dev/null 2>&1; then \
$(call echo-error,$(2),$(3)); \
$(call echo-error,$(2),found ELF file: $$<); \
false; \
fi
$(hide) touch "$$@"
$(2): $(1) $(check_non_elf_file_timestamp)
@echo "Copy non-ELF: $$@"
$$(copy-file-to-target)
check-elf-prebuilt-product-copy-files: $(check_non_elf_file_timestamp)
endef
# The -t option to acp and the -p option to cp is