From 5232f099f6140182c81f4b25083ba3fb4280e7cd Mon Sep 17 00:00:00 2001 From: Tao Bao Date: Sat, 10 Feb 2018 04:03:32 +0000 Subject: [PATCH] Revert^2 "Replace $(shell find | sort) with $(sort $(shell find))" This reverts commit 14a3217ff928c21ffeceec4ec187332fcaf9f8f4. Reason for revert: Wrong blame for b/73143444. Change-Id: Ibb23349fcbb3c1b855afdd426317e8d2d4fc0adc --- core/Makefile | 14 +++++++------- core/aux_config.mk | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/core/Makefile b/core/Makefile index a67a4110e..5b87e80d1 100644 --- a/core/Makefile +++ b/core/Makefile @@ -2367,18 +2367,18 @@ OTATOOLS_DEPS := \ system/extras/verity/build_verity_metadata.py \ system/extras/ext4_utils/mke2fs.conf \ external/avb/test/data/testkey_rsa4096.pem \ - $(shell find system/update_engine/scripts -name \*.pyc -prune -o -type f -print | sort) \ - $(shell find build/target/product/security -type f -name \*.x509.pem -o -name \*.pk8 -o \ - -name verity_key | sort) \ - $(shell find device $(wildcard vendor) -type f -name \*.pk8 -o -name verifiedboot\* -o \ - -name \*.x509.pem -o -name oem\*.prop | sort) + $(sort $(shell find system/update_engine/scripts -name \*.pyc -prune -o -type f -print)) \ + $(sort $(shell find build/target/product/security -type f -name \*.x509.pem -o -name \*.pk8 -o \ + -name verity_key)) \ + $(sort $(shell find device $(wildcard vendor) -type f -name \*.pk8 -o -name verifiedboot\* -o \ + -name \*.x509.pem -o -name oem\*.prop)) OTATOOLS_RELEASETOOLS := \ - $(shell find build/make/tools/releasetools -name \*.pyc -prune -o -type f | sort) + $(sort $(shell find build/make/tools/releasetools -name \*.pyc -prune -o -type f)) ifeq (true,$(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_SUPPORTS_VBOOT)) OTATOOLS_DEPS += \ - $(shell find external/vboot_reference/tests/devkeys -type f | sort) + $(sort $(shell find external/vboot_reference/tests/devkeys -type f)) endif $(BUILT_OTATOOLS_PACKAGE): $(OTATOOLS) $(OTATOOLS_DEPS) $(OTATOOLS_RELEASETOOLS) | $(ACP) diff --git a/core/aux_config.mk b/core/aux_config.mk index bdae86aaf..6a5cd63b7 100644 --- a/core/aux_config.mk +++ b/core/aux_config.mk @@ -154,7 +154,7 @@ os_sfx :=_aux_os_config.mk config_roots := $(wildcard device vendor) all_configs := ifdef config_roots -all_configs := $(shell find $(config_roots) -maxdepth 4 -name '*$(variant_sfx)' -o -name '*$(os_sfx)' | sort) +all_configs := $(sort $(shell find $(config_roots) -maxdepth 4 -name '*$(variant_sfx)' -o -name '*$(os_sfx)')) endif all_os_configs := $(filter %$(os_sfx),$(all_configs)) all_variant_configs := $(filter %$(variant_sfx),$(all_configs))