From 4d31b9da8c893c83aff82e4ffc4a294a7cf9f0ee Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Thu, 4 Jan 2018 01:31:37 -0800 Subject: [PATCH] Call clang-tidy with -fno-caret-diagnostics by default. * clang -fno-caret-diagnostics suppresses warning source lines, carets, and the stats line of "n warnings generated" * clang-tidy -extra-arg-before=-fno-caret-diagnotics only suppresses the "n warnings generated" line. * Pass this flag and -quiet to clang-tidy when WITH_TIDY is not 1 or true. * Remove redundant quotation marks around -extra-arg-before. Bug: 69051430 Test: normal build and build with WITH_TIDY=1 Change-Id: I9021ee315edc977c15dda6ab246a00182f31fad1 --- core/binary.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/binary.mk b/core/binary.mk index 692037379..92f995964 100644 --- a/core/binary.mk +++ b/core/binary.mk @@ -1721,13 +1721,13 @@ ifneq (,$(filter 1 true,$(my_tidy_enabled))) endif # If clang-tidy is not enabled globally, add the -quiet flag. ifeq (,$(filter 1 true,$(WITH_TIDY))) - my_tidy_flags += -quiet + my_tidy_flags += -quiet -extra-arg-before=-fno-caret-diagnostics endif # We might be using the static analyzer through clang-tidy. # https://bugs.llvm.org/show_bug.cgi?id=32914 ifneq ($(my_tidy_checks),) - my_tidy_flags += "-extra-arg-before=-D__clang_analyzer__" + my_tidy_flags += -extra-arg-before=-D__clang_analyzer__ endif endif endif