From 9dd20038b2a5c4cd0ce03042cc2e541614b1c308 Mon Sep 17 00:00:00 2001 From: Liz Kammer Date: Tue, 28 Jul 2020 14:21:14 -0700 Subject: [PATCH] Update language to comply with inclusive guidance Update android_app_set make files to use INSTALL rather than MASTER for android_app_sets, this better matches the wording used for apex_set. See https://source.android.com/setup/contribute/respectful-code for reference Bug: 161896447 Test: m nothing Change-Id: I7f37a72914f4b18a839942cc3db98b1c57db921e --- core/clear_vars.mk | 2 +- core/soong_android_app_set.mk | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/core/clear_vars.mk b/core/clear_vars.mk index e2acf96a9..9d9d0e00b 100644 --- a/core/clear_vars.mk +++ b/core/clear_vars.mk @@ -21,7 +21,7 @@ LOCAL_ANNOTATION_PROCESSOR_CLASSES:= LOCAL_APIDIFF_NEWAPI:= LOCAL_APIDIFF_OLDAPI:= LOCAL_APK_LIBRARIES:= -LOCAL_APK_SET_MASTER_FILE:= +LOCAL_APK_SET_INSTALL_FILE:= LOCAL_APKCERTS_FILE:= LOCAL_ARM_MODE:= LOCAL_ASFLAGS:= diff --git a/core/soong_android_app_set.mk b/core/soong_android_app_set.mk index c93bb3fac..ef9eaced5 100644 --- a/core/soong_android_app_set.mk +++ b/core/soong_android_app_set.mk @@ -1,13 +1,13 @@ # App prebuilt coming from Soong. # Extra inputs: -# LOCAL_APK_SET_MASTER_FILE +# LOCAL_APK_SET_INSTALL_FILE ifneq ($(LOCAL_MODULE_MAKEFILE),$(SOONG_ANDROID_MK)) $(call pretty-error,soong_apk_set.mk may only be used from Soong) endif -LOCAL_BUILT_MODULE_STEM := $(LOCAL_APK_SET_MASTER_FILE) -LOCAL_INSTALLED_MODULE_STEM := $(LOCAL_APK_SET_MASTER_FILE) +LOCAL_BUILT_MODULE_STEM := $(LOCAL_APK_SET_INSTALL_FILE) +LOCAL_INSTALLED_MODULE_STEM := $(LOCAL_APK_SET_INSTALL_FILE) ####################################### include $(BUILD_SYSTEM)/base_rules.mk @@ -15,19 +15,19 @@ include $(BUILD_SYSTEM)/base_rules.mk ## Extract master APK from APK set into given directory # $(1) APK set -# $(2) master APK entry (e.g., splits/base-master.apk +# $(2) APK entry to install (e.g., splits/base.apk -define extract-master-from-apk-set +define extract-install-file-from-apk-set $(LOCAL_BUILT_MODULE): $(1) @echo "Extracting $$@" unzip -pq $$< $(2) >$$@ endef -$(eval $(call extract-master-from-apk-set,$(LOCAL_PREBUILT_MODULE_FILE),$(LOCAL_APK_SET_MASTER_FILE))) +$(eval $(call extract-install-file-from-apk-set,$(LOCAL_PREBUILT_MODULE_FILE),$(LOCAL_APK_SET_INSTALL_FILE))) # unzip returns 11 it there was nothing to extract, which is expected, -# $(LOCAL_APK_SET_MASTER_FILE) has is already there. +# $(LOCAL_APK_SET_INSTALL_FILE) has is already there. LOCAL_POST_INSTALL_CMD := unzip -qoDD -j -d $(dir $(LOCAL_INSTALLED_MODULE)) \ - $(LOCAL_PREBUILT_MODULE_FILE) -x $(LOCAL_APK_SET_MASTER_FILE) || [[ $$? -eq 11 ]] + $(LOCAL_PREBUILT_MODULE_FILE) -x $(LOCAL_APK_SET_INSTALL_FILE) || [[ $$? -eq 11 ]] $(LOCAL_INSTALLED_MODULE): PRIVATE_POST_INSTALL_CMD := $(LOCAL_POST_INSTALL_CMD) PACKAGES.$(LOCAL_MODULE).OVERRIDES := $(strip $(LOCAL_OVERRIDES_PACKAGES))