Merge "Add quote to the signing arguments when passing to apexer" am: 2c2b9b4d64

Change-Id: Ib8ae825b9369efb01795809aa18a74a6f9bd4dd6
This commit is contained in:
Automerger Merge Worker 2020-01-31 22:47:22 +00:00
commit f561e162e2
2 changed files with 4 additions and 2 deletions

View File

@ -157,8 +157,10 @@ class ApexApkSigner(object):
os.getenv('PATH')]
for key, val in arguments_dict.items():
repack_cmd.extend(['--' + key, val])
# Add quote to the signing_args as we will pass
# --signing_args "--signing_helper_with_files=%path" to apexer
if signing_args:
repack_cmd.extend(['--signing_args', signing_args])
repack_cmd.extend(['--signing_args', '"{}"'.format(signing_args)])
# optional arguments for apex repacking
manifest_json = os.path.join(apex_dir, 'apex_manifest.json')
if os.path.exists(manifest_json):

View File

@ -189,7 +189,7 @@ class ApexUtilsTest(test_utils.ReleaseToolsTestCase):
signing_helper = os.path.join(self.testdata_dir, 'signing_helper.sh')
os.chmod(signing_helper, 0o700)
payload_signer_args = '--signing_helper_with_files {}'.format(
payload_signer_args = '--signing_helper_with_files={}'.format(
signing_helper)
signer.ProcessApexFile(apk_keys, self.payload_key, payload_pubkey,
payload_signer_args)