Merge "releasetools: Fix the error message."

This commit is contained in:
Treehugger Robot 2018-10-25 22:35:37 +00:00 committed by Gerrit Code Review
commit fea4263ec1
1 changed files with 5 additions and 21 deletions

View File

@ -58,15 +58,9 @@ def GetDiskUsage(path):
Returns: Returns:
The number of bytes based on a 1K block_size. The number of bytes based on a 1K block_size.
Raises:
BuildImageError: On error.
""" """
cmd = ["du", "-k", "-s", path] cmd = ["du", "-k", "-s", path]
try: output = common.RunAndCheckOutput(cmd, verbose=False)
output = common.RunAndCheckOutput(cmd, verbose=False)
except common.ExternalError:
raise BuildImageError("Failed to get disk usage:\n{}".format(output))
return int(output.split()[0]) * 1024 return int(output.split()[0]) * 1024
@ -78,15 +72,9 @@ def GetInodeUsage(path):
Returns: Returns:
The number of inodes used. The number of inodes used.
Raises:
BuildImageError: On error.
""" """
cmd = ["find", path, "-print"] cmd = ["find", path, "-print"]
try: output = common.RunAndCheckOutput(cmd, verbose=False)
output = common.RunAndCheckOutput(cmd, verbose=False)
except common.ExternalError:
raise BuildImageError("Failed to get disk inode usage:\n{}".format(output))
# increase by > 4% as number of files and directories is not whole picture. # increase by > 4% as number of files and directories is not whole picture.
return output.count('\n') * 25 // 24 return output.count('\n') * 25 // 24
@ -99,19 +87,15 @@ def GetFilesystemCharacteristics(sparse_image_path):
Returns: Returns:
The characteristics dictionary. The characteristics dictionary.
Raises:
BuildImageError: On error.
""" """
unsparse_image_path = UnsparseImage(sparse_image_path, replace=False) unsparse_image_path = UnsparseImage(sparse_image_path, replace=False)
cmd = ["tune2fs", "-l", unsparse_image_path] cmd = ["tune2fs", "-l", unsparse_image_path]
try: try:
output = common.RunAndCheckOutput(cmd, verbose=False) output = common.RunAndCheckOutput(cmd, verbose=False)
except common.ExternalError: finally:
raise BuildImageError("Failed to get tune2fs usage:\n{}".format(output)) os.remove(unsparse_image_path)
os.remove(unsparse_image_path) fs_dict = {}
fs_dict = { }
for line in output.splitlines(): for line in output.splitlines():
fields = line.split(":") fields = line.split(":")
if len(fields) == 2: if len(fields) == 2: