2017-05-06 07:16:24 +08:00
|
|
|
// Copyright 2015 Google Inc. All rights reserved.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package android
|
|
|
|
|
|
|
|
import (
|
|
|
|
"reflect"
|
2019-09-25 13:19:02 +08:00
|
|
|
"strconv"
|
2017-05-06 07:16:24 +08:00
|
|
|
"testing"
|
2019-09-25 13:19:02 +08:00
|
|
|
|
|
|
|
"github.com/google/blueprint/proptools"
|
2017-05-06 07:16:24 +08:00
|
|
|
)
|
|
|
|
|
|
|
|
type printfIntoPropertyTestCase struct {
|
|
|
|
in string
|
|
|
|
val interface{}
|
|
|
|
out string
|
|
|
|
err bool
|
|
|
|
}
|
|
|
|
|
|
|
|
var printfIntoPropertyTestCases = []printfIntoPropertyTestCase{
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: 0,
|
|
|
|
out: "0",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: 1,
|
|
|
|
out: "1",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: 2,
|
|
|
|
out: "2",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: false,
|
|
|
|
out: "0",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: true,
|
|
|
|
out: "1",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: -1,
|
|
|
|
out: "-1",
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
in: "-DA=%d",
|
|
|
|
val: 1,
|
|
|
|
out: "-DA=1",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "-DA=%du",
|
|
|
|
val: 1,
|
|
|
|
out: "-DA=1u",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "-DA=%s",
|
|
|
|
val: "abc",
|
|
|
|
out: "-DA=abc",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: `-DA="%s"`,
|
|
|
|
val: "abc",
|
|
|
|
out: `-DA="abc"`,
|
|
|
|
},
|
|
|
|
|
|
|
|
{
|
|
|
|
in: "%%",
|
|
|
|
err: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d%s",
|
|
|
|
err: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d,%s",
|
|
|
|
err: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: "",
|
|
|
|
err: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%d",
|
|
|
|
val: 1.5,
|
|
|
|
err: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
in: "%f",
|
|
|
|
val: 1.5,
|
|
|
|
err: true,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPrintfIntoProperty(t *testing.T) {
|
|
|
|
for _, testCase := range printfIntoPropertyTestCases {
|
|
|
|
s := testCase.in
|
|
|
|
v := reflect.ValueOf(&s).Elem()
|
|
|
|
err := printfIntoProperty(v, testCase.val)
|
|
|
|
if err != nil && !testCase.err {
|
|
|
|
t.Errorf("unexpected error %s", err)
|
|
|
|
} else if err == nil && testCase.err {
|
|
|
|
t.Errorf("expected error")
|
|
|
|
} else if err == nil && v.String() != testCase.out {
|
|
|
|
t.Errorf("expected %q got %q", testCase.out, v.String())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-09-25 13:19:02 +08:00
|
|
|
|
|
|
|
type testProductVariableModule struct {
|
|
|
|
ModuleBase
|
|
|
|
}
|
|
|
|
|
|
|
|
func (m *testProductVariableModule) GenerateAndroidBuildActions(ctx ModuleContext) {
|
|
|
|
}
|
|
|
|
|
|
|
|
var testProductVariableProperties = struct {
|
|
|
|
Product_variables struct {
|
|
|
|
Eng struct {
|
|
|
|
Srcs []string
|
|
|
|
Cflags []string
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}{}
|
|
|
|
|
|
|
|
func testProductVariableModuleFactoryFactory(props interface{}) func() Module {
|
|
|
|
return func() Module {
|
|
|
|
m := &testProductVariableModule{}
|
|
|
|
clonedProps := proptools.CloneProperties(reflect.ValueOf(props)).Interface()
|
|
|
|
m.AddProperties(clonedProps)
|
|
|
|
|
2019-11-23 08:03:51 +08:00
|
|
|
// Set a default soongConfigVariableProperties, this will be used as the input to the property struct filter
|
2019-09-25 13:19:02 +08:00
|
|
|
// for this test module.
|
|
|
|
m.variableProperties = testProductVariableProperties
|
|
|
|
InitAndroidModule(m)
|
|
|
|
return m
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestProductVariables(t *testing.T) {
|
|
|
|
// Test that a module can use one product variable even if it doesn't have all the properties
|
|
|
|
// supported by that product variable.
|
|
|
|
bp := `
|
|
|
|
module1 {
|
|
|
|
name: "foo",
|
|
|
|
product_variables: {
|
|
|
|
eng: {
|
|
|
|
srcs: ["foo.c"],
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
module2 {
|
|
|
|
name: "bar",
|
|
|
|
product_variables: {
|
|
|
|
eng: {
|
|
|
|
cflags: ["-DBAR"],
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
module3 {
|
|
|
|
name: "baz",
|
|
|
|
}
|
|
|
|
`
|
2019-12-14 12:41:13 +08:00
|
|
|
config := TestConfig(buildDir, nil, bp, nil)
|
2019-09-25 13:19:02 +08:00
|
|
|
config.TestProductVariables.Eng = proptools.BoolPtr(true)
|
|
|
|
|
2020-10-30 08:09:13 +08:00
|
|
|
ctx := NewTestContext(config)
|
|
|
|
// A module type that has a srcs property but not a cflags property.
|
|
|
|
ctx.RegisterModuleType("module1", testProductVariableModuleFactoryFactory(&struct {
|
|
|
|
Srcs []string
|
|
|
|
}{}))
|
|
|
|
// A module type that has a cflags property but not a srcs property.
|
|
|
|
ctx.RegisterModuleType("module2", testProductVariableModuleFactoryFactory(&struct {
|
|
|
|
Cflags []string
|
|
|
|
}{}))
|
|
|
|
// A module type that does not have any properties that match product_variables.
|
|
|
|
ctx.RegisterModuleType("module3", testProductVariableModuleFactoryFactory(&struct {
|
|
|
|
Foo []string
|
|
|
|
}{}))
|
|
|
|
ctx.PreDepsMutators(func(ctx RegisterMutatorsContext) {
|
|
|
|
ctx.BottomUp("variable", VariableMutator).Parallel()
|
|
|
|
})
|
|
|
|
|
|
|
|
ctx.Register()
|
2019-12-14 12:41:13 +08:00
|
|
|
|
2019-09-25 13:19:02 +08:00
|
|
|
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
|
|
|
|
FailIfErrored(t, errs)
|
|
|
|
_, errs = ctx.PrepareBuildActions(config)
|
|
|
|
FailIfErrored(t, errs)
|
|
|
|
}
|
|
|
|
|
2020-02-07 09:01:55 +08:00
|
|
|
var testProductVariableDefaultsProperties = struct {
|
|
|
|
Product_variables struct {
|
|
|
|
Eng struct {
|
|
|
|
Foo []string
|
|
|
|
Bar []string
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}{}
|
|
|
|
|
|
|
|
type productVariablesDefaultsTestProperties struct {
|
|
|
|
Foo []string
|
|
|
|
}
|
|
|
|
|
|
|
|
type productVariablesDefaultsTestProperties2 struct {
|
|
|
|
Foo []string
|
|
|
|
Bar []string
|
|
|
|
}
|
|
|
|
|
|
|
|
type productVariablesDefaultsTestModule struct {
|
|
|
|
ModuleBase
|
|
|
|
DefaultableModuleBase
|
|
|
|
properties productVariablesDefaultsTestProperties
|
|
|
|
}
|
|
|
|
|
|
|
|
func (d *productVariablesDefaultsTestModule) GenerateAndroidBuildActions(ctx ModuleContext) {
|
|
|
|
ctx.Build(pctx, BuildParams{
|
|
|
|
Rule: Touch,
|
|
|
|
Output: PathForModuleOut(ctx, "out"),
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func productVariablesDefaultsTestModuleFactory() Module {
|
|
|
|
module := &productVariablesDefaultsTestModule{}
|
|
|
|
module.AddProperties(&module.properties)
|
|
|
|
module.variableProperties = testProductVariableDefaultsProperties
|
|
|
|
InitAndroidModule(module)
|
|
|
|
InitDefaultableModule(module)
|
|
|
|
return module
|
|
|
|
}
|
|
|
|
|
|
|
|
type productVariablesDefaultsTestDefaults struct {
|
|
|
|
ModuleBase
|
|
|
|
DefaultsModuleBase
|
|
|
|
}
|
|
|
|
|
|
|
|
func productVariablesDefaultsTestDefaultsFactory() Module {
|
|
|
|
defaults := &productVariablesDefaultsTestDefaults{}
|
|
|
|
defaults.AddProperties(&productVariablesDefaultsTestProperties{})
|
|
|
|
defaults.AddProperties(&productVariablesDefaultsTestProperties2{})
|
|
|
|
defaults.variableProperties = testProductVariableDefaultsProperties
|
|
|
|
InitDefaultsModule(defaults)
|
|
|
|
return defaults
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test a defaults module that supports more product variable properties than the target module.
|
|
|
|
func TestProductVariablesDefaults(t *testing.T) {
|
|
|
|
bp := `
|
|
|
|
defaults {
|
|
|
|
name: "defaults",
|
|
|
|
product_variables: {
|
|
|
|
eng: {
|
|
|
|
foo: ["product_variable_defaults"],
|
|
|
|
bar: ["product_variable_defaults"],
|
|
|
|
},
|
|
|
|
},
|
|
|
|
foo: ["defaults"],
|
|
|
|
bar: ["defaults"],
|
|
|
|
}
|
|
|
|
|
|
|
|
test {
|
|
|
|
name: "foo",
|
|
|
|
defaults: ["defaults"],
|
|
|
|
foo: ["module"],
|
|
|
|
product_variables: {
|
|
|
|
eng: {
|
|
|
|
foo: ["product_variable_module"],
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
`
|
|
|
|
|
|
|
|
config := TestConfig(buildDir, nil, bp, nil)
|
|
|
|
config.TestProductVariables.Eng = boolPtr(true)
|
|
|
|
|
2020-10-30 08:09:13 +08:00
|
|
|
ctx := NewTestContext(config)
|
2020-02-07 09:01:55 +08:00
|
|
|
|
|
|
|
ctx.RegisterModuleType("test", productVariablesDefaultsTestModuleFactory)
|
|
|
|
ctx.RegisterModuleType("defaults", productVariablesDefaultsTestDefaultsFactory)
|
|
|
|
|
|
|
|
ctx.PreArchMutators(RegisterDefaultsPreArchMutators)
|
|
|
|
ctx.PreDepsMutators(func(ctx RegisterMutatorsContext) {
|
|
|
|
ctx.BottomUp("variable", VariableMutator).Parallel()
|
|
|
|
})
|
|
|
|
|
2020-10-30 08:09:13 +08:00
|
|
|
ctx.Register()
|
2020-02-07 09:01:55 +08:00
|
|
|
|
|
|
|
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
|
|
|
|
FailIfErrored(t, errs)
|
|
|
|
_, errs = ctx.PrepareBuildActions(config)
|
|
|
|
FailIfErrored(t, errs)
|
|
|
|
|
|
|
|
foo := ctx.ModuleForTests("foo", "").Module().(*productVariablesDefaultsTestModule)
|
|
|
|
|
|
|
|
want := []string{"defaults", "module", "product_variable_defaults", "product_variable_module"}
|
|
|
|
if g, w := foo.properties.Foo, want; !reflect.DeepEqual(g, w) {
|
|
|
|
t.Errorf("expected foo %q, got %q", w, g)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-09-25 13:19:02 +08:00
|
|
|
func BenchmarkSliceToTypeArray(b *testing.B) {
|
|
|
|
for _, n := range []int{1, 2, 4, 8, 100} {
|
|
|
|
var propStructs []interface{}
|
|
|
|
for i := 0; i < n; i++ {
|
|
|
|
propStructs = append(propStructs, &struct {
|
|
|
|
A *string
|
|
|
|
B string
|
|
|
|
}{})
|
|
|
|
|
|
|
|
}
|
|
|
|
b.Run(strconv.Itoa(n), func(b *testing.B) {
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
|
|
_ = sliceToTypeArray(propStructs)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|