2018-11-13 02:13:39 +08:00
|
|
|
// Copyright 2018 Google Inc. All rights reserved.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package dexpreopt
|
|
|
|
|
|
|
|
import (
|
2019-01-31 09:32:39 +08:00
|
|
|
"android/soong/android"
|
2019-10-03 00:42:44 +08:00
|
|
|
"fmt"
|
2018-11-13 02:13:39 +08:00
|
|
|
"testing"
|
|
|
|
)
|
|
|
|
|
2020-02-01 01:44:54 +08:00
|
|
|
func testSystemModuleConfig(ctx android.PathContext, name string) *ModuleConfig {
|
2019-10-03 00:42:44 +08:00
|
|
|
return testModuleConfig(ctx, name, "system")
|
|
|
|
}
|
|
|
|
|
2020-02-01 01:44:54 +08:00
|
|
|
func testSystemProductModuleConfig(ctx android.PathContext, name string) *ModuleConfig {
|
2019-10-03 00:42:44 +08:00
|
|
|
return testModuleConfig(ctx, name, "system/product")
|
|
|
|
}
|
|
|
|
|
2020-02-01 01:44:54 +08:00
|
|
|
func testProductModuleConfig(ctx android.PathContext, name string) *ModuleConfig {
|
2019-10-03 00:42:44 +08:00
|
|
|
return testModuleConfig(ctx, name, "product")
|
|
|
|
}
|
|
|
|
|
2020-02-01 01:44:54 +08:00
|
|
|
func testModuleConfig(ctx android.PathContext, name, partition string) *ModuleConfig {
|
|
|
|
return &ModuleConfig{
|
2019-10-03 00:42:44 +08:00
|
|
|
Name: name,
|
|
|
|
DexLocation: fmt.Sprintf("/%s/app/test/%s.apk", partition, name),
|
|
|
|
BuildPath: android.PathForOutput(ctx, fmt.Sprintf("%s/%s.apk", name, name)),
|
|
|
|
DexPath: android.PathForOutput(ctx, fmt.Sprintf("%s/dex/%s.jar", name, name)),
|
2019-02-16 02:39:37 +08:00
|
|
|
UncompressedDex: false,
|
|
|
|
HasApkLibraries: false,
|
|
|
|
PreoptFlags: nil,
|
|
|
|
ProfileClassListing: android.OptionalPath{},
|
|
|
|
ProfileIsTextListing: false,
|
Add non-fatal mode for verify_uses_libraries check.
The new mode is enabled with environment variable
RELAX_USES_LIBRARY_CHECK. If the variable is set to true, then a
verify_uses_libraries check failure does not fail the build, instead it
sets a special compiler filter "extract" for dexpreopt, which means that
the DEX file will be extracted, but it won't be compiled to native code.
Class loader context will be set to empty in this case (not &, as it is
going to be deprecated soon).
If the variable RELAX_USES_LIBRARY_CHECK is unset or set to something
other than "true", then the old behaviour of the verify_uses_libraries
check is preserved.
The intended use case for this flag is to have a smoother migration path
for the Java modules that need to add <uses-library> information in
the build files. The flag allows to quickly silence build errors. This
flag should be used with caution and only as a temporary measure, as it
masks real errors and affects performance.
verify_uses_libraries check is reworked so that it writes the error
message to a status file (which is used instead of the former timestamp
file). Currently the stored error message is not used, but it may be
used later to produce a warning. Dexpreopt command checks if the status
file exists and is nonempty; if that is the case, then compiler filter
is set to "extract".
Bug: 132357300
Test: Manually add some mismatch between the libraries in the Android.bp
and Android.mk files for dexpreopted apps, build with
RELAX_USES_LIBRARY_CHECK=true and obsserve that the build doesn't
fail and they are compiled with compiler-filter "extract".
Unset RELAX_USES_LIBRARY_CHECK and observe that the build fails.
Change-Id: Ibb5d993a25b1df1d2e70b7d5aafc6997f9d64e67
2021-02-18 00:23:28 +08:00
|
|
|
EnforceUsesLibrariesStatusFile: android.PathForOutput(ctx, fmt.Sprintf("%s/enforce_uses_libraries.status", name)),
|
2019-02-16 02:39:37 +08:00
|
|
|
EnforceUsesLibraries: false,
|
2020-11-03 23:15:46 +08:00
|
|
|
ClassLoaderContexts: nil,
|
2019-02-16 02:39:37 +08:00
|
|
|
Archs: []android.ArchType{android.Arm},
|
2019-11-08 18:54:21 +08:00
|
|
|
DexPreoptImagesDeps: []android.OutputPaths{android.OutputPaths{}},
|
|
|
|
DexPreoptImageLocations: []string{},
|
2019-02-16 02:39:37 +08:00
|
|
|
PreoptBootClassPathDexFiles: nil,
|
|
|
|
PreoptBootClassPathDexLocations: nil,
|
|
|
|
PreoptExtractedApk: false,
|
|
|
|
NoCreateAppImage: false,
|
|
|
|
ForceCreateAppImage: false,
|
|
|
|
PresignedPrebuilt: false,
|
|
|
|
}
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestDexPreopt(t *testing.T) {
|
2020-01-11 04:32:59 +08:00
|
|
|
config := android.TestConfig("out", nil, "", nil)
|
2020-11-17 09:32:30 +08:00
|
|
|
ctx := android.BuilderContextForTesting(config)
|
2021-01-21 23:05:11 +08:00
|
|
|
globalSoong := globalSoongConfigForTests()
|
2020-01-11 04:32:59 +08:00
|
|
|
global := GlobalConfigForTests(ctx)
|
|
|
|
module := testSystemModuleConfig(ctx, "test")
|
2018-11-13 02:13:39 +08:00
|
|
|
|
2020-01-11 04:32:59 +08:00
|
|
|
rule, err := GenerateDexpreoptRule(ctx, globalSoong, global, module)
|
2018-11-13 02:13:39 +08:00
|
|
|
if err != nil {
|
2019-02-16 02:39:37 +08:00
|
|
|
t.Fatal(err)
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
|
|
|
|
2019-02-12 06:11:09 +08:00
|
|
|
wantInstalls := android.RuleBuilderInstalls{
|
2019-02-16 02:39:37 +08:00
|
|
|
{android.PathForOutput(ctx, "test/oat/arm/package.odex"), "/system/app/test/oat/arm/test.odex"},
|
|
|
|
{android.PathForOutput(ctx, "test/oat/arm/package.vdex"), "/system/app/test/oat/arm/test.vdex"},
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
|
|
|
|
2019-02-26 02:25:24 +08:00
|
|
|
if rule.Installs().String() != wantInstalls.String() {
|
2018-11-13 02:13:39 +08:00
|
|
|
t.Errorf("\nwant installs:\n %v\ngot:\n %v", wantInstalls, rule.Installs())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestDexPreoptSystemOther(t *testing.T) {
|
2020-01-11 04:32:59 +08:00
|
|
|
config := android.TestConfig("out", nil, "", nil)
|
2020-11-17 09:32:30 +08:00
|
|
|
ctx := android.BuilderContextForTesting(config)
|
2021-01-21 23:05:11 +08:00
|
|
|
globalSoong := globalSoongConfigForTests()
|
2019-10-03 00:42:44 +08:00
|
|
|
global := GlobalConfigForTests(ctx)
|
|
|
|
systemModule := testSystemModuleConfig(ctx, "Stest")
|
|
|
|
systemProductModule := testSystemProductModuleConfig(ctx, "SPtest")
|
|
|
|
productModule := testProductModuleConfig(ctx, "Ptest")
|
2018-11-13 02:13:39 +08:00
|
|
|
|
|
|
|
global.HasSystemOther = true
|
|
|
|
|
2019-10-03 00:42:44 +08:00
|
|
|
type moduleTest struct {
|
2020-02-01 01:44:54 +08:00
|
|
|
module *ModuleConfig
|
2019-10-03 00:42:44 +08:00
|
|
|
expectedPartition string
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
2019-10-03 00:42:44 +08:00
|
|
|
tests := []struct {
|
|
|
|
patterns []string
|
|
|
|
moduleTests []moduleTest
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
patterns: []string{"app/%"},
|
|
|
|
moduleTests: []moduleTest{
|
2019-10-03 21:18:45 +08:00
|
|
|
{module: systemModule, expectedPartition: "system_other/system"},
|
2019-10-03 00:42:44 +08:00
|
|
|
{module: systemProductModule, expectedPartition: "system/product"},
|
|
|
|
{module: productModule, expectedPartition: "product"},
|
|
|
|
},
|
|
|
|
},
|
2020-09-15 17:28:55 +08:00
|
|
|
// product/app/% only applies to product apps inside the system partition
|
2019-10-03 00:42:44 +08:00
|
|
|
{
|
|
|
|
patterns: []string{"app/%", "product/app/%"},
|
|
|
|
moduleTests: []moduleTest{
|
2019-10-03 21:18:45 +08:00
|
|
|
{module: systemModule, expectedPartition: "system_other/system"},
|
|
|
|
{module: systemProductModule, expectedPartition: "system_other/system/product"},
|
2020-09-15 17:28:55 +08:00
|
|
|
{module: productModule, expectedPartition: "product"},
|
2019-10-03 00:42:44 +08:00
|
|
|
},
|
|
|
|
},
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
|
|
|
|
2019-10-03 00:42:44 +08:00
|
|
|
for _, test := range tests {
|
|
|
|
global.PatternsOnSystemOther = test.patterns
|
|
|
|
for _, mt := range test.moduleTests {
|
2020-01-11 04:32:59 +08:00
|
|
|
rule, err := GenerateDexpreoptRule(ctx, globalSoong, global, mt.module)
|
2019-10-03 00:42:44 +08:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
name := mt.module.Name
|
|
|
|
wantInstalls := android.RuleBuilderInstalls{
|
|
|
|
{android.PathForOutput(ctx, name+"/oat/arm/package.odex"), fmt.Sprintf("/%s/app/test/oat/arm/%s.odex", mt.expectedPartition, name)},
|
|
|
|
{android.PathForOutput(ctx, name+"/oat/arm/package.vdex"), fmt.Sprintf("/%s/app/test/oat/arm/%s.vdex", mt.expectedPartition, name)},
|
|
|
|
}
|
|
|
|
|
|
|
|
if rule.Installs().String() != wantInstalls.String() {
|
2020-09-15 17:28:55 +08:00
|
|
|
t.Errorf("\nwant installs:\n %v\ngot:\n %v", wantInstalls, rule.Installs())
|
2019-10-03 00:42:44 +08:00
|
|
|
}
|
|
|
|
}
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
2019-10-03 00:42:44 +08:00
|
|
|
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestDexPreoptProfile(t *testing.T) {
|
2020-01-11 04:32:59 +08:00
|
|
|
config := android.TestConfig("out", nil, "", nil)
|
2020-11-17 09:32:30 +08:00
|
|
|
ctx := android.BuilderContextForTesting(config)
|
2021-01-21 23:05:11 +08:00
|
|
|
globalSoong := globalSoongConfigForTests()
|
2020-01-11 04:32:59 +08:00
|
|
|
global := GlobalConfigForTests(ctx)
|
|
|
|
module := testSystemModuleConfig(ctx, "test")
|
2018-11-13 02:13:39 +08:00
|
|
|
|
2019-02-16 02:39:37 +08:00
|
|
|
module.ProfileClassListing = android.OptionalPathForPath(android.PathForTesting("profile"))
|
2018-11-13 02:13:39 +08:00
|
|
|
|
2020-01-11 04:32:59 +08:00
|
|
|
rule, err := GenerateDexpreoptRule(ctx, globalSoong, global, module)
|
2018-11-13 02:13:39 +08:00
|
|
|
if err != nil {
|
2019-02-16 02:39:37 +08:00
|
|
|
t.Fatal(err)
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
|
|
|
|
2019-02-12 06:11:09 +08:00
|
|
|
wantInstalls := android.RuleBuilderInstalls{
|
2019-02-16 02:39:37 +08:00
|
|
|
{android.PathForOutput(ctx, "test/profile.prof"), "/system/app/test/test.apk.prof"},
|
|
|
|
{android.PathForOutput(ctx, "test/oat/arm/package.art"), "/system/app/test/oat/arm/test.art"},
|
|
|
|
{android.PathForOutput(ctx, "test/oat/arm/package.odex"), "/system/app/test/oat/arm/test.odex"},
|
|
|
|
{android.PathForOutput(ctx, "test/oat/arm/package.vdex"), "/system/app/test/oat/arm/test.vdex"},
|
2018-11-13 02:13:39 +08:00
|
|
|
}
|
|
|
|
|
2019-02-26 02:25:24 +08:00
|
|
|
if rule.Installs().String() != wantInstalls.String() {
|
2018-11-13 02:13:39 +08:00
|
|
|
t.Errorf("\nwant installs:\n %v\ngot:\n %v", wantInstalls, rule.Installs())
|
|
|
|
}
|
|
|
|
}
|
2021-04-07 23:00:19 +08:00
|
|
|
|
|
|
|
func TestDexPreoptConfigToJson(t *testing.T) {
|
|
|
|
config := android.TestConfig("out", nil, "", nil)
|
|
|
|
ctx := android.BuilderContextForTesting(config)
|
|
|
|
module := testSystemModuleConfig(ctx, "test")
|
|
|
|
data, err := moduleConfigToJSON(module)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Failed to convert module config data to JSON, %v", err)
|
|
|
|
}
|
|
|
|
parsed, err := ParseModuleConfig(ctx, data)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Failed to parse JSON, %v", err)
|
|
|
|
}
|
|
|
|
before := fmt.Sprintf("%v", module)
|
|
|
|
after := fmt.Sprintf("%v", parsed)
|
|
|
|
android.AssertStringEquals(t, "The result must be the same as the original after marshalling and unmarshalling it.", before, after)
|
|
|
|
}
|