From 327b6f0c6932c8c48798410c3d3f8a9a6c5b41ea Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Mon, 10 Dec 2018 16:28:56 -0800 Subject: [PATCH] Disable cert-dcl16-c clang-tidy check for mingw32. Bug: 120614316 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,cert-* Change-Id: Ibe46409543eaa4a7f3b710d9742b3252dc9ac7e8 --- cc/tidy.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cc/tidy.go b/cc/tidy.go index ddb445a02..6bac84651 100644 --- a/cc/tidy.go +++ b/cc/tidy.go @@ -108,6 +108,12 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags { if len(tidy.Properties.Tidy_checks) > 0 { tidyChecks = tidyChecks + "," + strings.Join(esc(tidy.Properties.Tidy_checks), ",") } + if ctx.Windows() { + // https://b.corp.google.com/issues/120614316 + // mingw32 has cert-dcl16-c warning in NO_ERROR, + // which is used in many Android files. + tidyChecks = tidyChecks + ",-cert-dcl16-c" + } flags.TidyFlags = append(flags.TidyFlags, tidyChecks) return flags