From 940dfd4db2d73368e20c29a086e4ef9a1d3b1ca0 Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Thu, 4 Feb 2021 15:37:34 +0900 Subject: [PATCH 1/2] android_filesystem is OutputFileProducer ... to be able to reference the module in data property of test modules. Bug: N/A Test: m VirtualizationHostTestCases Change-Id: I199f070e811011cea6189ef24c0b2d8a683f79d0 --- filesystem/filesystem.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/filesystem/filesystem.go b/filesystem/filesystem.go index 5092ad06e..2fe97d372 100644 --- a/filesystem/filesystem.go +++ b/filesystem/filesystem.go @@ -250,6 +250,16 @@ func (f *filesystem) AndroidMkEntries() []android.AndroidMkEntries { }} } +var _ android.OutputFileProducer = (*filesystem)(nil) + +// Implements android.OutputFileProducer +func (f *filesystem) OutputFiles(tag string) (android.Paths, error) { + if tag == "" { + return []android.Path{f.output}, nil + } + return nil, fmt.Errorf("unsupported module reference tag %q", tag) +} + // Filesystem is the public interface for the filesystem struct. Currently, it's only for the apex // package to have access to the output file. type Filesystem interface { From 599992bc3e6795b94949eefd36e5812df237d03a Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Thu, 4 Feb 2021 19:40:56 +0900 Subject: [PATCH 2/2] Install ko to /lib/modules ... not to /lib/module Bug: 178980227 Test: m Change-Id: I6a5357e9e83e736181b885b64c76e0b7e5ffadf2 --- kernel/prebuilt_kernel_modules.go | 2 +- kernel/prebuilt_kernel_modules_test.go | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel/prebuilt_kernel_modules.go b/kernel/prebuilt_kernel_modules.go index 94e04cbc2..14ac02148 100644 --- a/kernel/prebuilt_kernel_modules.go +++ b/kernel/prebuilt_kernel_modules.go @@ -72,7 +72,7 @@ func (pkm *prebuiltKernelModules) GenerateAndroidBuildActions(ctx android.Module depmodOut := runDepmod(ctx, modules) strippedModules := stripDebugSymbols(ctx, modules) - installDir := android.PathForModuleInstall(ctx, "lib", "module") + installDir := android.PathForModuleInstall(ctx, "lib", "modules") if pkm.KernelVersion() != "" { installDir = installDir.Join(ctx, pkm.KernelVersion()) } diff --git a/kernel/prebuilt_kernel_modules_test.go b/kernel/prebuilt_kernel_modules_test.go index b49e1679c..433548bc0 100644 --- a/kernel/prebuilt_kernel_modules_test.go +++ b/kernel/prebuilt_kernel_modules_test.go @@ -84,12 +84,12 @@ func TestKernelModulesFilelist(t *testing.T) { }) expected := []string{ - "lib/module/5.10/mod1.ko", - "lib/module/5.10/mod2.ko", - "lib/module/5.10/modules.load", - "lib/module/5.10/modules.dep", - "lib/module/5.10/modules.softdep", - "lib/module/5.10/modules.alias", + "lib/modules/5.10/mod1.ko", + "lib/modules/5.10/mod2.ko", + "lib/modules/5.10/modules.load", + "lib/modules/5.10/modules.dep", + "lib/modules/5.10/modules.softdep", + "lib/modules/5.10/modules.alias", } var actual []string