From 38620edca183b5b5df3c23d4d465ba44c76e78c5 Mon Sep 17 00:00:00 2001 From: Bob Badour Date: Thu, 17 Dec 2020 16:30:00 -0800 Subject: [PATCH] getNamespacesToSearchForModule to use blueprint.Namespace Allow for nil argument. Test: m all Change-Id: I03e3afe00d72905f259ce1af5085387b796ebc3d --- android/namespace.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/android/namespace.go b/android/namespace.go index 9d7e8acf4..d137636e2 100644 --- a/android/namespace.go +++ b/android/namespace.go @@ -232,13 +232,14 @@ func (r *NameResolver) parseFullyQualifiedName(name string) (namespaceName strin } -func (r *NameResolver) getNamespacesToSearchForModule(sourceNamespace *Namespace) (searchOrder []*Namespace) { - if sourceNamespace.visibleNamespaces == nil { +func (r *NameResolver) getNamespacesToSearchForModule(sourceNamespace blueprint.Namespace) (searchOrder []*Namespace) { + ns, ok := sourceNamespace.(*Namespace) + if !ok || ns.visibleNamespaces == nil { // When handling dependencies before namespaceMutator, assume they are non-Soong Blueprint modules and give // access to all namespaces. return r.sortedNamespaces.sortedItems() } - return sourceNamespace.visibleNamespaces + return ns.visibleNamespaces } func (r *NameResolver) ModuleFromName(name string, namespace blueprint.Namespace) (group blueprint.ModuleGroup, found bool) { @@ -252,7 +253,7 @@ func (r *NameResolver) ModuleFromName(name string, namespace blueprint.Namespace container := namespace.moduleContainer return container.ModuleFromName(moduleName, nil) } - for _, candidate := range r.getNamespacesToSearchForModule(namespace.(*Namespace)) { + for _, candidate := range r.getNamespacesToSearchForModule(namespace) { group, found = candidate.moduleContainer.ModuleFromName(name, nil) if found { return group, true