Merge "OverridableModuleBase shouldn't embed ModuleBase." am: 0b4ca8605c
am: bb8bae641d
Change-Id: I4a21037de5027747eb4ce1dd12e5566dafca98c6
This commit is contained in:
commit
57811d450d
|
@ -95,8 +95,6 @@ type OverridableModule interface {
|
|||
|
||||
// Base module struct for overridable module types
|
||||
type OverridableModuleBase struct {
|
||||
ModuleBase
|
||||
|
||||
// List of OverrideModules that override this base module
|
||||
overrides []OverrideModule
|
||||
// Used to parallelize registerOverrideMutator executions. Note that only addOverride locks this
|
||||
|
@ -144,7 +142,7 @@ func (b *OverridableModuleBase) override(ctx BaseModuleContext, o OverrideModule
|
|||
// Adds the base module to the overrides property, if exists, of the overriding module. See the
|
||||
// comment on OverridableModuleBase.overridesProperty for details.
|
||||
if b.overridesProperty != nil {
|
||||
*b.overridesProperty = append(*b.overridesProperty, b.Name())
|
||||
*b.overridesProperty = append(*b.overridesProperty, ctx.ModuleName())
|
||||
}
|
||||
for _, p := range b.overridableProperties {
|
||||
for _, op := range o.getOverridingProperties() {
|
||||
|
|
Loading…
Reference in New Issue