openkylin
/
platform_build_soong
mirror of https://gitee.com/openkylin/platform_build_soong.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge "Remove panics from reportMissingVariationDependency"

This commit is contained in:
Paul Duffin 2021-04-27 17:00:22 +00:00 committed by Gerrit Code Review
parent 8fb66f48c7 81667c8c11
commit a75af16878
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
java/bootclasspath.go
View File

@ -15,9 +15,8 @@
package java package java
import ( import (
"fmt"
"android/soong/android" "android/soong/android"
"github.com/google/blueprint" "github.com/google/blueprint"
"github.com/google/blueprint/proptools" "github.com/google/blueprint/proptools"
) )
@ -116,15 +115,7 @@ func addDependencyOntoApexModulePair(ctx android.BottomUpMutatorContext, apex st
// reportMissingVariationDependency intentionally adds a dependency on a missing variation in order // reportMissingVariationDependency intentionally adds a dependency on a missing variation in order
// to generate an appropriate error message with information about the available variations. // to generate an appropriate error message with information about the available variations.
func reportMissingVariationDependency(ctx android.BottomUpMutatorContext, variations []blueprint.Variation, name string) { func reportMissingVariationDependency(ctx android.BottomUpMutatorContext, variations []blueprint.Variation, name string) {
modules := ctx.AddFarVariationDependencies(variations, nil, name) ctx.AddFarVariationDependencies(variations, nil, name)
if len(modules) != 1 {
panic(fmt.Errorf("Internal Error: expected one module, found %d", len(modules)))
return
}
if modules[0] != nil {
panic(fmt.Errorf("Internal Error: expected module to be missing but was found: %q", modules[0]))
return
}
} }
// ApexVariantReference specifies a particular apex variant of a module. // ApexVariantReference specifies a particular apex variant of a module.