Merge "Build with OpenJDK 9 -target 1.8 by default (attempt 3)."
This commit is contained in:
commit
ac1e12846c
|
@ -299,7 +299,10 @@ func NewConfig(srcDir, buildDir string) (Config, error) {
|
||||||
func (c *config) fromEnv() error {
|
func (c *config) fromEnv() error {
|
||||||
switch c.Getenv("EXPERIMENTAL_USE_OPENJDK9") {
|
switch c.Getenv("EXPERIMENTAL_USE_OPENJDK9") {
|
||||||
case "":
|
case "":
|
||||||
// Use OpenJDK8
|
if c.Getenv("RUN_ERROR_PRONE") != "true" {
|
||||||
|
// Use OpenJDK9, but target 1.8
|
||||||
|
c.useOpenJDK9 = true
|
||||||
|
}
|
||||||
case "false":
|
case "false":
|
||||||
// Use OpenJDK8
|
// Use OpenJDK8
|
||||||
case "1.8":
|
case "1.8":
|
||||||
|
@ -310,7 +313,7 @@ func (c *config) fromEnv() error {
|
||||||
c.useOpenJDK9 = true
|
c.useOpenJDK9 = true
|
||||||
c.targetOpenJDK9 = true
|
c.targetOpenJDK9 = true
|
||||||
default:
|
default:
|
||||||
return fmt.Errorf(`Invalid value for EXPERIMENTAL_USE_OPENJDK9, should be "", "1.8", or "true"`)
|
return fmt.Errorf(`Invalid value for EXPERIMENTAL_USE_OPENJDK9, should be "", "false", "1.8", or "true"`)
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
|
|
|
@ -152,7 +152,16 @@ func NewConfig(ctx Context, args ...string) Config {
|
||||||
if override, ok := ret.environ.Get("OVERRIDE_ANDROID_JAVA_HOME"); ok {
|
if override, ok := ret.environ.Get("OVERRIDE_ANDROID_JAVA_HOME"); ok {
|
||||||
return override
|
return override
|
||||||
}
|
}
|
||||||
if v, ok := ret.environ.Get("EXPERIMENTAL_USE_OPENJDK9"); ok && v != "" && v != "false" {
|
v, ok := ret.environ.Get("EXPERIMENTAL_USE_OPENJDK9")
|
||||||
|
if !ok {
|
||||||
|
v2, ok2 := ret.environ.Get("RUN_ERROR_PRONE")
|
||||||
|
if ok2 && (v2 == "true") {
|
||||||
|
v = "false"
|
||||||
|
} else {
|
||||||
|
v = "1.8"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if v != "false" {
|
||||||
return java9Home
|
return java9Home
|
||||||
}
|
}
|
||||||
return java8Home
|
return java8Home
|
||||||
|
|
Loading…
Reference in New Issue