From b19b58a015674ce7b33de6f474c2e9be2d90a739 Mon Sep 17 00:00:00 2001 From: Jeongik Cha Date: Mon, 26 Apr 2021 22:57:27 +0900 Subject: [PATCH] Drop DexPreoptImages field in dexpreopt config The field isn't used anymore. And DexPreoptImagesDeps will have the slice of which size is the same as Archs to avoid an error. Bug: 158843648 Test: m Change-Id: I520063ff7376811febbc82e1a0a43785feb5bbb2 --- dexpreopt/config.go | 6 +----- dexpreopt/dexpreopt_test.go | 1 - java/dexpreopt.go | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/dexpreopt/config.go b/dexpreopt/config.go index 151f032fb..830a1e78c 100644 --- a/dexpreopt/config.go +++ b/dexpreopt/config.go @@ -130,7 +130,6 @@ type ModuleConfig struct { ClassLoaderContexts ClassLoaderContextMap Archs []android.ArchType - DexPreoptImages android.Paths DexPreoptImagesDeps []android.OutputPaths DexPreoptImageLocations []string @@ -275,7 +274,6 @@ type moduleJSONConfig struct { EnforceUsesLibrariesStatusFile string ClassLoaderContexts jsonClassLoaderContextMap - DexPreoptImages []string DexPreoptImagesDeps [][]string PreoptBootClassPathDexFiles []string @@ -301,11 +299,10 @@ func ParseModuleConfig(ctx android.PathContext, data []byte) (*ModuleConfig, err config.ModuleConfig.ProfileClassListing = android.OptionalPathForPath(constructPath(ctx, config.ProfileClassListing)) config.ModuleConfig.EnforceUsesLibrariesStatusFile = constructPath(ctx, config.EnforceUsesLibrariesStatusFile) config.ModuleConfig.ClassLoaderContexts = fromJsonClassLoaderContext(ctx, config.ClassLoaderContexts) - config.ModuleConfig.DexPreoptImages = constructPaths(ctx, config.DexPreoptImages) config.ModuleConfig.PreoptBootClassPathDexFiles = constructPaths(ctx, config.PreoptBootClassPathDexFiles) // This needs to exist, but dependencies are already handled in Make, so we don't need to pass them through JSON. - config.ModuleConfig.DexPreoptImagesDeps = make([]android.OutputPaths, len(config.ModuleConfig.DexPreoptImages)) + config.ModuleConfig.DexPreoptImagesDeps = make([]android.OutputPaths, len(config.ModuleConfig.Archs)) return config.ModuleConfig, nil } @@ -327,7 +324,6 @@ func moduleConfigToJSON(config *ModuleConfig) ([]byte, error) { ProfileBootListing: config.ProfileBootListing.String(), EnforceUsesLibrariesStatusFile: config.EnforceUsesLibrariesStatusFile.String(), ClassLoaderContexts: toJsonClassLoaderContext(config.ClassLoaderContexts), - DexPreoptImages: config.DexPreoptImages.Strings(), DexPreoptImagesDeps: pathsListToStringLists(config.DexPreoptImagesDeps), PreoptBootClassPathDexFiles: config.PreoptBootClassPathDexFiles.Strings(), ModuleConfig: config, diff --git a/dexpreopt/dexpreopt_test.go b/dexpreopt/dexpreopt_test.go index cd7551c8d..bb4e80e1a 100644 --- a/dexpreopt/dexpreopt_test.go +++ b/dexpreopt/dexpreopt_test.go @@ -47,7 +47,6 @@ func testModuleConfig(ctx android.PathContext, name, partition string) *ModuleCo EnforceUsesLibraries: false, ClassLoaderContexts: nil, Archs: []android.ArchType{android.Arm}, - DexPreoptImages: android.Paths{android.PathForTesting("system/framework/arm/boot.art")}, DexPreoptImagesDeps: []android.OutputPaths{android.OutputPaths{}}, DexPreoptImageLocations: []string{}, PreoptBootClassPathDexFiles: nil, diff --git a/java/dexpreopt.go b/java/dexpreopt.go index d00d74b8c..0020a2d92 100644 --- a/java/dexpreopt.go +++ b/java/dexpreopt.go @@ -225,7 +225,6 @@ func (d *dexpreopter) dexpreopt(ctx android.ModuleContext, dexJarFile android.Wr ClassLoaderContexts: d.classLoaderContexts, Archs: archs, - DexPreoptImages: images, DexPreoptImagesDeps: imagesDeps, DexPreoptImageLocations: imageLocations,