Create C-Suite config module

* Defined a build target csuite_config.go for C-Suite, so that C-Suite
test modules can be declare in Android.bp files.
* Modified vts_config.go to use the general Makefile
suite_host_config.mk.

Test: make csuite, forrest test for vts
Change-Id: I5f67c54e05b113ac6c5d226930618e6811e6e602
Merged-In: I5f67c54e05b113ac6c5d226930618e6811e6e602
This commit is contained in:
karenluo 2019-10-10 21:26:26 -04:00 committed by Kailin Luo
parent b244e84de6
commit c031819352
4 changed files with 132 additions and 6 deletions

View File

@ -45,6 +45,7 @@ bootstrap_go_package {
"android/api_levels.go",
"android/arch.go",
"android/config.go",
"android/csuite_config.go",
"android/defaults.go",
"android/defs.go",
"android/expand.go",
@ -85,6 +86,7 @@ bootstrap_go_package {
"android/androidmk_test.go",
"android/arch_test.go",
"android/config_test.go",
"android/csuite_config_test.go",
"android/expand_test.go",
"android/module_test.go",
"android/mutator_test.go",

70
android/csuite_config.go Normal file
View File

@ -0,0 +1,70 @@
// Copyright 2019 Google Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package android
import (
"fmt"
"io"
)
func init() {
RegisterModuleType("csuite_config", CSuiteConfigFactory)
}
type csuiteConfigProperties struct {
// Override the default (AndroidTest.xml) test manifest file name.
Test_config *string
}
type CSuiteConfig struct {
ModuleBase
properties csuiteConfigProperties
OutputFilePath OutputPath
}
func (me *CSuiteConfig) GenerateAndroidBuildActions(ctx ModuleContext) {
me.OutputFilePath = PathForModuleOut(ctx, me.BaseModuleName()).OutputPath
}
func (me *CSuiteConfig) AndroidMk() AndroidMkData {
androidMkData := AndroidMkData{
Class: "FAKE",
Include: "$(BUILD_SYSTEM)/suite_host_config.mk",
OutputFile: OptionalPathForPath(me.OutputFilePath),
}
androidMkData.Extra = []AndroidMkExtraFunc{
func(w io.Writer, outputFile Path) {
if me.properties.Test_config != nil {
fmt.Fprintf(w, "LOCAL_TEST_CONFIG := %s\n",
*me.properties.Test_config)
}
fmt.Fprintln(w, "LOCAL_COMPATIBILITY_SUITE := csuite")
},
}
return androidMkData
}
func InitCSuiteConfigModule(me *CSuiteConfig) {
me.AddProperties(&me.properties)
}
// csuite_config generates an App Compatibility Test Suite (C-Suite) configuration file from the
// <test_config> xml file and stores it in a subdirectory of $(HOST_OUT).
func CSuiteConfigFactory() Module {
module := &CSuiteConfig{}
InitCSuiteConfigModule(module)
InitAndroidArchModule(module, HostSupported, MultilibFirst)
return module
}

View File

@ -0,0 +1,53 @@
// Copyright 2019 Google Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package android
import (
"testing"
)
func testCSuiteConfig(test *testing.T, bpFileContents string) *TestContext {
config := TestArchConfig(buildDir, nil)
ctx := NewTestArchContext()
ctx.RegisterModuleType("csuite_config", ModuleFactoryAdaptor(CSuiteConfigFactory))
ctx.Register()
mockFiles := map[string][]byte{
"Android.bp": []byte(bpFileContents),
}
ctx.MockFileSystem(mockFiles)
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
FailIfErrored(test, errs)
_, errs = ctx.PrepareBuildActions(config)
FailIfErrored(test, errs)
return ctx
}
func TestCSuiteConfig(t *testing.T) {
ctx := testCSuiteConfig(t, `
csuite_config { name: "plain"}
csuite_config { name: "with_manifest", test_config: "manifest.xml" }
`)
variants := ctx.ModuleVariantsForTests("plain")
if len(variants) > 1 {
t.Errorf("expected 1, got %d", len(variants))
}
expectedOutputFilename := ctx.ModuleForTests(
"plain", variants[0]).Module().(*CSuiteConfig).OutputFilePath.Base()
if expectedOutputFilename != "plain" {
t.Errorf("expected plain, got %q", expectedOutputFilename)
}
}

View File

@ -41,16 +41,17 @@ func (me *VtsConfig) GenerateAndroidBuildActions(ctx ModuleContext) {
func (me *VtsConfig) AndroidMk() AndroidMkData {
androidMkData := AndroidMkData{
Class: "FAKE",
Include: "$(BUILD_SYSTEM)/android_vts_host_config.mk",
Include: "$(BUILD_SYSTEM)/suite_host_config.mk",
OutputFile: OptionalPathForPath(me.OutputFilePath),
}
if me.properties.Test_config != nil {
androidMkData.Extra = []AndroidMkExtraFunc{
func(w io.Writer, outputFile Path) {
androidMkData.Extra = []AndroidMkExtraFunc{
func(w io.Writer, outputFile Path) {
if me.properties.Test_config != nil {
fmt.Fprintf(w, "LOCAL_TEST_CONFIG := %s\n",
*me.properties.Test_config)
},
}
}
fmt.Fprintln(w, "LOCAL_COMPATIBILITY_SUITE := vts")
},
}
return androidMkData
}