diff --git a/android/androidmk.go b/android/androidmk.go index 124523f4c..589f0463c 100644 --- a/android/androidmk.go +++ b/android/androidmk.go @@ -80,12 +80,14 @@ type AndroidMkEntries struct { footer bytes.Buffer ExtraEntries []AndroidMkExtraEntriesFunc + ExtraFooters []AndroidMkExtraFootersFunc EntryMap map[string][]string entryOrder []string } type AndroidMkExtraEntriesFunc func(entries *AndroidMkEntries) +type AndroidMkExtraFootersFunc func(w io.Writer, name, prefix, moduleDir string, entries *AndroidMkEntries) func (a *AndroidMkEntries) SetString(name, value string) { if _, ok := a.EntryMap[name]; !ok { @@ -254,9 +256,21 @@ func (a *AndroidMkEntries) fillInEntries(config Config, bpPath string, mod bluep // Write to footer. fmt.Fprintln(&a.footer, "include "+a.Include) + blueprintDir := filepath.Dir(bpPath) + for _, footerFunc := range a.ExtraFooters { + footerFunc(&a.footer, name, prefix, blueprintDir, a) + } } func (a *AndroidMkEntries) write(w io.Writer) { + if a.Disabled { + return + } + + if !a.OutputFile.Valid() { + return + } + w.Write(a.header.Bytes()) for _, name := range a.entryOrder { fmt.Fprintln(w, name+" := "+strings.Join(a.EntryMap[name], " ")) @@ -264,6 +278,10 @@ func (a *AndroidMkEntries) write(w io.Writer) { w.Write(a.footer.Bytes()) } +func (a *AndroidMkEntries) FooterLinesForTests() []string { + return strings.Split(string(a.footer.Bytes()), "\n") +} + func AndroidMkSingleton() Singleton { return &androidMkSingleton{} } diff --git a/java/androidmk.go b/java/androidmk.go index f006705ab..246de58e5 100644 --- a/java/androidmk.go +++ b/java/androidmk.go @@ -22,7 +22,9 @@ import ( "android/soong/android" ) -func (library *Library) AndroidMkHostDex(w io.Writer, name string, data android.AndroidMkData) { +// TODO(jungjw): We'll probably want AndroidMkEntriesProvider.AndroidMkEntries to return multiple +// entries so that this can be more error-proof. +func (library *Library) AndroidMkHostDex(w io.Writer, name string, entries *android.AndroidMkEntries) { if Bool(library.deviceProperties.Hostdex) && !library.Host() { fmt.Fprintln(w, "include $(CLEAR_VARS)") fmt.Fprintln(w, "LOCAL_MODULE := "+name+"-hostdex") @@ -38,14 +40,14 @@ func (library *Library) AndroidMkHostDex(w io.Writer, name string, data android. } fmt.Fprintln(w, "LOCAL_SOONG_HEADER_JAR :=", library.headerJarFile.String()) fmt.Fprintln(w, "LOCAL_SOONG_CLASSES_JAR :=", library.implementationAndResourcesJar.String()) - if len(data.Required) > 0 { - fmt.Fprintln(w, "LOCAL_REQUIRED_MODULES :=", strings.Join(data.Required, " ")) + if len(entries.Required) > 0 { + fmt.Fprintln(w, "LOCAL_REQUIRED_MODULES :=", strings.Join(entries.Required, " ")) } - if len(data.Host_required) > 0 { - fmt.Fprintln(w, "LOCAL_HOST_REQUIRED_MODULES :=", strings.Join(data.Host_required, " ")) + if len(entries.Host_required) > 0 { + fmt.Fprintln(w, "LOCAL_HOST_REQUIRED_MODULES :=", strings.Join(entries.Host_required, " ")) } - if len(data.Target_required) > 0 { - fmt.Fprintln(w, "LOCAL_TARGET_REQUIRED_MODULES :=", strings.Join(data.Target_required, " ")) + if len(entries.Target_required) > 0 { + fmt.Fprintln(w, "LOCAL_TARGET_REQUIRED_MODULES :=", strings.Join(entries.Target_required, " ")) } if r := library.deviceProperties.Target.Hostdex.Required; len(r) > 0 { fmt.Fprintln(w, "LOCAL_REQUIRED_MODULES +=", strings.Join(r, " ")) @@ -54,75 +56,64 @@ func (library *Library) AndroidMkHostDex(w io.Writer, name string, data android. } } -func (library *Library) AndroidMk() android.AndroidMkData { +func (library *Library) AndroidMkEntries() android.AndroidMkEntries { if !library.IsForPlatform() { - return android.AndroidMkData{ + return android.AndroidMkEntries{ Disabled: true, } } - return android.AndroidMkData{ + return android.AndroidMkEntries{ Class: "JAVA_LIBRARIES", OutputFile: android.OptionalPathForPath(library.outputFile), Include: "$(BUILD_SYSTEM)/soong_java_prebuilt.mk", - Extra: []android.AndroidMkExtraFunc{ - func(w io.Writer, outputFile android.Path) { + ExtraEntries: []android.AndroidMkExtraEntriesFunc{ + func(entries *android.AndroidMkEntries) { if len(library.logtagsSrcs) > 0 { var logtags []string for _, l := range library.logtagsSrcs { logtags = append(logtags, l.Rel()) } - fmt.Fprintln(w, "LOCAL_LOGTAGS_FILES :=", strings.Join(logtags, " ")) + entries.AddStrings("LOCAL_LOGTAGS_FILES", logtags...) } if library.installFile == nil { - fmt.Fprintln(w, "LOCAL_UNINSTALLABLE_MODULE := true") + entries.SetBoolIfTrue("LOCAL_UNINSTALLABLE_MODULE", true) } if library.dexJarFile != nil { - fmt.Fprintln(w, "LOCAL_SOONG_DEX_JAR :=", library.dexJarFile.String()) + entries.SetString("LOCAL_SOONG_DEX_JAR", library.dexJarFile.String()) } if len(library.dexpreopter.builtInstalled) > 0 { - fmt.Fprintln(w, "LOCAL_SOONG_BUILT_INSTALLED :=", library.dexpreopter.builtInstalled) + entries.SetString("LOCAL_SOONG_BUILT_INSTALLED", library.dexpreopter.builtInstalled) } - fmt.Fprintln(w, "LOCAL_SDK_VERSION :=", library.sdkVersion()) - fmt.Fprintln(w, "LOCAL_SOONG_CLASSES_JAR :=", library.implementationAndResourcesJar.String()) - fmt.Fprintln(w, "LOCAL_SOONG_HEADER_JAR :=", library.headerJarFile.String()) + entries.SetString("LOCAL_SDK_VERSION", library.sdkVersion()) + entries.SetString("LOCAL_SOONG_CLASSES_JAR", library.implementationAndResourcesJar.String()) + entries.SetString("LOCAL_SOONG_HEADER_JAR", library.headerJarFile.String()) if library.jacocoReportClassesFile != nil { - fmt.Fprintln(w, "LOCAL_SOONG_JACOCO_REPORT_CLASSES_JAR :=", library.jacocoReportClassesFile.String()) + entries.SetString("LOCAL_SOONG_JACOCO_REPORT_CLASSES_JAR", library.jacocoReportClassesFile.String()) } - if len(library.exportedSdkLibs) != 0 { - fmt.Fprintln(w, "LOCAL_EXPORT_SDK_LIBRARIES :=", strings.Join(library.exportedSdkLibs, " ")) - } + entries.AddStrings("LOCAL_EXPORT_SDK_LIBRARIES", library.exportedSdkLibs...) if len(library.additionalCheckedModules) != 0 { - fmt.Fprintln(w, "LOCAL_ADDITIONAL_CHECKED_MODULE +=", strings.Join(library.additionalCheckedModules.Strings(), " ")) + entries.AddStrings("LOCAL_ADDITIONAL_CHECKED_MODULE", library.additionalCheckedModules.Strings()...) } if library.proguardDictionary != nil { - fmt.Fprintln(w, "LOCAL_SOONG_PROGUARD_DICT :=", library.proguardDictionary.String()) + entries.SetString("LOCAL_SOONG_PROGUARD_DICT", library.proguardDictionary.String()) } }, }, - Custom: func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) { - android.WriteAndroidMkData(w, data) - library.AndroidMkHostDex(w, name, data) + ExtraFooters: []android.AndroidMkExtraFootersFunc{ + func(w io.Writer, name, prefix, moduleDir string, entries *android.AndroidMkEntries) { + library.AndroidMkHostDex(w, name, entries) + }, }, } } // Called for modules that are a component of a test suite. -func testSuiteComponent(w io.Writer, test_suites []string) { - fmt.Fprintln(w, "LOCAL_MODULE_TAGS := tests") - if len(test_suites) > 0 { - fmt.Fprintln(w, "LOCAL_COMPATIBILITY_SUITE :=", - strings.Join(test_suites, " ")) - } else { - fmt.Fprintln(w, "LOCAL_COMPATIBILITY_SUITE := null-suite") - } -} - -func testSuiteComponentEntries(entries *android.AndroidMkEntries, test_suites []string) { +func testSuiteComponent(entries *android.AndroidMkEntries, test_suites []string) { entries.SetString("LOCAL_MODULE_TAGS", "tests") if len(test_suites) > 0 { entries.AddStrings("LOCAL_COMPATIBILITY_SUITE", test_suites...) @@ -131,27 +122,26 @@ func testSuiteComponentEntries(entries *android.AndroidMkEntries, test_suites [] } } -func (j *Test) AndroidMk() android.AndroidMkData { - data := j.Library.AndroidMk() - data.Extra = append(data.Extra, func(w io.Writer, outputFile android.Path) { - testSuiteComponent(w, j.testProperties.Test_suites) +func (j *Test) AndroidMkEntries() android.AndroidMkEntries { + entries := j.Library.AndroidMkEntries() + entries.ExtraEntries = append(entries.ExtraEntries, func(entries *android.AndroidMkEntries) { + testSuiteComponent(entries, j.testProperties.Test_suites) if j.testConfig != nil { - fmt.Fprintln(w, "LOCAL_FULL_TEST_CONFIG :=", j.testConfig.String()) + entries.SetString("LOCAL_FULL_TEST_CONFIG", j.testConfig.String()) } + androidMkWriteTestData(j.data, entries) }) - androidMkWriteTestData(j.data, &data) - - return data + return entries } -func (j *TestHelperLibrary) AndroidMk() android.AndroidMkData { - data := j.Library.AndroidMk() - data.Extra = append(data.Extra, func(w io.Writer, outputFile android.Path) { - testSuiteComponent(w, j.testHelperLibraryProperties.Test_suites) +func (j *TestHelperLibrary) AndroidMkEntries() android.AndroidMkEntries { + entries := j.Library.AndroidMkEntries() + entries.ExtraEntries = append(entries.ExtraEntries, func(entries *android.AndroidMkEntries) { + testSuiteComponent(entries, j.testHelperLibraryProperties.Test_suites) }) - return data + return entries } func (prebuilt *Import) AndroidMk() android.AndroidMkData { @@ -267,43 +257,40 @@ func (binary *Binary) AndroidMk() android.AndroidMkData { } } -func (app *AndroidApp) AndroidMk() android.AndroidMkData { - return android.AndroidMkData{ +func (app *AndroidApp) AndroidMkEntries() android.AndroidMkEntries { + return android.AndroidMkEntries{ Class: "APPS", OutputFile: android.OptionalPathForPath(app.outputFile), Include: "$(BUILD_SYSTEM)/soong_app_prebuilt.mk", - Extra: []android.AndroidMkExtraFunc{ - func(w io.Writer, outputFile android.Path) { - // TODO(jungjw): This, outputting two LOCAL_MODULE lines, works, but is not ideal. Find a better solution. - if app.Name() != app.installApkName { - fmt.Fprintln(w, "# Overridden by PRODUCT_PACKAGE_NAME_OVERRIDES") - fmt.Fprintln(w, "LOCAL_MODULE :=", app.installApkName) - } - fmt.Fprintln(w, "LOCAL_SOONG_RESOURCE_EXPORT_PACKAGE :=", app.exportPackage.String()) + ExtraEntries: []android.AndroidMkExtraEntriesFunc{ + func(entries *android.AndroidMkEntries) { + // App module names can be overridden. + entries.SetString("LOCAL_MODULE", app.installApkName) + entries.SetString("LOCAL_SOONG_RESOURCE_EXPORT_PACKAGE", app.exportPackage.String()) if app.dexJarFile != nil { - fmt.Fprintln(w, "LOCAL_SOONG_DEX_JAR :=", app.dexJarFile.String()) + entries.SetString("LOCAL_SOONG_DEX_JAR", app.dexJarFile.String()) } if app.implementationAndResourcesJar != nil { - fmt.Fprintln(w, "LOCAL_SOONG_CLASSES_JAR :=", app.implementationAndResourcesJar.String()) + entries.SetString("LOCAL_SOONG_CLASSES_JAR", app.implementationAndResourcesJar.String()) } if app.headerJarFile != nil { - fmt.Fprintln(w, "LOCAL_SOONG_HEADER_JAR :=", app.headerJarFile.String()) + entries.SetString("LOCAL_SOONG_HEADER_JAR", app.headerJarFile.String()) } if app.bundleFile != nil { - fmt.Fprintln(w, "LOCAL_SOONG_BUNDLE :=", app.bundleFile.String()) + entries.SetString("LOCAL_SOONG_BUNDLE", app.bundleFile.String()) } if app.jacocoReportClassesFile != nil { - fmt.Fprintln(w, "LOCAL_SOONG_JACOCO_REPORT_CLASSES_JAR :=", app.jacocoReportClassesFile.String()) + entries.SetString("LOCAL_SOONG_JACOCO_REPORT_CLASSES_JAR", app.jacocoReportClassesFile.String()) } if app.proguardDictionary != nil { - fmt.Fprintln(w, "LOCAL_SOONG_PROGUARD_DICT :=", app.proguardDictionary.String()) + entries.SetString("LOCAL_SOONG_PROGUARD_DICT", app.proguardDictionary.String()) } if app.Name() == "framework-res" { - fmt.Fprintln(w, "LOCAL_MODULE_PATH := $(TARGET_OUT_JAVA_LIBRARIES)") + entries.SetString("LOCAL_MODULE_PATH", "$(TARGET_OUT_JAVA_LIBRARIES)") // Make base_rules.mk not put framework-res in a subdirectory called // framework_res. - fmt.Fprintln(w, "LOCAL_NO_STANDARD_LIBRARIES := true") + entries.SetBoolIfTrue("LOCAL_NO_STANDARD_LIBRARIES", true) } filterRRO := func(filter overlayType) android.Paths { @@ -319,38 +306,36 @@ func (app *AndroidApp) AndroidMk() android.AndroidMkData { } deviceRRODirs := filterRRO(device) if len(deviceRRODirs) > 0 { - fmt.Fprintln(w, "LOCAL_SOONG_DEVICE_RRO_DIRS :=", strings.Join(deviceRRODirs.Strings(), " ")) + entries.AddStrings("LOCAL_SOONG_DEVICE_RRO_DIRS", deviceRRODirs.Strings()...) } productRRODirs := filterRRO(product) if len(productRRODirs) > 0 { - fmt.Fprintln(w, "LOCAL_SOONG_PRODUCT_RRO_DIRS :=", strings.Join(productRRODirs.Strings(), " ")) + entries.AddStrings("LOCAL_SOONG_PRODUCT_RRO_DIRS", productRRODirs.Strings()...) } - if Bool(app.appProperties.Export_package_resources) { - fmt.Fprintln(w, "LOCAL_EXPORT_PACKAGE_RESOURCES := true") - } + entries.SetBoolIfTrue("LOCAL_EXPORT_PACKAGE_RESOURCES", Bool(app.appProperties.Export_package_resources)) - fmt.Fprintln(w, "LOCAL_FULL_MANIFEST_FILE :=", app.manifestPath.String()) + entries.SetString("LOCAL_FULL_MANIFEST_FILE", app.manifestPath.String()) - if Bool(app.appProperties.Privileged) { - fmt.Fprintln(w, "LOCAL_PRIVILEGED_MODULE := true") - } + entries.SetBoolIfTrue("LOCAL_PRIVILEGED_MODULE", Bool(app.appProperties.Privileged)) - fmt.Fprintln(w, "LOCAL_CERTIFICATE :=", app.certificate.Pem.String()) - if overriddenPkgs := app.getOverriddenPackages(); len(overriddenPkgs) > 0 { - fmt.Fprintln(w, "LOCAL_OVERRIDES_PACKAGES :=", strings.Join(overriddenPkgs, " ")) - } + entries.SetString("LOCAL_CERTIFICATE", app.certificate.Pem.String()) + entries.AddStrings("LOCAL_OVERRIDES_PACKAGES", app.getOverriddenPackages()...) for _, jniLib := range app.installJniLibs { - fmt.Fprintln(w, "LOCAL_SOONG_JNI_LIBS_"+jniLib.target.Arch.ArchType.String(), "+=", jniLib.name) + entries.AddStrings("LOCAL_SOONG_JNI_LIBS_"+jniLib.target.Arch.ArchType.String(), jniLib.name) } if len(app.dexpreopter.builtInstalled) > 0 { - fmt.Fprintln(w, "LOCAL_SOONG_BUILT_INSTALLED :=", app.dexpreopter.builtInstalled) + entries.SetString("LOCAL_SOONG_BUILT_INSTALLED", app.dexpreopter.builtInstalled) } for _, split := range app.aapt.splits { install := "$(LOCAL_MODULE_PATH)/" + strings.TrimSuffix(app.installApkName, ".apk") + split.suffix + ".apk" - fmt.Fprintln(w, "LOCAL_SOONG_BUILT_INSTALLED +=", split.path.String()+":"+install) + entries.AddStrings("LOCAL_SOONG_BUILT_INSTALLED", split.path.String()+":"+install) } + }, + }, + ExtraFooters: []android.AndroidMkExtraFootersFunc{ + func(w io.Writer, name, prefix, moduleDir string, entries *android.AndroidMkEntries) { if app.noticeOutputs.Merged.Valid() { fmt.Fprintf(w, "$(call dist-for-goals,%s,%s:%s)\n", app.installApkName, app.noticeOutputs.Merged.String(), app.installApkName+"_NOTICE") @@ -379,52 +364,51 @@ func (a *AndroidApp) getOverriddenPackages() []string { return overridden } -func (a *AndroidTest) AndroidMk() android.AndroidMkData { - data := a.AndroidApp.AndroidMk() - data.Extra = append(data.Extra, func(w io.Writer, outputFile android.Path) { - testSuiteComponent(w, a.testProperties.Test_suites) +func (a *AndroidTest) AndroidMkEntries() android.AndroidMkEntries { + entries := a.AndroidApp.AndroidMkEntries() + entries.ExtraEntries = append(entries.ExtraEntries, func(entries *android.AndroidMkEntries) { + testSuiteComponent(entries, a.testProperties.Test_suites) if a.testConfig != nil { - fmt.Fprintln(w, "LOCAL_FULL_TEST_CONFIG :=", a.testConfig.String()) + entries.SetString("LOCAL_FULL_TEST_CONFIG", a.testConfig.String()) } - }) - androidMkWriteTestData(a.data, &data) - - return data -} - -func (a *AndroidTestHelperApp) AndroidMk() android.AndroidMkData { - data := a.AndroidApp.AndroidMk() - data.Extra = append(data.Extra, func(w io.Writer, outputFile android.Path) { - testSuiteComponent(w, a.appTestHelperAppProperties.Test_suites) + androidMkWriteTestData(a.data, entries) }) - return data + return entries } -func (a *AndroidLibrary) AndroidMk() android.AndroidMkData { - data := a.Library.AndroidMk() +func (a *AndroidTestHelperApp) AndroidMkEntries() android.AndroidMkEntries { + entries := a.AndroidApp.AndroidMkEntries() + entries.ExtraEntries = append(entries.ExtraEntries, func(entries *android.AndroidMkEntries) { + testSuiteComponent(entries, a.appTestHelperAppProperties.Test_suites) + }) - data.Extra = append(data.Extra, func(w io.Writer, outputFile android.Path) { + return entries +} + +func (a *AndroidLibrary) AndroidMkEntries() android.AndroidMkEntries { + entries := a.Library.AndroidMkEntries() + + entries.ExtraEntries = append(entries.ExtraEntries, func(entries *android.AndroidMkEntries) { if a.aarFile != nil { - fmt.Fprintln(w, "LOCAL_SOONG_AAR :=", a.aarFile.String()) + entries.SetString("LOCAL_SOONG_AAR", a.aarFile.String()) } if a.Name() == "framework-res" { - fmt.Fprintln(w, "LOCAL_MODULE_PATH := $(TARGET_OUT_JAVA_LIBRARIES)") + entries.SetString("LOCAL_MODULE_PATH", "$(TARGET_OUT_JAVA_LIBRARIES)") // Make base_rules.mk not put framework-res in a subdirectory called // framework_res. - fmt.Fprintln(w, "LOCAL_NO_STANDARD_LIBRARIES := true") + entries.SetBoolIfTrue("LOCAL_NO_STANDARD_LIBRARIES", true) } - fmt.Fprintln(w, "LOCAL_SOONG_RESOURCE_EXPORT_PACKAGE :=", a.exportPackage.String()) - fmt.Fprintln(w, "LOCAL_SOONG_STATIC_LIBRARY_EXTRA_PACKAGES :=", a.extraAaptPackagesFile.String()) - fmt.Fprintln(w, "LOCAL_FULL_MANIFEST_FILE :=", a.mergedManifestFile.String()) - fmt.Fprintln(w, "LOCAL_SOONG_EXPORT_PROGUARD_FLAGS :=", - strings.Join(a.exportedProguardFlagFiles.Strings(), " ")) - fmt.Fprintln(w, "LOCAL_UNINSTALLABLE_MODULE := true") + entries.SetString("LOCAL_SOONG_RESOURCE_EXPORT_PACKAGE", a.exportPackage.String()) + entries.SetString("LOCAL_SOONG_STATIC_LIBRARY_EXTRA_PACKAGES", a.extraAaptPackagesFile.String()) + entries.SetString("LOCAL_FULL_MANIFEST_FILE", a.mergedManifestFile.String()) + entries.AddStrings("LOCAL_SOONG_EXPORT_PROGUARD_FLAGS", a.exportedProguardFlagFiles.Strings()...) + entries.SetBoolIfTrue("LOCAL_UNINSTALLABLE_MODULE", true) }) - return data + return entries } func (jd *Javadoc) AndroidMk() android.AndroidMkData { @@ -644,25 +628,13 @@ func (a *AndroidAppImport) AndroidMkEntries() android.AndroidMkEntries { func (a *AndroidTestImport) AndroidMkEntries() android.AndroidMkEntries { entries := a.AndroidAppImport.AndroidMkEntries() entries.ExtraEntries = append(entries.ExtraEntries, func(entries *android.AndroidMkEntries) { - testSuiteComponentEntries(entries, a.testProperties.Test_suites) - androidMkEntriesWriteTestData(a.data, entries) + testSuiteComponent(entries, a.testProperties.Test_suites) + androidMkWriteTestData(a.data, entries) }) return entries } -func androidMkWriteTestData(data android.Paths, ret *android.AndroidMkData) { - var testFiles []string - for _, d := range data { - testFiles = append(testFiles, d.String()+":"+d.Rel()) - } - if len(testFiles) > 0 { - ret.Extra = append(ret.Extra, func(w io.Writer, outputFile android.Path) { - fmt.Fprintln(w, "LOCAL_COMPATIBILITY_SUPPORT_FILES := "+strings.Join(testFiles, " ")) - }) - } -} - -func androidMkEntriesWriteTestData(data android.Paths, entries *android.AndroidMkEntries) { +func androidMkWriteTestData(data android.Paths, entries *android.AndroidMkEntries) { var testFiles []string for _, d := range data { testFiles = append(testFiles, d.String()+":"+d.Rel()) diff --git a/java/androidmk_test.go b/java/androidmk_test.go index fbf2baa97..438b66a8a 100644 --- a/java/androidmk_test.go +++ b/java/androidmk_test.go @@ -15,107 +15,12 @@ package java import ( - "bytes" - "io" - "io/ioutil" - "strings" + "reflect" "testing" "android/soong/android" ) -type testAndroidMk struct { - *testing.T - body []byte -} - -type testAndroidMkModule struct { - *testing.T - props map[string]string -} - -func newTestAndroidMk(t *testing.T, r io.Reader) *testAndroidMk { - t.Helper() - buf, err := ioutil.ReadAll(r) - if err != nil { - t.Fatal("failed to open read Android.mk.", err) - } - return &testAndroidMk{ - T: t, - body: buf, - } -} - -func parseAndroidMkProps(lines []string) map[string]string { - props := make(map[string]string) - for _, line := range lines { - line = strings.TrimLeft(line, " ") - if line == "" || strings.HasPrefix(line, "#") { - continue - } - tokens := strings.Split(line, " ") - if tokens[1] == "+=" { - props[tokens[0]] += " " + strings.Join(tokens[2:], " ") - } else { - props[tokens[0]] = strings.Join(tokens[2:], " ") - } - } - return props -} - -func (t *testAndroidMk) moduleFor(moduleName string) *testAndroidMkModule { - t.Helper() - lines := strings.Split(string(t.body), "\n") - index := android.IndexList("LOCAL_MODULE := "+moduleName, lines) - if index == -1 { - t.Fatalf("%q is not found.", moduleName) - } - lines = lines[index:] - includeIndex := android.IndexListPred(func(line string) bool { - return strings.HasPrefix(line, "include") - }, lines) - if includeIndex == -1 { - t.Fatalf("%q is not properly defined. (\"include\" not found).", moduleName) - } - props := parseAndroidMkProps(lines[:includeIndex]) - return &testAndroidMkModule{ - T: t.T, - props: props, - } -} - -func (t *testAndroidMkModule) hasRequired(dep string) { - t.Helper() - required, ok := t.props["LOCAL_REQUIRED_MODULES"] - if !ok { - t.Error("LOCAL_REQUIRED_MODULES is not found.") - return - } - if !android.InList(dep, strings.Split(required, " ")) { - t.Errorf("%q is expected in LOCAL_REQUIRED_MODULES, but not found in %q.", dep, required) - } -} - -func (t *testAndroidMkModule) hasNoRequired(dep string) { - t.Helper() - required, ok := t.props["LOCAL_REQUIRED_MODULES"] - if !ok { - return - } - if android.InList(dep, strings.Split(required, " ")) { - t.Errorf("%q is not expected in LOCAL_REQUIRED_MODULES, but found.", dep) - } -} - -func getAndroidMk(t *testing.T, ctx *android.TestContext, config android.Config, name string) *testAndroidMk { - t.Helper() - lib, _ := ctx.ModuleForTests(name, "android_common").Module().(*Library) - data := android.AndroidMkDataForTest(t, config, "", lib) - w := &bytes.Buffer{} - data.Custom(w, name, "", "", data) - return newTestAndroidMk(t, w) -} - func TestRequired(t *testing.T) { ctx, config := testJava(t, ` java_library { @@ -125,8 +30,14 @@ func TestRequired(t *testing.T) { } `) - mk := getAndroidMk(t, ctx, config, "foo") - mk.moduleFor("foo").hasRequired("libfoo") + mod := ctx.ModuleForTests("foo", "android_common").Module() + entries := android.AndroidMkEntriesForTest(t, config, "", mod) + + expected := []string{"libfoo"} + actual := entries.EntryMap["LOCAL_REQUIRED_MODULES"] + if !reflect.DeepEqual(expected, actual) { + t.Errorf("Unexpected required modules - expected: %q, actual: %q", expected, actual) + } } func TestHostdex(t *testing.T) { @@ -138,9 +49,19 @@ func TestHostdex(t *testing.T) { } `) - mk := getAndroidMk(t, ctx, config, "foo") - mk.moduleFor("foo") - mk.moduleFor("foo-hostdex") + mod := ctx.ModuleForTests("foo", "android_common").Module() + entries := android.AndroidMkEntriesForTest(t, config, "", mod) + + expected := []string{"foo"} + actual := entries.EntryMap["LOCAL_MODULE"] + if !reflect.DeepEqual(expected, actual) { + t.Errorf("Unexpected module name - expected: %q, actual: %q", expected, actual) + } + + footerLines := entries.FooterLinesForTests() + if !android.InList("LOCAL_MODULE := foo-hostdex", footerLines) { + t.Errorf("foo-hostdex is not found in the footers: %q", footerLines) + } } func TestHostdexRequired(t *testing.T) { @@ -153,9 +74,19 @@ func TestHostdexRequired(t *testing.T) { } `) - mk := getAndroidMk(t, ctx, config, "foo") - mk.moduleFor("foo").hasRequired("libfoo") - mk.moduleFor("foo-hostdex").hasRequired("libfoo") + mod := ctx.ModuleForTests("foo", "android_common").Module() + entries := android.AndroidMkEntriesForTest(t, config, "", mod) + + expected := []string{"libfoo"} + actual := entries.EntryMap["LOCAL_REQUIRED_MODULES"] + if !reflect.DeepEqual(expected, actual) { + t.Errorf("Unexpected required modules - expected: %q, actual: %q", expected, actual) + } + + footerLines := entries.FooterLinesForTests() + if !android.InList("LOCAL_REQUIRED_MODULES := libfoo", footerLines) { + t.Errorf("Wrong or missing required line for foo-hostdex in the footers: %q", footerLines) + } } func TestHostdexSpecificRequired(t *testing.T) { @@ -172,7 +103,15 @@ func TestHostdexSpecificRequired(t *testing.T) { } `) - mk := getAndroidMk(t, ctx, config, "foo") - mk.moduleFor("foo").hasNoRequired("libfoo") - mk.moduleFor("foo-hostdex").hasRequired("libfoo") + mod := ctx.ModuleForTests("foo", "android_common").Module() + entries := android.AndroidMkEntriesForTest(t, config, "", mod) + + if r, ok := entries.EntryMap["LOCAL_REQUIRED_MODULES"]; ok { + t.Errorf("Unexpected required modules: %q", r) + } + + footerLines := entries.FooterLinesForTests() + if !android.InList("LOCAL_REQUIRED_MODULES += libfoo", footerLines) { + t.Errorf("Wrong or missing required line for foo-hostdex in the footers: %q", footerLines) + } } diff --git a/java/robolectric.go b/java/robolectric.go index 9669e1b38..dbf54c9b3 100644 --- a/java/robolectric.go +++ b/java/robolectric.go @@ -177,32 +177,32 @@ func (r *robolectricTest) generateRoboSrcJar(ctx android.ModuleContext, outputFi TransformResourcesToJar(ctx, outputFile, srcJarArgs, srcJarDeps) } -func (r *robolectricTest) AndroidMk() android.AndroidMkData { - data := r.Library.AndroidMk() +func (r *robolectricTest) AndroidMkEntries() android.AndroidMkEntries { + entries := r.Library.AndroidMkEntries() - data.Custom = func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) { - android.WriteAndroidMkData(w, data) + entries.ExtraFooters = []android.AndroidMkExtraFootersFunc{ + func(w io.Writer, name, prefix, moduleDir string, entries *android.AndroidMkEntries) { + if s := r.robolectricProperties.Test_options.Shards; s != nil && *s > 1 { + shards := shardTests(r.tests, int(*s)) + for i, shard := range shards { + r.writeTestRunner(w, name, "Run"+name+strconv.Itoa(i), shard) + } - if s := r.robolectricProperties.Test_options.Shards; s != nil && *s > 1 { - shards := shardTests(r.tests, int(*s)) - for i, shard := range shards { - r.writeTestRunner(w, name, "Run"+name+strconv.Itoa(i), shard) + // TODO: add rules to dist the outputs of the individual tests, or combine them together? + fmt.Fprintln(w, "") + fmt.Fprintln(w, ".PHONY:", "Run"+name) + fmt.Fprintln(w, "Run"+name, ": \\") + for i := range shards { + fmt.Fprintln(w, " ", "Run"+name+strconv.Itoa(i), "\\") + } + fmt.Fprintln(w, "") + } else { + r.writeTestRunner(w, name, "Run"+name, r.tests) } - - // TODO: add rules to dist the outputs of the individual tests, or combine them together? - fmt.Fprintln(w, "") - fmt.Fprintln(w, ".PHONY:", "Run"+name) - fmt.Fprintln(w, "Run"+name, ": \\") - for i := range shards { - fmt.Fprintln(w, " ", "Run"+name+strconv.Itoa(i), "\\") - } - fmt.Fprintln(w, "") - } else { - r.writeTestRunner(w, name, "Run"+name, r.tests) - } + }, } - return data + return entries } func (r *robolectricTest) writeTestRunner(w io.Writer, module, name string, tests []string) { diff --git a/java/sdk_library.go b/java/sdk_library.go index cc7256b1b..476e5491b 100644 --- a/java/sdk_library.go +++ b/java/sdk_library.go @@ -197,65 +197,65 @@ func (module *SdkLibrary) GenerateAndroidBuildActions(ctx android.ModuleContext) }) } -func (module *SdkLibrary) AndroidMk() android.AndroidMkData { - data := module.Library.AndroidMk() - data.Required = append(data.Required, module.xmlFileName()) +func (module *SdkLibrary) AndroidMkEntries() android.AndroidMkEntries { + entries := module.Library.AndroidMkEntries() + entries.Required = append(entries.Required, module.xmlFileName()) - data.Custom = func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) { - android.WriteAndroidMkData(w, data) - - module.Library.AndroidMkHostDex(w, name, data) - if !Bool(module.sdkLibraryProperties.No_dist) { - // Create a phony module that installs the impl library, for the case when this lib is - // in PRODUCT_PACKAGES. - owner := module.ModuleBase.Owner() - if owner == "" { - if Bool(module.sdkLibraryProperties.Core_lib) { - owner = "core" - } else { - owner = "android" + entries.ExtraFooters = []android.AndroidMkExtraFootersFunc{ + func(w io.Writer, name, prefix, moduleDir string, entries *android.AndroidMkEntries) { + module.Library.AndroidMkHostDex(w, name, entries) + if !Bool(module.sdkLibraryProperties.No_dist) { + // Create a phony module that installs the impl library, for the case when this lib is + // in PRODUCT_PACKAGES. + owner := module.ModuleBase.Owner() + if owner == "" { + if Bool(module.sdkLibraryProperties.Core_lib) { + owner = "core" + } else { + owner = "android" + } + } + // Create dist rules to install the stubs libs to the dist dir + if len(module.publicApiStubsPath) == 1 { + fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ + module.publicApiStubsImplPath.Strings()[0]+ + ":"+path.Join("apistubs", owner, "public", + module.BaseModuleName()+".jar")+")") + } + if len(module.systemApiStubsPath) == 1 { + fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ + module.systemApiStubsImplPath.Strings()[0]+ + ":"+path.Join("apistubs", owner, "system", + module.BaseModuleName()+".jar")+")") + } + if len(module.testApiStubsPath) == 1 { + fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ + module.testApiStubsImplPath.Strings()[0]+ + ":"+path.Join("apistubs", owner, "test", + module.BaseModuleName()+".jar")+")") + } + if module.publicApiFilePath != nil { + fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ + module.publicApiFilePath.String()+ + ":"+path.Join("apistubs", owner, "public", "api", + module.BaseModuleName()+".txt")+")") + } + if module.systemApiFilePath != nil { + fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ + module.systemApiFilePath.String()+ + ":"+path.Join("apistubs", owner, "system", "api", + module.BaseModuleName()+".txt")+")") + } + if module.testApiFilePath != nil { + fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ + module.testApiFilePath.String()+ + ":"+path.Join("apistubs", owner, "test", "api", + module.BaseModuleName()+".txt")+")") } } - // Create dist rules to install the stubs libs to the dist dir - if len(module.publicApiStubsPath) == 1 { - fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ - module.publicApiStubsImplPath.Strings()[0]+ - ":"+path.Join("apistubs", owner, "public", - module.BaseModuleName()+".jar")+")") - } - if len(module.systemApiStubsPath) == 1 { - fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ - module.systemApiStubsImplPath.Strings()[0]+ - ":"+path.Join("apistubs", owner, "system", - module.BaseModuleName()+".jar")+")") - } - if len(module.testApiStubsPath) == 1 { - fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ - module.testApiStubsImplPath.Strings()[0]+ - ":"+path.Join("apistubs", owner, "test", - module.BaseModuleName()+".jar")+")") - } - if module.publicApiFilePath != nil { - fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ - module.publicApiFilePath.String()+ - ":"+path.Join("apistubs", owner, "public", "api", - module.BaseModuleName()+".txt")+")") - } - if module.systemApiFilePath != nil { - fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ - module.systemApiFilePath.String()+ - ":"+path.Join("apistubs", owner, "system", "api", - module.BaseModuleName()+".txt")+")") - } - if module.testApiFilePath != nil { - fmt.Fprintln(w, "$(call dist-for-goals,sdk win_sdk,"+ - module.testApiFilePath.String()+ - ":"+path.Join("apistubs", owner, "test", "api", - module.BaseModuleName()+".txt")+")") - } - } + }, } - return data + return entries } // Module name of the stubs library