openkylin
/
platform_build_soong
mirror of https://gitee.com/openkylin/platform_build_soong.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Expand visiblity error 

Expands the error to suggest a potential fix, giving the package path
for the module that needs visiblity.

Test: go test soong tests
Bug: 168926331
Change-Id: Ie95dec03f5e2c3190bfaed1f0e5789eeb0ab1878
This commit is contained in:
Liz Kammer 2020-10-15 11:46:38 -07:00
parent faf30e19d6
commit e501bb4d48
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
android/visibility.go
View File

@ -443,7 +443,7 @@ func visibilityRuleEnforcer(ctx TopDownMutatorContext) {
rule := effectiveVisibilityRules(ctx.Config(), depQualified) rule := effectiveVisibilityRules(ctx.Config(), depQualified)
if !rule.matches(qualified) { if !rule.matches(qualified) {
ctx.ModuleErrorf("depends on %s which is not visible to this module", depQualified) ctx.ModuleErrorf("depends on %s which is not visible to this module\nYou may need to add %q to its visibility", depQualified, "//"+ctx.ModuleDir())
} }
}) })
} }

4
android/visibility_test.go
View File

@ -731,7 +731,7 @@ var visibilityTests = []struct {
}`), }`),
}, },
expectedErrors: []string{ expectedErrors: []string{
`module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module`, `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
}, },
}, },
{ {
@ -760,7 +760,7 @@ var visibilityTests = []struct {
}`), }`),
}, },
expectedErrors: []string{ expectedErrors: []string{
`module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module`, `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
}, },
}, },
{ {