Add logtags source file support

Add support for converting logtags files to source files.  Each
.logtags file is converted to a .java file, but only after all
.logtags files have been combined into a merged text file by
the logtagsSingleton.

Change-Id: I375d82874029bd26a7c528e46add2a638ba123f9
This commit is contained in:
Colin Cross 2015-04-10 17:45:20 -07:00
parent 6d1e72d7c6
commit f05fe97df6
3 changed files with 73 additions and 2 deletions

View File

@ -76,6 +76,7 @@ func main() {
// Singletons // Singletons
ctx.RegisterSingletonType("checkbuild", common.CheckbuildSingleton) ctx.RegisterSingletonType("checkbuild", common.CheckbuildSingleton)
ctx.RegisterSingletonType("env", common.EnvSingleton) ctx.RegisterSingletonType("env", common.EnvSingleton)
ctx.RegisterSingletonType("logtags", java.LogtagsSingleton)
configuration, err := common.NewConfig(srcDir) configuration, err := common.NewConfig(srcDir)
if err != nil { if err != nil {

View File

@ -32,7 +32,13 @@ func init() {
pctx.VariableFunc("aidlCmd", func(c interface{}) (string, error) { pctx.VariableFunc("aidlCmd", func(c interface{}) (string, error) {
return c.(common.Config).HostBinTool("aidl") return c.(common.Config).HostBinTool("aidl")
}) })
pctx.StaticVariable("logtagsCmd", "${srcDir}/build/tools/java-event-log-tags.py")
pctx.StaticVariable("mergeLogtagsCmd", "${srcDir}/build/tools/merge-event-log-tags.py")
pctx.VariableConfigMethod("srcDir", common.Config.SrcDir) pctx.VariableConfigMethod("srcDir", common.Config.SrcDir)
pctx.VariableFunc("allLogtagsFile", func(c interface{}) (string, error) {
return filepath.Join(c.(common.Config).IntermediatesDir(), "all-event-log-tags.txt"), nil
})
} }
var ( var (
@ -42,6 +48,18 @@ var (
Description: "aidl $out", Description: "aidl $out",
}, },
"depFile", "aidlFlags") "depFile", "aidlFlags")
logtags = pctx.StaticRule("logtags",
blueprint.RuleParams{
Command: "$logtagsCmd -o $out $in $allLogtagsFile",
Description: "logtags $out",
})
mergeLogtags = pctx.StaticRule("mergeLogtags",
blueprint.RuleParams{
Command: "$mergeLogtagsCmd -o $out $in",
Description: "merge logtags $out",
})
) )
func genAidl(ctx common.AndroidModuleContext, aidlFile, aidlFlags string) string { func genAidl(ctx common.AndroidModuleContext, aidlFile, aidlFlags string) string {
@ -64,7 +82,22 @@ func genAidl(ctx common.AndroidModuleContext, aidlFile, aidlFlags string) string
return javaFile return javaFile
} }
func genSources(ctx common.AndroidModuleContext, srcFiles []string, func genLogtags(ctx common.AndroidModuleContext, logtagsFile string) string {
javaFile := strings.TrimPrefix(logtagsFile, common.ModuleSrcDir(ctx))
javaFile = filepath.Join(common.ModuleGenDir(ctx), javaFile)
javaFile = pathtools.ReplaceExtension(javaFile, "java")
ctx.Build(pctx, blueprint.BuildParams{
Rule: logtags,
Outputs: []string{javaFile},
Inputs: []string{logtagsFile},
Implicits: []string{"$logtagsCmd"},
})
return javaFile
}
func (j *javaBase) genSources(ctx common.AndroidModuleContext, srcFiles []string,
flags javaBuilderFlags) []string { flags javaBuilderFlags) []string {
for i, srcFile := range srcFiles { for i, srcFile := range srcFiles {
@ -72,8 +105,37 @@ func genSources(ctx common.AndroidModuleContext, srcFiles []string,
case ".aidl": case ".aidl":
javaFile := genAidl(ctx, srcFile, flags.aidlFlags) javaFile := genAidl(ctx, srcFile, flags.aidlFlags)
srcFiles[i] = javaFile srcFiles[i] = javaFile
case ".logtags":
j.logtagsSrcs = append(j.logtagsSrcs, srcFile)
javaFile := genLogtags(ctx, srcFile)
srcFiles[i] = javaFile
} }
} }
return srcFiles return srcFiles
} }
func LogtagsSingleton() blueprint.Singleton {
return &logtagsSingleton{}
}
type logtagsProducer interface {
logtags() []string
}
type logtagsSingleton struct{}
func (l *logtagsSingleton) GenerateBuildActions(ctx blueprint.SingletonContext) {
var allLogtags []string
ctx.VisitAllModules(func(module blueprint.Module) {
if logtags, ok := module.(logtagsProducer); ok {
allLogtags = append(allLogtags, logtags.logtags()...)
}
})
ctx.Build(pctx, blueprint.BuildParams{
Rule: mergeLogtags,
Outputs: []string{"$allLogtagsFile"},
Inputs: allLogtags,
})
}

View File

@ -106,6 +106,8 @@ type javaBase struct {
exportAidlIncludeDirs []string exportAidlIncludeDirs []string
logtagsSrcs []string
// installed file for binary dependency // installed file for binary dependency
installFile string installFile string
} }
@ -255,7 +257,7 @@ func (j *javaBase) GenerateJavaBuildActions(ctx common.AndroidModuleContext) {
srcFiles := common.ExpandSources(ctx, j.properties.Srcs) srcFiles := common.ExpandSources(ctx, j.properties.Srcs)
srcFiles = genSources(ctx, srcFiles, flags) srcFiles = j.genSources(ctx, srcFiles, flags)
if len(srcFiles) > 0 { if len(srcFiles) > 0 {
// Compile java sources into .class files // Compile java sources into .class files
@ -360,6 +362,12 @@ func (j *javaBase) AidlPreprocessed() string {
return "" return ""
} }
var _ logtagsProducer = (*javaBase)(nil)
func (j *javaBase) logtags() []string {
return j.logtagsSrcs
}
// //
// Java libraries (.jar file) // Java libraries (.jar file)
// //