openkylin
/
platform_build_soong
mirror of https://gitee.com/openkylin/platform_build_soong.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Convert android/module_test.go to test fixtures 

Replaces the uses of buildDir in the unit test methods with t.TempDir()
as it just needs a temporary directory.

Bug: 182885307
Test: m nothing
Change-Id: I70452d548eff53c0bccada09f60eba7a615b5371
This commit is contained in:
Paul Duffin 2021-03-16 19:44:51 +00:00
parent 7c166b4529
commit f62dc9b7a8
1 changed files with 17 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
android/module_test.go
View File

@ -163,6 +163,10 @@ func depsModuleFactory() Module {
return m
}
var prepareForModuleTests = FixtureRegisterWithContext(func(ctx RegistrationContext) {
ctx.RegisterModuleType("deps", depsModuleFactory)
})
func TestErrorDependsOnDisabledModule(t *testing.T) {
bp := `
deps {
@ -175,20 +179,15 @@ func TestErrorDependsOnDisabledModule(t *testing.T) {
}
`
config := TestConfig(buildDir, nil, bp, nil)
ctx := NewTestContext(config)
ctx.RegisterModuleType("deps", depsModuleFactory)
ctx.Register()
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
FailIfErrored(t, errs)
_, errs = ctx.PrepareBuildActions(config)
FailIfNoMatchingErrors(t, `module "foo": depends on disabled module "bar"`, errs)
emptyTestFixtureFactory.
ExtendWithErrorHandler(FixtureExpectsAtLeastOneErrorMatchingPattern(`module "foo": depends on disabled module "bar"`)).
RunTest(t,
prepareForModuleTests,
FixtureWithRootAndroidBp(bp))
}
func TestValidateCorrectBuildParams(t *testing.T) {
config := TestConfig(buildDir, nil, "", nil)
config := TestConfig(t.TempDir(), nil, "", nil)
pathContext := PathContextForTesting(config)
bparams := convertBuildParams(BuildParams{
// Test with Output
@ -214,7 +213,7 @@ func TestValidateCorrectBuildParams(t *testing.T) {
}
func TestValidateIncorrectBuildParams(t *testing.T) {
config := TestConfig(buildDir, nil, "", nil)
config := TestConfig(t.TempDir(), nil, "", nil)
pathContext := PathContextForTesting(config)
params := BuildParams{
Output: PathForOutput(pathContext, "regular_output"),
@ -257,16 +256,6 @@ func TestDistErrorChecking(t *testing.T) {
}
`
config := TestConfig(buildDir, nil, bp, nil)
ctx := NewTestContext(config)
ctx.RegisterModuleType("deps", depsModuleFactory)
ctx.Register()
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
FailIfErrored(t, errs)
_, errs = ctx.PrepareBuildActions(config)
expectedErrs := []string{
"\\QAndroid.bp:5:13: module \"foo\": dist.dest: Path is outside directory: ../invalid-dest\\E",
"\\QAndroid.bp:6:12: module \"foo\": dist.dir: Path is outside directory: ../invalid-dir\\E",
@ -278,5 +267,10 @@ func TestDistErrorChecking(t *testing.T) {
"\\QAndroid.bp:17:14: module \"foo\": dists[1].dir: Path is outside directory: ../invalid-dir1\\E",
"\\QAndroid.bp:18:17: module \"foo\": dists[1].suffix: Suffix may not contain a '/' character.\\E",
}
CheckErrorsAgainstExpectations(t, errs, expectedErrs)
emptyTestFixtureFactory.
ExtendWithErrorHandler(FixtureExpectsAllErrorsToMatchAPattern(expectedErrs)).
RunTest(t,
prepareForModuleTests,
FixtureWithRootAndroidBp(bp))
}