From ff0278b32a0c0c7799960b08952a8f2b4f0b8c09 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Fri, 9 Oct 2020 19:24:15 -0700 Subject: [PATCH] Fix go vet error stderr is a bytes.Buffer, but the String() method has a pointer receiver, so stderr does not satisify the Stringer interface and can't be used for a %s argument. Make stderr a *bytes.Buffer instead. Test: go vet ./android Change-Id: I994402cb954946279375c9d447ad3854380381cc --- android/bazel_handler.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/bazel_handler.go b/android/bazel_handler.go index d4f6e4c9e..b7cea4be7 100644 --- a/android/bazel_handler.go +++ b/android/bazel_handler.go @@ -188,8 +188,8 @@ func (context *bazelContext) issueBazelCommand(command string, labels []string, bazelCmd.Dir = context.workspaceDir bazelCmd.Env = append(os.Environ(), "HOME="+context.homeDir, pwdPrefix()) - var stderr bytes.Buffer - bazelCmd.Stderr = &stderr + stderr := &bytes.Buffer{} + bazelCmd.Stderr = stderr if output, err := bazelCmd.Output(); err != nil { return "", fmt.Errorf("bazel command failed. command: [%s], error [%s]", bazelCmd, stderr)