Commit Graph

32193 Commits

Author SHA1 Message Date
Chris Parsons 3c27ca3683 Improve comments in cc/library.go and cc/linkable.go.
Test: N/A
Change-Id: I10cca7942bf86be8c933fd924f4bb7bdaff0cef7
2020-12-02 11:03:18 -05:00
Christopher Parsons 753108d04d Merge "Improve commenting for cc/builer.go, and kill dead code" am: b9e93f8789
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1508580

Change-Id: Ifc76fabda5c79d83f4050f622035096e76083e09
2020-12-02 16:02:44 +00:00
Christopher Parsons b9e93f8789 Merge "Improve commenting for cc/builer.go, and kill dead code" 2020-12-02 15:59:55 +00:00
Jaewoong Jung 446c6953d7 Merge "Improve comments in java/aapt2.go" am: 6a96b82937
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1507120

Change-Id: I957aa33a46971045ddf5f48ad7d833fe9ff7aff6
2020-12-02 15:49:41 +00:00
Jaewoong Jung 78c0b0e1e2 Merge "Bolster comments in android/androidmk.go." am: 2b2bc8c712
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1500971

Change-Id: Ibdd78b07de14aeeae00817c7b18a6afd2b18282e
2020-12-02 15:49:02 +00:00
Jaewoong Jung 6a96b82937 Merge "Improve comments in java/aapt2.go" 2020-12-02 15:19:56 +00:00
Jaewoong Jung 2b2bc8c712 Merge "Bolster comments in android/androidmk.go." 2020-12-02 15:16:27 +00:00
Hans Månsson d3f2bd79e8 WriteFileRule: Chunk long content and merge them to result
sbox.textproto files are created when handling genrule. The command
for the genrule and output files are written to this file in the
following format:

commands <
  command: "...."
  copy_after: <
    from: "out/asm-generic/auxvec.h"
    to: "out/soong/.intermediates/kernel/msm-4.19/qti_generate_kernel_headers_arm/gen/asm-generic/auxvec.h"
  >
  copy_after: <
    from: "out/asm-generic/bitsperlong.h"
     to:
     "out/soong/.intermediates/kernel/msm-4.19/qti_generate_kernel_headers_arm/gen/asm-generic/bitsperlong.h"
  >
  ....
>

This file grow by one copy_after entry for each output file.

When generating kenrnel headers where the number of output files are
~1000 we run into problems as the contents of sbox.textproto files
are written to disk by generating a shell script using the following
template: /bin/bash -c 'echo -e "$$0" > $out' $content
If $content is very long as in the case of generating kernel headers we
run into the issue where the command line is so long that the shell
script return E2BIG.

Fix this issue by chuking contents into smaller files and then merge
them as a final step.

Test: Build
Issue: 174444967
Change-Id: I1a74023b4222d19672e4df7edb19810a9cf2136f
2020-12-02 15:58:48 +01:00
Cindy Zhou 31018d8e48 Merge "Add arch_variant support for diag" am: 591833471f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1515401

Change-Id: Ib14434ccedf9ace4c7fc41f1444a0702cd754b17
2020-12-02 13:42:01 +00:00
Treehugger Robot db4e388423 Merge "Fix the instructions for regenerating .txt" am: b28bd8cd66
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1513924

Change-Id: Ic611aa527eb67f379964df5b28362b525b3b9454
2020-12-02 13:41:54 +00:00
Anton Hansson 3fdcba57df Add support for skipping just kati am: 5e5c48b2b5
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1512613

Change-Id: Id47bcebd71e4ec31f5359819b7228924007ea821
2020-12-02 13:41:12 +00:00
Ulya Trafimovich 78210f6c9b Make error message more precise.
Bug: 132357300
Test: m nothing
Change-Id: Iaac6aaf61a3bbf8476f0b11cf2c01d7d96a79920
2020-12-02 13:06:47 +00:00
Cindy Zhou 591833471f Merge "Add arch_variant support for diag" 2020-12-02 13:01:43 +00:00
Treehugger Robot b28bd8cd66 Merge "Fix the instructions for regenerating .txt" 2020-12-02 13:01:37 +00:00
Anton Hansson 5e5c48b2b5 Add support for skipping just kati
The existing --skip-make flag disables both the config step and the kati
step in the build. Add support for a --skip-kati flag that skips just
the kati step, and refactor things so that the logic is shared between
these two.

Bug: 174315599
Test: TARGET_PRODUCT=aosp_arm64 soong_ui --make-mode --skip-kati;
      (verify soong.variables is regenerated)
Change-Id: I75b1910fc1c12fcda130e37b7bc4c050131c7b33
2020-12-02 10:39:50 +00:00
Treehugger Robot 3d3b6e7dcb Merge "Minor cleanup of soong.go." am: d74b9c5728
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1511168

Change-Id: Ide4941f26368d1a05c768b94db9286019d841251
2020-12-02 08:56:58 +00:00
Treehugger Robot d74b9c5728 Merge "Minor cleanup of soong.go." 2020-12-02 08:21:59 +00:00
JaeMan Park c11aa53de1 Merge "Add java sdk library enforcement flag" am: a4d314c91c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1475897

Change-Id: Ifb19d9aaa6f1a8b1005eb1f4b45cd6398335d041
2020-12-02 05:22:24 +00:00
JaeMan Park a4d314c91c Merge "Add java sdk library enforcement flag" 2020-12-02 04:39:10 +00:00
Treehugger Robot 9152b273b1 Merge "Minor cleanup of build.go." am: d8c099e12d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1509812

Change-Id: Ia289e0dbbcb39b8e523462804db666c2d78737e5
2020-12-02 03:38:24 +00:00
Kiyoung Kim 4098c7eddf Add linkerconfig to Runtime APEX
Add linkerconfig to Runtime APEX module.

Bug: 165769179
Test: Cuttlefish boot succeeded
Change-Id: I31c4bfa2ce88b64d7100f227ec289416db253b13
2020-12-02 11:33:54 +09:00
Treehugger Robot d8c099e12d Merge "Minor cleanup of build.go." 2020-12-02 02:29:08 +00:00
Jiyong Park 0c5b6caa37 Merge "Remove the arch-based filtering hack in packaging.go" am: f10995b7b6
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1509692

Change-Id: Ic73ff639f06086f70e6949fa65d3fcddb8709fbf
2020-12-02 01:47:47 +00:00
Kiyoung Kim 2edef37163 Merge "Generate system stub library list at build time" am: e76ec1cbeb
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1498485

Change-Id: Id3be94b17dc74f824957c178f8e3cea6968ff594
2020-12-02 01:47:40 +00:00
Jiyong Park d5cea654ff Merge "android_filesystem is installable" am: 33e1763094
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1509548

Change-Id: Iae503d7fc760c323e6d91f2eb02f6774710e1378
2020-12-02 01:46:35 +00:00
Jiyong Park f10995b7b6 Merge "Remove the arch-based filtering hack in packaging.go" 2020-12-02 01:24:17 +00:00
Rupert Shuttleworth b7d971012a Minor cleanup of soong.go.
Test: TH presubmit.
Change-Id: Ic5b263aa1320d9f70a6749ed12cbdc477acd3067
2020-12-02 00:56:35 +00:00
Rupert Shuttleworth eeb5caac78 Minor cleanup of build.go.
Test: TH presubmit.
Change-Id: I3a41130b25d39276162850e417f036f9ce6a2ec0
2020-12-02 00:49:03 +00:00
Kiyoung Kim e76ec1cbeb Merge "Generate system stub library list at build time" 2020-12-02 00:28:19 +00:00
Colin Cross f1a035e6be Pass pctx and ctx to NewRuleBuilder
Enable the RuleBuilder and RuleBuilderCommand methods to access
the BuilderContext by passing it to NewRuleBuilder instead of
RuleBuilder.Build.

Test: genrule_test.go
Test: rule_builder_test.go
Test: m checkbuild
Change-Id: I63e6597e19167393876dc2259d6f521363b7dabc
2020-12-01 16:22:16 -08:00
Jiyong Park 33e1763094 Merge "android_filesystem is installable" 2020-12-01 23:36:28 +00:00
Chris Parsons bf4f55f180 Improve commenting for cc/builer.go, and kill dead code
Test: m nothing
Change-Id: I836c717d3243e901257120be71246e419de4d28e
2020-12-01 18:28:38 -05:00
Treehugger Robot 5ac52e71e5 Merge "Add test suite handling to central androidmk code" am: 464e6c71df
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1513215

Change-Id: Ic663483b0a799793e7eac61f796af3c99a204954
2020-12-01 22:37:46 +00:00
Treehugger Robot 464e6c71df Merge "Add test suite handling to central androidmk code" 2020-12-01 22:19:26 +00:00
Liz Kammer d737d02f16 Add comments/refactor for python.go
Test: all soong tests
Test: m nothing
Change-Id: Ib3b95d7c2831b97026e76a39af515fd51c6cb2c7
2020-12-01 13:18:47 -08:00
Neil Fuller 96d016137f Fix the instructions for regenerating .txt
"make" hasn't worked for a while.

Test: None
Change-Id: Ic1319d32d4cc1b0930829fa6ed4d8d3f31deb351
2020-12-01 21:18:13 +00:00
Liz Kammer 57f5b33ad3 Add test suite handling to central androidmk code
MTS is introducing partial MTS test suites that are per-module, with
names of the format: mts-${MODULE}. By centralizing the code for test
suites, we can automatically add "mts" test suite when an
"mts-${MODULE}" test suite is specified, reducing duplication.

Test: m mts
Bug: 170318013
Change-Id: I8ce9d3c252fcc0a937bb5f2826d21cb6c6932d82
2020-12-01 12:23:56 -08:00
Cindy Zhou d3fe49289d Add arch_variant support for diag
Allow for different arch to specify sanitizer options.

Bug: 158010610
Test: Compiles with build options
Change-Id: I4db72f682e920e3c1a6d55473f316e56567636e6
2020-12-01 11:26:39 -08:00
Jiyong Park 65c49f5979 android_filesystem is installable
Also document about the android_filesystem module type.

Bug: 172414391
Test: m
Change-Id: Iae07af9dd22f34c8e0e4c833333bafdf82dcab2a
2020-12-01 23:47:39 +09:00
Treehugger Robot 2923649606 Merge "Document more functions, minor cleanup" am: 882c042575
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1506452

Change-Id: I27d8481ef947e918fdb03ec6add04d7f1daa451f
2020-12-01 14:35:25 +00:00
Jaewoong Jung 7ef4a900f4 Bolster comments in android/androidmk.go.
Bug: 173398138
Test: N/A
Change-Id: I46048b8398356d658fd5ae0299b59e6e18429198
2020-12-01 06:15:14 -08:00
Treehugger Robot 882c042575 Merge "Document more functions, minor cleanup" 2020-12-01 14:07:35 +00:00
Ivan Lozano 259a07f0d1 Merge "rust: Add support for multiple protos per module." am: 9c3f653207
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1503832

Change-Id: Id97e7b1a7270b992c988cabefe8d6159d133f806
2020-12-01 13:25:51 +00:00
Ivan Lozano 9c3f653207 Merge "rust: Add support for multiple protos per module." 2020-12-01 13:11:57 +00:00
Jiyong Park d630bdd4dd Remove the arch-based filtering hack in packaging.go
aosp/1501613 has landed. The filtering hack is no longer needed.

Also, fixed a bug that the dependency to the dynamic linker is not
treated as install dep.

Bug: N/A
Test: `m hosttar` and compare the built cvd-host_package.tar.gz with and
without this change. There is no removed file.

Change-Id: I19ef64e10d34bc8be2592c5258505cd632c91af9
2020-12-01 19:25:39 +09:00
Ulyana Trafimovich e5b0fb9ee4 Merge changes from topic "soong-fixit-skavdrik" am: 0d18ef42ec
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1507578

Change-Id: Id8ad46f99181aa7ca41fee9cbf8402ff2a2a5483
2020-12-01 10:24:19 +00:00
Ulyana Trafimovich 0d18ef42ec Merge changes from topic "soong-fixit-skavdrik"
* changes:
  Documenting java/dexpreopt_bootjars.go
  Documenting dexpreopt/class_loader_context.go.
2020-12-01 10:01:43 +00:00
Jiyong Park 31fc18441b Reformat comments in packaging.go am: cc1157cd49
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1509691

Change-Id: I25f06182273ed50ad3e610dfe80c37d84b92ee78
2020-12-01 05:51:09 +00:00
Jiyong Park cc1157cd49 Reformat comments in packaging.go
set textwidth=100

Bug: N/A
Test: N/A

Change-Id: I2fb315c9488010d189b7757a4d93be181672b4a6
2020-12-01 05:27:48 +00:00
Kiyoung Kim 24dfc1fbb2 Generate system stub library list at build time
List of stub libraries from system (and bionic APEX) is currently
managed in static file. This change generates the list at build time and
adds to the system config so linkerconfig can use it.

Bug: 172889962
Test: Build cuttlefish and confirmed list is generated in
/system/etc/linker.config.pb

Change-Id: Ie0400e9d1098b0de19c6a7c25f261384aadde0a3
2020-12-01 14:09:03 +09:00