platform_build_soong/apex
Paul Duffin 6d119b804c Fix mutator ordering issue in apex tests
Previously, the override mutators were being run before the prebuilt
mutators that did not match the runtime behavior. This change fixes
that ordering.

In the process it broke TestApexWithAppImportsPrefer. That test tries
to verify that an apex that depends on an android_app will use an
android_app_import if that is preferred. Unfortunately, it only worked
because of the incorrect order of the mutators.

The test worked before this change because the prebuilt mutators were
being run after the overridableModuleDepsMutator. That meant that any
dependencies added by that mutator onto source modules could be
replaced by the PrebuiltPostDepsMutator with the preferred prebuilt
module.

Switching the order to match the runtime meant that the prebuilt
mutators were run before the overrides so never had a chance to replace
the dependencies added by the overrides.

Bug: 181953909
Bug: 181974714
Test: m nothing
Change-Id: Ic98fdc29a63155174a3227e7e918b26f0a8763bb
2021-03-05 18:38:58 +00:00
..
Android.bp Add LOCAL_LICENSE_KINDS to build/soong 2021-02-06 04:23:21 +00:00
OWNERS Remove myself from the OWNERS 2021-03-03 08:21:17 -08:00
TEST_MAPPING Add TEST_MAPPING for build/soong/apex 2019-08-07 17:33:24 +09:00
allowed_deps.txt Merge RQ2A.210305.007 2021-03-03 09:12:01 -08:00
androidmk.go Merge "Revert "Revert "Automated NDK API coverage used by Mainline modules build integration.""" 2021-01-26 00:13:46 +00:00
apex.go Merge "Friendly error message on apex_available and min_sdk_version checks" 2021-03-05 03:30:11 +00:00
apex_singleton.go Add PHONY for apex-allowed-deps check. 2020-11-04 20:50:03 +00:00
apex_test.go Fix mutator ordering issue in apex tests 2021-03-05 18:38:58 +00:00
boot_image_test.go Make apex.updatable default to true. 2021-03-03 10:28:26 +00:00
builder.go Pass list of module libraries to gen_ndk_backed_by_apex.sh 2021-02-08 16:52:07 -08:00
deapexer.go Remove deapexer and prebuilt apex select mutators 2021-03-01 17:11:25 +00:00
key.go Remove unnecessary snake case variables. 2020-12-22 12:38:35 -08:00
prebuilt.go Remove deapexer and prebuilt apex select mutators 2021-03-01 17:11:25 +00:00
vndk.go Remove global state from VNDK apexes 2021-03-02 12:23:16 -08:00
vndk_test.go Make apex.updatable default to true. 2021-03-03 10:28:26 +00:00