openkylin
/
platform_kernel-5.15
mirror of https://gitee.com/openkylin/platform_kernel-5.15.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Wrong page freed on preallocate_pmds() failure exit 

Note that pmds[i] is simply uninitialized at that point...

Granted, it's very hard to hit (you need split page locks *and*
kmalloc(sizeof(spinlock_t), GFP_KERNEL) failing), but the code is
obviously bogus.

Introduced by commit 09ef493985 ("x86: add missed
pgtable_pmd_page_ctor/dtor calls for preallocated pmds")

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Al Viro 2013-11-20 22:16:36 +00:00 committed by Linus Torvalds
parent 82023bb7f7
commit 2a46eed54a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/x86/mm/pgtable.c
View File

@ -209,7 +209,7 @@ static int preallocate_pmds(pmd_t *pmds[])
if (!pmd) if (!pmd)
failed = true; failed = true;
if (pmd && !pgtable_pmd_page_ctor(virt_to_page(pmd))) { if (pmd && !pgtable_pmd_page_ctor(virt_to_page(pmd))) {
free_page((unsigned long)pmds[i]); free_page((unsigned long)pmd);
pmd = NULL; pmd = NULL;
failed = true; failed = true;
} }