openkylin
/
platform_kernel-5.15
mirror of https://gitee.com/openkylin/platform_kernel-5.15.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: rtm_to_ifaddr: free ifa if ifa_cacheinfo processing fails 

Commit 5c766d642 ("ipv4: introduce address lifetime") leaves the ifa
resource that was allocated via inet_alloc_ifa() unfreed when returning
the function with -EINVAL. Thus, free it first via inet_free_ifa().

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Daniel Borkmann 2013-08-02 11:32:43 +02:00 committed by David S. Miller
parent 9bb8eeb554
commit 446266b0c7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/ipv4/devinet.c
View File

@ -772,7 +772,7 @@ static struct in_ifaddr *rtm_to_ifaddr(struct net *net, struct nlmsghdr *nlh,
ci = nla_data(tb[IFA_CACHEINFO]); ci = nla_data(tb[IFA_CACHEINFO]);
if (!ci->ifa_valid || ci->ifa_prefered > ci->ifa_valid) { if (!ci->ifa_valid || ci->ifa_prefered > ci->ifa_valid) {
err = -EINVAL; err = -EINVAL;
goto errout; goto errout_free;
} }
*pvalid_lft = ci->ifa_valid; *pvalid_lft = ci->ifa_valid;
*pprefered_lft = ci->ifa_prefered; *pprefered_lft = ci->ifa_prefered;
@ -780,6 +780,8 @@ static struct in_ifaddr *rtm_to_ifaddr(struct net *net, struct nlmsghdr *nlh,
return ifa; return ifa;
errout_free:
inet_free_ifa(ifa);
errout: errout:
return ERR_PTR(err); return ERR_PTR(err);
} }