can: dev: sort can_changelink() by IFLA_CAN_*
This patch sorts the handling of data[IFLA_CAN_*] by IFLA_CAN_*. Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
parent
57a59b9ef5
commit
49cb5c0e0c
|
@ -645,19 +645,6 @@ static int can_changelink(struct net_device *dev,
|
||||||
/* We need synchronization with dev->stop() */
|
/* We need synchronization with dev->stop() */
|
||||||
ASSERT_RTNL();
|
ASSERT_RTNL();
|
||||||
|
|
||||||
if (data[IFLA_CAN_CTRLMODE]) {
|
|
||||||
struct can_ctrlmode *cm;
|
|
||||||
|
|
||||||
/* Do not allow changing controller mode while running */
|
|
||||||
if (dev->flags & IFF_UP)
|
|
||||||
return -EBUSY;
|
|
||||||
cm = nla_data(data[IFLA_CAN_CTRLMODE]);
|
|
||||||
if (cm->flags & ~priv->ctrlmode_supported)
|
|
||||||
return -EOPNOTSUPP;
|
|
||||||
priv->ctrlmode &= ~cm->mask;
|
|
||||||
priv->ctrlmode |= cm->flags;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (data[IFLA_CAN_BITTIMING]) {
|
if (data[IFLA_CAN_BITTIMING]) {
|
||||||
struct can_bittiming bt;
|
struct can_bittiming bt;
|
||||||
|
|
||||||
|
@ -680,6 +667,19 @@ static int can_changelink(struct net_device *dev,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (data[IFLA_CAN_CTRLMODE]) {
|
||||||
|
struct can_ctrlmode *cm;
|
||||||
|
|
||||||
|
/* Do not allow changing controller mode while running */
|
||||||
|
if (dev->flags & IFF_UP)
|
||||||
|
return -EBUSY;
|
||||||
|
cm = nla_data(data[IFLA_CAN_CTRLMODE]);
|
||||||
|
if (cm->flags & ~priv->ctrlmode_supported)
|
||||||
|
return -EOPNOTSUPP;
|
||||||
|
priv->ctrlmode &= ~cm->mask;
|
||||||
|
priv->ctrlmode |= cm->flags;
|
||||||
|
}
|
||||||
|
|
||||||
if (data[IFLA_CAN_RESTART_MS]) {
|
if (data[IFLA_CAN_RESTART_MS]) {
|
||||||
/* Do not allow changing restart delay while running */
|
/* Do not allow changing restart delay while running */
|
||||||
if (dev->flags & IFF_UP)
|
if (dev->flags & IFF_UP)
|
||||||
|
|
Loading…
Reference in New Issue