sctp: pass a kernel pointer to sctp_setsockopt_add_streams
Use the kernel pointer that sctp_setsockopt has available instead of directly handling the user pointer. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
b97d20ce53
commit
4d6fb26062
|
@ -4099,29 +4099,19 @@ static int sctp_setsockopt_reset_assoc(struct sock *sk, sctp_assoc_t *associd,
|
|||
}
|
||||
|
||||
static int sctp_setsockopt_add_streams(struct sock *sk,
|
||||
char __user *optval,
|
||||
struct sctp_add_streams *params,
|
||||
unsigned int optlen)
|
||||
{
|
||||
struct sctp_association *asoc;
|
||||
struct sctp_add_streams params;
|
||||
int retval = -EINVAL;
|
||||
|
||||
if (optlen != sizeof(params))
|
||||
goto out;
|
||||
if (optlen != sizeof(*params))
|
||||
return -EINVAL;
|
||||
|
||||
if (copy_from_user(¶ms, optval, optlen)) {
|
||||
retval = -EFAULT;
|
||||
goto out;
|
||||
}
|
||||
|
||||
asoc = sctp_id2assoc(sk, params.sas_assoc_id);
|
||||
asoc = sctp_id2assoc(sk, params->sas_assoc_id);
|
||||
if (!asoc)
|
||||
goto out;
|
||||
return -EINVAL;
|
||||
|
||||
retval = sctp_send_add_streams(asoc, ¶ms);
|
||||
|
||||
out:
|
||||
return retval;
|
||||
return sctp_send_add_streams(asoc, params);
|
||||
}
|
||||
|
||||
static int sctp_setsockopt_scheduler(struct sock *sk,
|
||||
|
@ -4667,7 +4657,7 @@ static int sctp_setsockopt(struct sock *sk, int level, int optname,
|
|||
retval = sctp_setsockopt_reset_assoc(sk, kopt, optlen);
|
||||
break;
|
||||
case SCTP_ADD_STREAMS:
|
||||
retval = sctp_setsockopt_add_streams(sk, optval, optlen);
|
||||
retval = sctp_setsockopt_add_streams(sk, kopt, optlen);
|
||||
break;
|
||||
case SCTP_STREAM_SCHEDULER:
|
||||
retval = sctp_setsockopt_scheduler(sk, optval, optlen);
|
||||
|
|
Loading…
Reference in New Issue