Merge branch 'pci/hotplug'
- Fix ibmphp double unmap of io_mem (Vishal Aslot) * pci/hotplug: PCI: ibmphp: Fix double unmap of io_mem
This commit is contained in:
commit
4f6f0b86d3
|
@ -40,9 +40,6 @@ ibmphp:
|
|||
|
||||
* The return value of pci_hp_register() is not checked.
|
||||
|
||||
* iounmap(io_mem) is called in the error path of ebda_rsrc_controller()
|
||||
and once more in the error path of its caller ibmphp_access_ebda().
|
||||
|
||||
* The various slot data structures are difficult to follow and need to be
|
||||
simplified. A lot of functions are too large and too complex, they need
|
||||
to be broken up into smaller, manageable pieces. Negative examples are
|
||||
|
|
|
@ -714,8 +714,7 @@ static int __init ebda_rsrc_controller(void)
|
|||
/* init hpc structure */
|
||||
hpc_ptr = alloc_ebda_hpc(slot_num, bus_num);
|
||||
if (!hpc_ptr) {
|
||||
rc = -ENOMEM;
|
||||
goto error_no_hpc;
|
||||
return -ENOMEM;
|
||||
}
|
||||
hpc_ptr->ctlr_id = ctlr_id;
|
||||
hpc_ptr->ctlr_relative_id = ctlr;
|
||||
|
@ -910,8 +909,6 @@ static int __init ebda_rsrc_controller(void)
|
|||
kfree(tmp_slot);
|
||||
error_no_slot:
|
||||
free_ebda_hpc(hpc_ptr);
|
||||
error_no_hpc:
|
||||
iounmap(io_mem);
|
||||
return rc;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue