dmaengine: dw: convert callback to helper function
This is in preperation of moving to a callback that provides results to the callback for the transaction. The conversion will maintain current behavior and the driver must convert to new callback mechanism at a later time in order to receive results. Signed-off-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de> Cc: Viresh Kumar <vireshk@kernel.org> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
parent
b310a619ab
commit
577ef92512
|
@ -270,20 +270,19 @@ static void
|
||||||
dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
|
dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
|
||||||
bool callback_required)
|
bool callback_required)
|
||||||
{
|
{
|
||||||
dma_async_tx_callback callback = NULL;
|
|
||||||
void *param = NULL;
|
|
||||||
struct dma_async_tx_descriptor *txd = &desc->txd;
|
struct dma_async_tx_descriptor *txd = &desc->txd;
|
||||||
struct dw_desc *child;
|
struct dw_desc *child;
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
|
struct dmaengine_desc_callback cb;
|
||||||
|
|
||||||
dev_vdbg(chan2dev(&dwc->chan), "descriptor %u complete\n", txd->cookie);
|
dev_vdbg(chan2dev(&dwc->chan), "descriptor %u complete\n", txd->cookie);
|
||||||
|
|
||||||
spin_lock_irqsave(&dwc->lock, flags);
|
spin_lock_irqsave(&dwc->lock, flags);
|
||||||
dma_cookie_complete(txd);
|
dma_cookie_complete(txd);
|
||||||
if (callback_required) {
|
if (callback_required)
|
||||||
callback = txd->callback;
|
dmaengine_desc_get_callback(txd, &cb);
|
||||||
param = txd->callback_param;
|
else
|
||||||
}
|
memset(&cb, 0, sizeof(cb));
|
||||||
|
|
||||||
/* async_tx_ack */
|
/* async_tx_ack */
|
||||||
list_for_each_entry(child, &desc->tx_list, desc_node)
|
list_for_each_entry(child, &desc->tx_list, desc_node)
|
||||||
|
@ -292,8 +291,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
|
||||||
dwc_desc_put(dwc, desc);
|
dwc_desc_put(dwc, desc);
|
||||||
spin_unlock_irqrestore(&dwc->lock, flags);
|
spin_unlock_irqrestore(&dwc->lock, flags);
|
||||||
|
|
||||||
if (callback)
|
dmaengine_desc_callback_invoke(&cb, NULL);
|
||||||
callback(param);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static void dwc_complete_all(struct dw_dma *dw, struct dw_dma_chan *dwc)
|
static void dwc_complete_all(struct dw_dma *dw, struct dw_dma_chan *dwc)
|
||||||
|
|
Loading…
Reference in New Issue