openkylin
/
platform_kernel-5.15
mirror of https://gitee.com/openkylin/platform_kernel-5.15.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

isci: remove the completion and event state handlers 

With these handlers gone the rest of the state handler infrastructure is
removed.

Added some WARN_ONCEs where previously we would cause NULL pointer
dereferences or silently run handlers from a previous state.

Reported-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams 2011-05-11 08:29:56 -07:00
parent a7e255a342
commit 79e2b6b276
2 changed files with 82 additions and 469 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

514
drivers/scsi/isci/request.c
View File

@ -890,21 +890,62 @@ scic_sds_io_request_terminate(struct scic_sds_request *sci_req)
return SCI_FAILURE_INVALID_STATE; return SCI_FAILURE_INVALID_STATE;
} }
enum sci_status scic_sds_io_request_event_handler( enum sci_status scic_sds_request_complete(struct scic_sds_request *sci_req)
struct scic_sds_request *request,
u32 event_code)
{ {
if (request->state_handlers->event_handler) enum sci_base_request_states state;
return request->state_handlers->event_handler(request, event_code); struct scic_sds_controller *scic = sci_req->owning_controller;
dev_warn(scic_to_dev(request->owning_controller), state = sci_req->state_machine.current_state_id;
"%s: SCIC IO Request given event code notification %x while " if (WARN_ONCE(state != SCI_BASE_REQUEST_STATE_COMPLETED,
"in wrong state %d\n", "isci: request completion from wrong state (%d)\n", state))
__func__, return SCI_FAILURE_INVALID_STATE;
event_code,
sci_base_state_machine_get_state(&request->state_machine));
return SCI_FAILURE_INVALID_STATE; if (!sci_req->was_tag_assigned_by_user)
scic_controller_free_io_tag(scic, sci_req->io_tag);
if (sci_req->saved_rx_frame_index != SCU_INVALID_FRAME_INDEX)
scic_sds_controller_release_frame(scic,
sci_req->saved_rx_frame_index);
/* XXX can we just stop the machine and remove the 'final' state? */
sci_base_state_machine_change_state(&sci_req->state_machine,
SCI_BASE_REQUEST_STATE_FINAL);
return SCI_SUCCESS;
}
enum sci_status scic_sds_io_request_event_handler(struct scic_sds_request *sci_req,
u32 event_code)
{
enum sci_base_request_states state;
struct scic_sds_controller *scic = sci_req->owning_controller;
state = sci_req->state_machine.current_state_id;
if (state != SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_IN_AWAIT_DATA_SUBSTATE) {
dev_warn(scic_to_dev(scic), "%s: (%x) in wrong state %d\n",
__func__, event_code, state);
return SCI_FAILURE_INVALID_STATE;
}
switch (scu_get_event_specifier(event_code)) {
case SCU_TASK_DONE_CRC_ERR << SCU_EVENT_SPECIFIC_CODE_SHIFT:
/* We are waiting for data and the SCU has R_ERR the data frame.
* Go back to waiting for the D2H Register FIS
*/
sci_base_state_machine_change_state(&sci_req->state_machine,
SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_FRAME_SUBSTATE);
return SCI_SUCCESS;
default:
dev_err(scic_to_dev(scic),
"%s: pio request unexpected event %#x\n",
__func__, event_code);
/* TODO Should we fail the PIO request when we get an
* unexpected event?
*/
return SCI_FAILURE;
}
} }
/* /*
@ -1080,34 +1121,8 @@ static enum sci_status request_started_state_tc_event(struct scic_sds_request *s
return SCI_SUCCESS; return SCI_SUCCESS;
} }
/* static enum sci_status request_aborting_state_tc_event(struct scic_sds_request *sci_req,
* This method implements the action to be taken when an SCIC_SDS_IO_REQUEST_T u32 completion_code)
* object receives a scic_sds_request_complete() request. This method frees up
* any io request resources that have been allocated and transitions the
* request to its final state. Consider stopping the state machine instead of
* transitioning to the final state? enum sci_status SCI_SUCCESS
*/
static enum sci_status scic_sds_request_completed_state_complete_handler(
struct scic_sds_request *request)
{
if (request->was_tag_assigned_by_user != true) {
scic_controller_free_io_tag(
request->owning_controller, request->io_tag);
}
if (request->saved_rx_frame_index != SCU_INVALID_FRAME_INDEX) {
scic_sds_controller_release_frame(
request->owning_controller, request->saved_rx_frame_index);
}
sci_base_state_machine_change_state(&request->state_machine,
SCI_BASE_REQUEST_STATE_FINAL);
return SCI_SUCCESS;
}
static enum sci_status request_aborting_state_tc_event(
struct scic_sds_request *sci_req,
u32 completion_code)
{ {
switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) { switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {
case (SCU_TASK_DONE_GOOD << SCU_COMPLETION_TL_STATUS_SHIFT): case (SCU_TASK_DONE_GOOD << SCU_COMPLETION_TL_STATUS_SHIFT):
@ -1585,48 +1600,6 @@ static enum sci_status pio_data_out_tx_done_tc_event(struct scic_sds_request *sc
return status; return status;
} }
/**
*
* @request: This is the request which is receiving the event.
* @event_code: This is the event code that the request on which the request is
* expected to take action.
*
* This method will handle any link layer events while waiting for the data
* frame. enum sci_status SCI_SUCCESS SCI_FAILURE
*/
static enum sci_status scic_sds_stp_request_pio_data_in_await_data_event_handler(
struct scic_sds_request *request,
u32 event_code)
{
enum sci_status status;
switch (scu_get_event_specifier(event_code)) {
case SCU_TASK_DONE_CRC_ERR << SCU_EVENT_SPECIFIC_CODE_SHIFT:
/*
* We are waiting for data and the SCU has R_ERR the data frame.
* Go back to waiting for the D2H Register FIS */
sci_base_state_machine_change_state(
&request->state_machine,
SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_FRAME_SUBSTATE
);
status = SCI_SUCCESS;
break;
default:
dev_err(scic_to_dev(request->owning_controller),
"%s: SCIC PIO Request 0x%p received unexpected "
"event 0x%08x\n",
__func__, request, event_code);
/* / @todo Should we fail the PIO request when we get an unexpected event? */
status = SCI_FAILURE;
break;
}
return status;
}
static void scic_sds_stp_request_udma_complete_request( static void scic_sds_stp_request_udma_complete_request(
struct scic_sds_request *request, struct scic_sds_request *request,
u32 scu_status, u32 scu_status,
@ -2236,37 +2209,6 @@ scic_sds_io_request_tc_completion(struct scic_sds_request *sci_req, u32 completi
} }
} }
static const struct scic_sds_io_request_state_handler scic_sds_request_state_handler_table[] = {
[SCI_BASE_REQUEST_STATE_INITIAL] = {},
[SCI_BASE_REQUEST_STATE_CONSTRUCTED] = {},
[SCI_BASE_REQUEST_STATE_STARTED] = { },
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION] = { },
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE] = { },
[SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_RESPONSE] = { },
[SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_COMPLETION] = { },
[SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_TC_COMPLETION_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_D2H_REG_FIS_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_H2D_COMPLETION_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_D2H_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_H2D_COMPLETION_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_FRAME_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_IN_AWAIT_DATA_SUBSTATE] = {
.event_handler = scic_sds_stp_request_pio_data_in_await_data_event_handler,
},
[SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_OUT_TRANSMIT_DATA_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_ASSERTED_COMPLETION_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_DIAGNOSTIC_COMPLETION_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_D2H_RESPONSE_FRAME_SUBSTATE] = { },
[SCI_BASE_REQUEST_STATE_COMPLETED] = {
.complete_handler = scic_sds_request_completed_state_complete_handler,
},
[SCI_BASE_REQUEST_STATE_ABORTING] = { },
[SCI_BASE_REQUEST_STATE_FINAL] = { },
};
/** /**
* isci_request_process_response_iu() - This function sets the status and * isci_request_process_response_iu() - This function sets the status and
* response iu, in the task struct, from the request object for the upper * response iu, in the task struct, from the request object for the upper
@ -2958,46 +2900,6 @@ static void isci_request_io_request_complete(struct isci_host *isci_host,
isci_host_can_dequeue(isci_host, 1); isci_host_can_dequeue(isci_host, 1);
} }
/**
* scic_sds_request_initial_state_enter() -
* @object: This parameter specifies the base object for which the state
* transition is occurring.
*
* This method implements the actions taken when entering the
* SCI_BASE_REQUEST_STATE_INITIAL state. This state is entered when the initial
* base request is constructed. Entry into the initial state sets all handlers
* for the io request object to their default handlers. none
*/
static void scic_sds_request_initial_state_enter(void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCI_BASE_REQUEST_STATE_INITIAL
);
}
/**
* scic_sds_request_constructed_state_enter() -
* @object: The io request object that is to enter the constructed state.
*
* This method implements the actions taken when entering the
* SCI_BASE_REQUEST_STATE_CONSTRUCTED state. The method sets the state handlers
* for the the constructed state. none
*/
static void scic_sds_request_constructed_state_enter(void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCI_BASE_REQUEST_STATE_CONSTRUCTED
);
}
static void scic_sds_request_started_state_enter(void *object) static void scic_sds_request_started_state_enter(void *object)
{ {
struct scic_sds_request *sci_req = object; struct scic_sds_request *sci_req = object;
@ -3011,12 +2913,6 @@ static void scic_sds_request_started_state_enter(void *object)
*/ */
task = ireq->ttype == io_task ? isci_request_access_task(ireq) : NULL; task = ireq->ttype == io_task ? isci_request_access_task(ireq) : NULL;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCI_BASE_REQUEST_STATE_STARTED
);
/* all unaccelerated request types (non ssp or ncq) handled with /* all unaccelerated request types (non ssp or ncq) handled with
* substates * substates
*/ */
@ -3046,30 +2942,13 @@ static void scic_sds_request_started_state_enter(void *object)
} }
} }
/**
* scic_sds_request_completed_state_enter() -
* @object: This parameter specifies the base object for which the state
* transition is occurring. This object is cast into a SCIC_SDS_IO_REQUEST
* object.
*
* This method implements the actions taken when entering the
* SCI_BASE_REQUEST_STATE_COMPLETED state. This state is entered when the
* SCIC_SDS_IO_REQUEST has completed. The method will decode the request
* completion status and convert it to an enum sci_status to return in the
* completion callback function. none
*/
static void scic_sds_request_completed_state_enter(void *object) static void scic_sds_request_completed_state_enter(void *object)
{ {
struct scic_sds_request *sci_req = object; struct scic_sds_request *sci_req = object;
struct scic_sds_controller *scic = struct scic_sds_controller *scic = sci_req->owning_controller;
scic_sds_request_get_controller(sci_req);
struct isci_host *ihost = scic_to_ihost(scic); struct isci_host *ihost = scic_to_ihost(scic);
struct isci_request *ireq = sci_req_to_ireq(sci_req); struct isci_request *ireq = sci_req_to_ireq(sci_req);
SET_STATE_HANDLER(sci_req,
scic_sds_request_state_handler_table,
SCI_BASE_REQUEST_STATE_COMPLETED);
/* Tell the SCI_USER that the IO request is complete */ /* Tell the SCI_USER that the IO request is complete */
if (sci_req->is_task_management_request == false) if (sci_req->is_task_management_request == false)
isci_request_io_request_complete(ihost, ireq, isci_request_io_request_complete(ihost, ireq,
@ -3078,93 +2957,12 @@ static void scic_sds_request_completed_state_enter(void *object)
isci_task_request_complete(ihost, ireq, sci_req->sci_status); isci_task_request_complete(ihost, ireq, sci_req->sci_status);
} }
/**
* scic_sds_request_aborting_state_enter() -
* @object: This parameter specifies the base object for which the state
* transition is occurring. This object is cast into a SCIC_SDS_IO_REQUEST
* object.
*
* This method implements the actions taken when entering the
* SCI_BASE_REQUEST_STATE_ABORTING state. none
*/
static void scic_sds_request_aborting_state_enter(void *object) static void scic_sds_request_aborting_state_enter(void *object)
{ {
struct scic_sds_request *sci_req = object; struct scic_sds_request *sci_req = object;
/* Setting the abort bit in the Task Context is required by the silicon. */ /* Setting the abort bit in the Task Context is required by the silicon. */
sci_req->task_context_buffer->abort = 1; sci_req->task_context_buffer->abort = 1;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCI_BASE_REQUEST_STATE_ABORTING
);
}
/**
* scic_sds_request_final_state_enter() -
* @object: This parameter specifies the base object for which the state
* transition is occurring. This is cast into a SCIC_SDS_IO_REQUEST object.
*
* This method implements the actions taken when entering the
* SCI_BASE_REQUEST_STATE_FINAL state. The only action required is to put the
* state handlers in place. none
*/
static void scic_sds_request_final_state_enter(void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCI_BASE_REQUEST_STATE_FINAL
);
}
static void scic_sds_io_request_started_task_mgmt_await_tc_completion_substate_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION
);
}
static void scic_sds_io_request_started_task_mgmt_await_task_response_substate_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE
);
}
static void scic_sds_smp_request_started_await_response_substate_enter(void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_RESPONSE
);
}
static void scic_sds_smp_request_started_await_tc_completion_substate_enter(void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_COMPLETION
);
} }
static void scic_sds_stp_request_started_non_data_await_h2d_completion_enter( static void scic_sds_stp_request_started_non_data_await_h2d_completion_enter(
@ -3172,133 +2970,27 @@ static void scic_sds_stp_request_started_non_data_await_h2d_completion_enter(
{ {
struct scic_sds_request *sci_req = object; struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER( scic_sds_remote_device_set_working_request(sci_req->target_device,
sci_req, sci_req);
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_H2D_COMPLETION_SUBSTATE
);
scic_sds_remote_device_set_working_request(
sci_req->target_device, sci_req
);
} }
static void scic_sds_stp_request_started_non_data_await_d2h_enter(void *object) static void scic_sds_stp_request_started_pio_await_h2d_completion_enter(void *object)
{ {
struct scic_sds_request *sci_req = object; struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER( scic_sds_remote_device_set_working_request(sci_req->target_device,
sci_req, sci_req);
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_D2H_SUBSTATE
);
} }
static void scic_sds_stp_request_started_soft_reset_await_h2d_asserted_completion_enter(void *object)
static void scic_sds_stp_request_started_pio_await_h2d_completion_enter(
void *object)
{ {
struct scic_sds_request *sci_req = object; struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER( scic_sds_remote_device_set_working_request(sci_req->target_device,
sci_req, sci_req);
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_H2D_COMPLETION_SUBSTATE
);
scic_sds_remote_device_set_working_request(
sci_req->target_device, sci_req);
} }
static void scic_sds_stp_request_started_pio_await_frame_enter(void *object) static void scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_completion_enter(void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_FRAME_SUBSTATE
);
}
static void scic_sds_stp_request_started_pio_data_in_await_data_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_IN_AWAIT_DATA_SUBSTATE
);
}
static void scic_sds_stp_request_started_pio_data_out_transmit_data_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_OUT_TRANSMIT_DATA_SUBSTATE
);
}
static void scic_sds_stp_request_started_udma_await_tc_completion_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_TC_COMPLETION_SUBSTATE
);
}
/**
*
*
* This state is entered when there is an TC completion failure. The hardware
* received an unexpected condition while processing the IO request and now
* will UF the D2H register FIS to complete the IO.
*/
static void scic_sds_stp_request_started_udma_await_d2h_reg_fis_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_D2H_REG_FIS_SUBSTATE
);
}
static void scic_sds_stp_request_started_soft_reset_await_h2d_asserted_completion_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_ASSERTED_COMPLETION_SUBSTATE
);
scic_sds_remote_device_set_working_request(
sci_req->target_device, sci_req
);
}
static void scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_completion_enter(
void *object)
{ {
struct scic_sds_request *sci_req = object; struct scic_sds_request *sci_req = object;
struct scu_task_context *task_context; struct scu_task_context *task_context;
@ -3315,91 +3007,45 @@ static void scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_complet
task_context->control_frame = 0; task_context->control_frame = 0;
status = scic_controller_continue_io(sci_req); status = scic_controller_continue_io(sci_req);
if (status == SCI_SUCCESS) { WARN_ONCE(status != SCI_SUCCESS, "isci: continue io failure\n");
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_DIAGNOSTIC_COMPLETION_SUBSTATE
);
}
}
static void scic_sds_stp_request_started_soft_reset_await_d2h_response_enter(
void *object)
{
struct scic_sds_request *sci_req = object;
SET_STATE_HANDLER(
sci_req,
scic_sds_request_state_handler_table,
SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_D2H_RESPONSE_FRAME_SUBSTATE
);
} }
static const struct sci_base_state scic_sds_request_state_table[] = { static const struct sci_base_state scic_sds_request_state_table[] = {
[SCI_BASE_REQUEST_STATE_INITIAL] = { [SCI_BASE_REQUEST_STATE_INITIAL] = { },
.enter_state = scic_sds_request_initial_state_enter, [SCI_BASE_REQUEST_STATE_CONSTRUCTED] = { },
},
[SCI_BASE_REQUEST_STATE_CONSTRUCTED] = {
.enter_state = scic_sds_request_constructed_state_enter,
},
[SCI_BASE_REQUEST_STATE_STARTED] = { [SCI_BASE_REQUEST_STATE_STARTED] = {
.enter_state = scic_sds_request_started_state_enter, .enter_state = scic_sds_request_started_state_enter,
}, },
[SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_H2D_COMPLETION_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_H2D_COMPLETION_SUBSTATE] = {
.enter_state = scic_sds_stp_request_started_non_data_await_h2d_completion_enter, .enter_state = scic_sds_stp_request_started_non_data_await_h2d_completion_enter,
}, },
[SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_D2H_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_NON_DATA_AWAIT_D2H_SUBSTATE] = { },
.enter_state = scic_sds_stp_request_started_non_data_await_d2h_enter,
},
[SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_H2D_COMPLETION_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_H2D_COMPLETION_SUBSTATE] = {
.enter_state = scic_sds_stp_request_started_pio_await_h2d_completion_enter, .enter_state = scic_sds_stp_request_started_pio_await_h2d_completion_enter,
}, },
[SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_FRAME_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_PIO_AWAIT_FRAME_SUBSTATE] = { },
.enter_state = scic_sds_stp_request_started_pio_await_frame_enter, [SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_IN_AWAIT_DATA_SUBSTATE] = { },
}, [SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_OUT_TRANSMIT_DATA_SUBSTATE] = { },
[SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_IN_AWAIT_DATA_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_TC_COMPLETION_SUBSTATE] = { },
.enter_state = scic_sds_stp_request_started_pio_data_in_await_data_enter, [SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_D2H_REG_FIS_SUBSTATE] = { },
},
[SCIC_SDS_STP_REQUEST_STARTED_PIO_DATA_OUT_TRANSMIT_DATA_SUBSTATE] = {
.enter_state = scic_sds_stp_request_started_pio_data_out_transmit_data_enter,
},
[SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_TC_COMPLETION_SUBSTATE] = {
.enter_state = scic_sds_stp_request_started_udma_await_tc_completion_enter,
},
[SCIC_SDS_STP_REQUEST_STARTED_UDMA_AWAIT_D2H_REG_FIS_SUBSTATE] = {
.enter_state = scic_sds_stp_request_started_udma_await_d2h_reg_fis_enter,
},
[SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_ASSERTED_COMPLETION_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_ASSERTED_COMPLETION_SUBSTATE] = {
.enter_state = scic_sds_stp_request_started_soft_reset_await_h2d_asserted_completion_enter, .enter_state = scic_sds_stp_request_started_soft_reset_await_h2d_asserted_completion_enter,
}, },
[SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_DIAGNOSTIC_COMPLETION_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_H2D_DIAGNOSTIC_COMPLETION_SUBSTATE] = {
.enter_state = scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_completion_enter, .enter_state = scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_completion_enter,
}, },
[SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_D2H_RESPONSE_FRAME_SUBSTATE] = { [SCIC_SDS_STP_REQUEST_STARTED_SOFT_RESET_AWAIT_D2H_RESPONSE_FRAME_SUBSTATE] = { },
.enter_state = scic_sds_stp_request_started_soft_reset_await_d2h_response_enter, [SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION] = { },
}, [SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE] = { },
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_COMPLETION] = { [SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_RESPONSE] = { },
.enter_state = scic_sds_io_request_started_task_mgmt_await_tc_completion_substate_enter, [SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_COMPLETION] = { },
},
[SCIC_SDS_IO_REQUEST_STARTED_TASK_MGMT_SUBSTATE_AWAIT_TC_RESPONSE] = {
.enter_state = scic_sds_io_request_started_task_mgmt_await_task_response_substate_enter,
},
[SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_RESPONSE] = {
.enter_state = scic_sds_smp_request_started_await_response_substate_enter,
},
[SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_COMPLETION] = {
.enter_state = scic_sds_smp_request_started_await_tc_completion_substate_enter,
},
[SCI_BASE_REQUEST_STATE_COMPLETED] = { [SCI_BASE_REQUEST_STATE_COMPLETED] = {
.enter_state = scic_sds_request_completed_state_enter, .enter_state = scic_sds_request_completed_state_enter,
}, },
[SCI_BASE_REQUEST_STATE_ABORTING] = { [SCI_BASE_REQUEST_STATE_ABORTING] = {
.enter_state = scic_sds_request_aborting_state_enter, .enter_state = scic_sds_request_aborting_state_enter,
}, },
[SCI_BASE_REQUEST_STATE_FINAL] = { [SCI_BASE_REQUEST_STATE_FINAL] = { },
.enter_state = scic_sds_request_final_state_enter,
},
}; };
static void scic_sds_general_request_construct(struct scic_sds_controller *scic, static void scic_sds_general_request_construct(struct scic_sds_controller *scic,

37
drivers/scsi/isci/request.h
View File

@ -223,13 +223,6 @@ struct scic_sds_request {
*/ */
u32 saved_rx_frame_index; u32 saved_rx_frame_index;
/**
* This field specifies the current state handlers in place for this
* IO Request object. This field is updated each time the request
* changes state.
*/
const struct scic_sds_io_request_state_handler *state_handlers;
/** /**
* This field in the recorded device sequence for the io request. This is * This field in the recorded device sequence for the io request. This is
* recorded during the build operation and is compared in the start * recorded during the build operation and is compared in the start
@ -422,27 +415,6 @@ enum sci_base_request_states {
SCI_BASE_REQUEST_STATE_FINAL, SCI_BASE_REQUEST_STATE_FINAL,
}; };
typedef enum sci_status (*scic_sds_io_request_handler_t)
(struct scic_sds_request *request);
typedef enum sci_status (*scic_sds_io_request_event_handler_t)
(struct scic_sds_request *req, u32 event);
/**
* struct scic_sds_io_request_state_handler - This is the SDS core definition
* of the state handlers.
*
*
*/
struct scic_sds_io_request_state_handler {
/**
* The complete_handler specifies the method invoked when a user attempts to
* complete a request.
*/
scic_sds_io_request_handler_t complete_handler;
scic_sds_io_request_event_handler_t event_handler;
};
/** /**
* scic_sds_request_get_controller() - * scic_sds_request_get_controller() -
* *
@ -495,13 +467,6 @@ struct scic_sds_io_request_state_handler {
(request)->sci_status = (sci_status_code); \ (request)->sci_status = (sci_status_code); \
} }
#define scic_sds_request_complete(a_request) \
((a_request)->state_handlers->complete_handler(a_request))
extern enum sci_status
scic_sds_io_request_tc_completion(struct scic_sds_request *request, u32 completion_code);
/** /**
* SCU_SGL_ZERO() - * SCU_SGL_ZERO() -
* *
@ -538,6 +503,8 @@ enum sci_status scic_sds_io_request_event_handler(struct scic_sds_request *sci_r
enum sci_status scic_sds_io_request_frame_handler(struct scic_sds_request *sci_req, enum sci_status scic_sds_io_request_frame_handler(struct scic_sds_request *sci_req,
u32 frame_index); u32 frame_index);
enum sci_status scic_sds_task_request_terminate(struct scic_sds_request *sci_req); enum sci_status scic_sds_task_request_terminate(struct scic_sds_request *sci_req);
extern enum sci_status scic_sds_request_complete(struct scic_sds_request *sci_req);
extern enum sci_status scic_sds_io_request_tc_completion(struct scic_sds_request *sci_req, u32 code);
/* XXX open code in caller */ /* XXX open code in caller */
static inline void *scic_request_get_virt_addr(struct scic_sds_request *sci_req, static inline void *scic_request_get_virt_addr(struct scic_sds_request *sci_req,