openkylin
/
platform_kernel-5.15
mirror of https://gitee.com/openkylin/platform_kernel-5.15.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: ppp_generic - use DEFINE_IDR for static initialization 

We could use DEFINE_IDR for statically allocated idr
that allow us to save a few lines of code.

And spell fix.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Cyrill Gorcunov 2008-12-18 22:59:32 -08:00 committed by David S. Miller
parent a109a5b916
commit ab5024ab23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ppp_generic.c
View File

@ -179,7 +179,7 @@ struct channel {
*/ */
static DEFINE_MUTEX(all_ppp_mutex); static DEFINE_MUTEX(all_ppp_mutex);
static atomic_t ppp_unit_count = ATOMIC_INIT(0); static atomic_t ppp_unit_count = ATOMIC_INIT(0);
static struct idr ppp_units_idr; static DEFINE_IDR(ppp_units_idr);
/* /*
* all_channels_lock protects all_channels and last_channel_index, * all_channels_lock protects all_channels and last_channel_index,
@ -852,8 +852,6 @@ static int __init ppp_init(void)
"ppp"); "ppp");
} }
idr_init(&ppp_units_idr);
out: out:
if (err) if (err)
printk(KERN_ERR "failed to register PPP device (%d)\n", err); printk(KERN_ERR "failed to register PPP device (%d)\n", err);
@ -2435,7 +2433,7 @@ ppp_create_interface(int unit, int *retp)
if (unit_find(&ppp_units_idr, unit)) if (unit_find(&ppp_units_idr, unit))
goto out2; /* unit already exists */ goto out2; /* unit already exists */
else { else {
/* darn, someone is cheatting us? */ /* darn, someone is cheating us? */
*retp = -EINVAL; *retp = -EINVAL;
goto out2; goto out2;
} }