openkylin
/
platform_kernel-5.15
mirror of https://gitee.com/openkylin/platform_kernel-5.15.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ALSA: hda - Fix access-after-free in patch_realtek.c 

alc_free_kctls() has to be called after all jobs done in alc_build_controls().

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai 2010-03-22 08:30:20 +01:00
parent ea823c0891
commit bae84e70d6
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/pci/hda/patch_realtek.c
View File

@ -2532,8 +2532,6 @@ static int alc_build_controls(struct hda_codec *codec)
return err; return err;
} }
alc_free_kctls(codec); /* no longer needed */
/* assign Capture Source enums to NID */ /* assign Capture Source enums to NID */
kctl = snd_hda_find_mixer_ctl(codec, "Capture Source"); kctl = snd_hda_find_mixer_ctl(codec, "Capture Source");
if (!kctl) if (!kctl)
@ -2602,6 +2600,9 @@ static int alc_build_controls(struct hda_codec *codec)
} }
} }
} }
alc_free_kctls(codec); /* no longer needed */
return 0; return 0;
} }