openkylin
/
platform_kernel-5.15
mirror of https://gitee.com/openkylin/platform_kernel-5.15.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Thermal: x86_pkg_temp: fix krealloc() misuse in in pkg_temp_thermal_device_add() 

If krealloc() returns NULL, it doesn't free the original. So any code
of the form 'foo = krealloc(foo, ...);' is almost certainly a bug.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
This commit is contained in:
Wei Yongjun 2013-06-18 21:09:12 +08:00 committed by Zhang Rui
parent f3ed0a17f0
commit c7c1b3112e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/thermal/x86_pkg_temp_thermal.c
View File

@ -394,6 +394,7 @@ static int pkg_temp_thermal_device_add(unsigned int cpu)
char buffer[30]; char buffer[30];
int thres_count; int thres_count;
u32 eax, ebx, ecx, edx; u32 eax, ebx, ecx, edx;
u8 *temp;
cpuid(6, &eax, &ebx, &ecx, &edx); cpuid(6, &eax, &ebx, &ecx, &edx);
thres_count = ebx & 0x07; thres_count = ebx & 0x07;
@ -417,13 +418,14 @@ static int pkg_temp_thermal_device_add(unsigned int cpu)
spin_lock(&pkg_work_lock); spin_lock(&pkg_work_lock);
if (topology_physical_package_id(cpu) > max_phy_id) if (topology_physical_package_id(cpu) > max_phy_id)
max_phy_id = topology_physical_package_id(cpu); max_phy_id = topology_physical_package_id(cpu);
pkg_work_scheduled = krealloc(pkg_work_scheduled, temp = krealloc(pkg_work_scheduled,
(max_phy_id+1) * sizeof(u8), GFP_ATOMIC); (max_phy_id+1) * sizeof(u8), GFP_ATOMIC);
if (!pkg_work_scheduled) { if (!temp) {
spin_unlock(&pkg_work_lock); spin_unlock(&pkg_work_lock);
err = -ENOMEM; err = -ENOMEM;
goto err_ret_free; goto err_ret_free;
} }
pkg_work_scheduled = temp;
pkg_work_scheduled[topology_physical_package_id(cpu)] = 0; pkg_work_scheduled[topology_physical_package_id(cpu)] = 0;
spin_unlock(&pkg_work_lock); spin_unlock(&pkg_work_lock);