openkylin
/
platform_kernel-5.15
mirror of https://gitee.com/openkylin/platform_kernel-5.15.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

pm8001: Cleaning up uninitialized variables 

There is a risk that the variable will be used without being initialized.

This was largely found by using a static code analysis program called cppche

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Acked-by: Jack Wang <xjtuwjp@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Rickard Strandqvist 2014-07-09 17:20:10 +05:30 committed by Christoph Hellwig
parent d98164461c
commit da225498d9
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/pm8001/pm80xx_hwi.c
View File

@ -952,7 +952,7 @@ static int
pm80xx_get_encrypt_info(struct pm8001_hba_info *pm8001_ha) pm80xx_get_encrypt_info(struct pm8001_hba_info *pm8001_ha)
{ {
u32 scratch3_value; u32 scratch3_value;
int ret; int ret = -1;
/* Read encryption status from SCRATCH PAD 3 */ /* Read encryption status from SCRATCH PAD 3 */
scratch3_value = pm8001_cr32(pm8001_ha, 0, MSGU_SCRATCH_PAD_3); scratch3_value = pm8001_cr32(pm8001_ha, 0, MSGU_SCRATCH_PAD_3);
@ -986,7 +986,7 @@ pm80xx_get_encrypt_info(struct pm8001_hba_info *pm8001_ha)
pm8001_ha->encrypt_info.status = 0xFFFFFFFF; pm8001_ha->encrypt_info.status = 0xFFFFFFFF;
pm8001_ha->encrypt_info.cipher_mode = 0; pm8001_ha->encrypt_info.cipher_mode = 0;
pm8001_ha->encrypt_info.sec_mode = 0; pm8001_ha->encrypt_info.sec_mode = 0;
return 0; ret = 0;
} else if ((scratch3_value & SCRATCH_PAD3_ENC_MASK) == } else if ((scratch3_value & SCRATCH_PAD3_ENC_MASK) ==
SCRATCH_PAD3_ENC_DIS_ERR) { SCRATCH_PAD3_ENC_DIS_ERR) {
pm8001_ha->encrypt_info.status = pm8001_ha->encrypt_info.status =
@ -1008,7 +1008,6 @@ pm80xx_get_encrypt_info(struct pm8001_hba_info *pm8001_ha)
scratch3_value, pm8001_ha->encrypt_info.cipher_mode, scratch3_value, pm8001_ha->encrypt_info.cipher_mode,
pm8001_ha->encrypt_info.sec_mode, pm8001_ha->encrypt_info.sec_mode,
pm8001_ha->encrypt_info.status)); pm8001_ha->encrypt_info.status));
ret = -1;
} else if ((scratch3_value & SCRATCH_PAD3_ENC_MASK) == } else if ((scratch3_value & SCRATCH_PAD3_ENC_MASK) ==
SCRATCH_PAD3_ENC_ENA_ERR) { SCRATCH_PAD3_ENC_ENA_ERR) {
@ -1032,7 +1031,6 @@ pm80xx_get_encrypt_info(struct pm8001_hba_info *pm8001_ha)
scratch3_value, pm8001_ha->encrypt_info.cipher_mode, scratch3_value, pm8001_ha->encrypt_info.cipher_mode,
pm8001_ha->encrypt_info.sec_mode, pm8001_ha->encrypt_info.sec_mode,
pm8001_ha->encrypt_info.status)); pm8001_ha->encrypt_info.status));
ret = -1;
} }
return ret; return ret;
} }