openkylin
/
platform_packages_apps_Launcher3
mirror of https://gitee.com/openkylin/platform_packages_apps_launcher3.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

TaskOverlayFactoryGo: Keep persistent instance of AssistContentRequester 

Holding a reference to AssistContentRequester prevents it from being deleted by the garbage collector while it is still in use.

Bug: 189985872
Test: Manual (Pixel 3A)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I204aab907175a171c496c3bd146a8b23d2bbcf16
This commit is contained in:
Jon Spivack 2021-06-02 15:55:06 -07:00
parent 8c46bba98e
commit 1bd7ccd90b
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
go/quickstep/src/com/android/quickstep/TaskOverlayFactoryGo.java
View File

@ -53,14 +53,17 @@ public final class TaskOverlayFactoryGo extends TaskOverlayFactory {
public static final int ERROR_PERMISSIONS = 1; public static final int ERROR_PERMISSIONS = 1;
private static final String TAG = "TaskOverlayFactoryGo"; private static final String TAG = "TaskOverlayFactoryGo";
// Empty constructor required for ResourceBasedOverride private AssistContentRequester mContentRequester;
public TaskOverlayFactoryGo(Context context) {}
public TaskOverlayFactoryGo(Context context) {
mContentRequester = new AssistContentRequester(context);
}
/** /**
* Create a new overlay instance for the given View * Create a new overlay instance for the given View
*/ */
public TaskOverlayGo createOverlay(TaskThumbnailView thumbnailView) { public TaskOverlayGo createOverlay(TaskThumbnailView thumbnailView) {
return new TaskOverlayGo(thumbnailView); return new TaskOverlayGo(thumbnailView, mContentRequester);
} }
/** /**
@ -72,9 +75,12 @@ public final class TaskOverlayFactoryGo extends TaskOverlayFactory {
private String mTaskPackageName; private String mTaskPackageName;
private String mWebUrl; private String mWebUrl;
private boolean mAssistPermissionsEnabled; private boolean mAssistPermissionsEnabled;
private AssistContentRequester mFactoryContentRequester;
private TaskOverlayGo(TaskThumbnailView taskThumbnailView) { private TaskOverlayGo(TaskThumbnailView taskThumbnailView,
AssistContentRequester assistContentRequester) {
super(taskThumbnailView); super(taskThumbnailView);
mFactoryContentRequester = assistContentRequester;
} }
/** /**
@ -105,9 +111,7 @@ public final class TaskOverlayFactoryGo extends TaskOverlayFactory {
} }
int taskId = task.key.id; int taskId = task.key.id;
AssistContentRequester contentRequester = mFactoryContentRequester.requestAssistContent(taskId, this::onAssistContentReceived);
new AssistContentRequester(mApplicationContext);
contentRequester.requestAssistContent(taskId, this::onAssistContentReceived);
} }
/** Provide Assist Content to the overlay. */ /** Provide Assist Content to the overlay. */