Merge "resolve merge conflicts of a754e678a7 to sc-v2-dev" into sc-v2-dev

This commit is contained in:
TreeHugger Robot 2021-06-25 16:15:50 +00:00 committed by Android (Google) Code Review
commit 3e86b02d55
2 changed files with 16 additions and 1 deletions

View File

@ -41,6 +41,7 @@
<!-- Scalable Grid --> <!-- Scalable Grid -->
<dimen name="scalable_grid_left_right_margin">22dp</dimen> <dimen name="scalable_grid_left_right_margin">22dp</dimen>
<dimen name="scalable_grid_qsb_bottom_margin">42dp</dimen>
<!-- Workspace page indicator --> <!-- Workspace page indicator -->
<dimen name="workspace_page_indicator_height">24dp</dimen> <dimen name="workspace_page_indicator_height">24dp</dimen>

View File

@ -162,6 +162,9 @@ public class DeviceProfile {
public final int hotseatBarSidePaddingEndPx; public final int hotseatBarSidePaddingEndPx;
public final int hotseatQsbHeight; public final int hotseatQsbHeight;
public final float qsbBottomMarginOriginalPx;
public int qsbBottomMarginPx;
// All apps // All apps
public int allAppsOpenVerticalTranslate; public int allAppsOpenVerticalTranslate;
public int allAppsCellHeightPx; public int allAppsCellHeightPx;
@ -336,6 +339,10 @@ public class DeviceProfile {
res.getDimensionPixelSize(R.dimen.dynamic_grid_hotseat_extra_vertical_size); res.getDimensionPixelSize(R.dimen.dynamic_grid_hotseat_extra_vertical_size);
updateHotseatIconSize(pxFromDp(inv.iconSize, mMetrics, 1f)); updateHotseatIconSize(pxFromDp(inv.iconSize, mMetrics, 1f));
qsbBottomMarginOriginalPx = isScalableGrid
? res.getDimensionPixelSize(R.dimen.scalable_grid_qsb_bottom_margin)
: 0;
overviewTaskMarginPx = res.getDimensionPixelSize(R.dimen.overview_task_margin); overviewTaskMarginPx = res.getDimensionPixelSize(R.dimen.overview_task_margin);
overviewTaskIconSizePx = overviewTaskIconSizePx =
isTablet && FeatureFlags.ENABLE_OVERVIEW_GRID.get() ? res.getDimensionPixelSize( isTablet && FeatureFlags.ENABLE_OVERVIEW_GRID.get() ? res.getDimensionPixelSize(
@ -364,6 +371,8 @@ public class DeviceProfile {
extraHotseatBottomPadding = Math.round(paddingHotseatBottom * iconScale); extraHotseatBottomPadding = Math.round(paddingHotseatBottom * iconScale);
hotseatBarSizePx += extraHotseatBottomPadding; hotseatBarSizePx += extraHotseatBottomPadding;
qsbBottomMarginPx = Math.round(qsbBottomMarginOriginalPx * iconScale);
} else if (!isVerticalBarLayout() && isPhone && isTallDevice) { } else if (!isVerticalBarLayout() && isPhone && isTallDevice) {
// We increase the hotseat size when there is extra space. // We increase the hotseat size when there is extra space.
// ie. For a display with a large aspect ratio, we can keep the icons on the workspace // ie. For a display with a large aspect ratio, we can keep the icons on the workspace
@ -810,8 +819,13 @@ public class DeviceProfile {
int freeSpace = isTaskbarPresent int freeSpace = isTaskbarPresent
? workspacePadding.bottom ? workspacePadding.bottom
: hotseatBarSizePx - hotseatCellHeightPx - hotseatQsbHeight; : hotseatBarSizePx - hotseatCellHeightPx - hotseatQsbHeight;
return (int) (freeSpace * QSB_CENTER_FACTOR)
if (isScalableGrid && qsbBottomMarginPx <= freeSpace) {
return qsbBottomMarginPx;
} else {
return (int) (freeSpace * QSB_CENTER_FACTOR)
+ (isTaskbarPresent ? taskbarSize : getInsets().bottom); + (isTaskbarPresent ? taskbarSize : getInsets().bottom);
}
} }
/** /**