openkylin
/
platform_packages_apps_Launcher3
mirror of https://gitee.com/openkylin/platform_packages_apps_launcher3.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Check orientation changes on task item attaching 

onConfigurationChanged is only passed down to views that are currently
attached. Naturally, a recycler view has some views in its pool that are
not attached and thus do not get the call when the orientation changes.
When this happens and the view is then attached later, it can be in an
incorrect orientation.

To fix this, we save the current orientation the task item is using and
check on attaching if it's still the same as the orientation the device
is in. If it isn't we then run the orientation change logic.

Bug: 131848689
Fix: 131848689
Test: Change orientation with some views not attached, see that they are
correct orientation when attached
Change-Id: I3dec501c332338444e321b4a50876c7840a5bc6e
This commit is contained in:
Kevin 2019-05-02 13:27:49 -07:00
parent d16f87f52d
commit b731c07e04
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
go/quickstep/src/com/android/quickstep/views/TaskItemView.java
View File

@ -49,6 +49,7 @@ public final class TaskItemView extends LinearLayout {
private ImageView mIconView;
private ImageView mThumbnailView;
private float mContentTransitionProgress;
private int mDisplayedOrientation;
/**
* Property representing the content transition progress of the view. 1.0f represents that the
@ -178,14 +179,28 @@ public final class TaskItemView extends LinearLayout {
return (label != null) ? label : DEFAULT_LABEL;
}
@Override
protected void onAttachedToWindow() {
super.onAttachedToWindow();
onOrientationChanged(getResources().getConfiguration().orientation);
}
@Override
protected void onConfigurationChanged(Configuration newConfig) {
super.onConfigurationChanged(newConfig);
onOrientationChanged(newConfig.orientation);
}
private void onOrientationChanged(int newOrientation) {
if (mDisplayedOrientation == newOrientation) {
return;
}
mDisplayedOrientation = newOrientation;
int layerCount = mThumbnailDrawable.getNumberOfLayers();
for (int i = 0; i < layerCount; i++) {
Drawable drawable = mThumbnailDrawable.getDrawable(i);
if (drawable instanceof ThumbnailDrawable) {
((ThumbnailDrawable) drawable).setRequestedOrientation(newConfig.orientation);
((ThumbnailDrawable) drawable).setRequestedOrientation(newOrientation);
}
}
mTaskIconThumbnailView.forceLayout();