From cd4f4138f05be3a1daab5035c59e97a1a82431ac Mon Sep 17 00:00:00 2001 From: Vadim Tryshev Date: Tue, 19 May 2015 14:19:37 -0700 Subject: [PATCH] Removing itemCount, fromIndex and toIndex from AccessibilityEvent.TYPE_VIEW_SCROLLED sent by PagedView. This causes an additional reduntant voice message on scroll (see the bug). Also, setting these attributes violate rules set here: http://developer.android.com/reference/android/view/accessibility/AccessibilityEvent.html i.e. that these fields should be set only for descendants of AdapterView. Note that we can't just stop sending TYPE_VIEW_SCROLLED, because in this case, accessibility focus won't be set after scrolling. Bug: 21304383 Change-Id: I84f8e064d8209c0e09d6827551e00c9913829b57 --- src/com/android/launcher3/PagedView.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/com/android/launcher3/PagedView.java b/src/com/android/launcher3/PagedView.java index c8e7d9c0b9..e6dc59cfa9 100644 --- a/src/com/android/launcher3/PagedView.java +++ b/src/com/android/launcher3/PagedView.java @@ -639,9 +639,6 @@ public abstract class PagedView extends ViewGroup implements ViewGroup.OnHierarc if (mCurrentPage != getNextPage()) { AccessibilityEvent ev = AccessibilityEvent.obtain(AccessibilityEvent.TYPE_VIEW_SCROLLED); - ev.setItemCount(getChildCount()); - ev.setFromIndex(getNextPage()); - ev.setToIndex(getNextPage()); sendAccessibilityEventUnchecked(ev); }