Commit Graph

35535 Commits

Author SHA1 Message Date
Alex Chau 1c883d861e Add launcher grid spec for tablet
- Introduced device_category to allow grids to be only enabled for certain device types. By default grids are enabled for all device types, so old OEM device_profiles aren't affected
  - Removed device_profiles_split.xml as a result and merged with device_profiles.xml
- Added deviceType in InvariantDeviceProfile to replace isSplitDisplay and centralize the logic
- Only has 6x5 grid with new default layout that works better for tablets

Bug: 198575341
Test: manual
Change-Id: I03f6727ce837ffeee6321b6d7c53942338d0cf30
2021-12-08 18:22:34 +00:00
Jerry Chang 7d20de28e3 Always draw background for task thumbnail
Always draw background for task thumbnail because the task snapshot
might be translucent or partially empty.

For example, when drag-to-dismiss split screen, it will reparent tasks
from dismissing split root to the bottom of display. Task thumbnail of
those tasks might be partially empty because the snapshot was taken in
new bounds inherits from display but with split screen content.

Fix: 200096421
Test: drag to dismiss split, observed task thumbnail no longger been
      cropped.
Change-Id: I5d04daa55a558f79ccf5127080088bd0698d06d8
2021-12-09 01:44:46 +08:00
Tony Wickham b5a051ca0b Merge changes I6cf84ec7,Iea599651,If3238286 into sc-v2-dev
* changes:
  Improve quick switch from home to taskbar
  Cleanup some taskbar/hotseat handoff issues
  Fix taskbar stash misalignment when going from app to overview
2021-12-08 17:42:54 +00:00
Alex Chau 1b0e524d94 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev 2021-12-08 17:39:32 +00:00
TreeHugger Robot d1c9cd2700 Merge "Fix split animation for grid RTL" into sc-v2-dev 2021-12-08 12:06:23 +00:00
Alex Chau 86ef5e924a Handle split select rotation
- Update floatingTaskView, apply splitsSelectTranslation and splitPrimaryScorllOffest when rotating while in split select
- Moved getSplitSelectTranslation to RecentsView
- When in portrait, treat STAGE_POSITION_BOTTOM_OR_RIGHT as STAGE_POSITION_TOP_OR_LEFT in split translation calculation
- Apply splitsSelectTranslation for portrait grid too

Fix: 201721153
Test: manual
Change-Id: I768a3b15de4d434674058b274c368798f5852917
2021-12-08 11:35:02 +00:00
Alex Chau 9fa58b2fee Revert "Align OverviewActionsView for 3 button taskbar"
This reverts commit 0bd0733ef4.

Reason for revert: b/209025715
Bug: 189807374

Change-Id: I477bacc318e84c16f124cf776ddd8446959755aa
2021-12-08 11:17:14 +00:00
TreeHugger Robot 57b9c472dc Merge "[DO NOT MERGE] Remove one search flag and code from sc-v2." into sc-v2-dev 2021-12-08 06:57:28 +00:00
Vinit Nayak 0f12803061 Fix split animation for grid RTL
Fixes: 202156862
Test: Tested grid + non grid,
RTL + LTR

Change-Id: I303f60efdd9f2f2ea412e31e574d9a3b50fecf30
2021-12-07 22:13:06 -08:00
Brian Isganitis d3ebc4c692 Merge "Adding support for logging wallpaper container info." into sc-v2-dev 2021-12-08 05:48:30 +00:00
Vinit Nayak 4e0d4239e4 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev 2021-12-08 04:02:31 +00:00
Brian Isganitis 79efba935f Adding support for logging wallpaper container info.
Test: https://paste.googleplex.com/5350571797118976 shows logging carousel size and index of wallpaper tapped. If the wallpaper is a live wallpaper, we also log its application info.
Bug: 188222480
Change-Id: I6dd7ac20af7afd675d8a886d5b838263680f773e
Merged-In: I6dd7ac20af7afd675d8a886d5b838263680f773e
2021-12-08 00:22:59 +00:00
Tony Wickham 24675d36b7 Improve quick switch from home to taskbar
- Add LauncherState#isTaskbarAlignedWithHotseat() which defaults to !isTaskbarStashed(), but is always false for quick switch from home
- Replaced FLAG_TRANSITION_STATE_START_STASHED and FLAG_TRANSITION_STATE_COMMITTED_STASHED with FLAG_STATE_TRANSITION_RUNNING and a reference to mLauncherState. STATE_START is equivalent to TRANSITION_RUNNING changing to true, and STATE_COMMITTED is equivalent to TRANSITION_RUNNING changing to false. Then can get details from the state such as whether taskbar is stashed and icon alignment from mLauncherState

Test: quick switch from home, both with taskbar stashed in apps and not
Fixes: 194728611
Bug: 204657916
Change-Id: I6cf84ec73a4036e14cc7268667c6f62100884c27
2021-12-07 13:13:48 -08:00
Vinit Nayak 0bd0733ef4 Align OverviewActionsView for 3 button taskbar
Bug: 189807374
Change-Id: I529dba5d4df3d0c3366c111e70991a36bec4bfc3
2021-12-07 13:07:32 -08:00
Tony Wickham 779879ce3d Merge "Remove LauncherState.TASKBAR visible element" into sc-v2-dev 2021-12-07 20:42:55 +00:00
Alex Chau 992db75dae Use percentage scaling for overview thumbnail size
- Limit overview to screen ratio to be at max 70%
- Tuned row spacing and page spacing
- Added 2 more test activities to testOverviewForTablet to avoid dismissing tasks at end of grid, as more grid tasks are now shown

Bug: 207350366
Test: manual
Change-Id: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
Merged-In: Id04871464bdb3ef2d6b046977b0ffd9bd51bc230
2021-12-07 14:50:40 +00:00
Tony Wickham 9566290e13 Cleanup some taskbar/hotseat handoff issues
- Clearly distinguish Home <-> App icon alignment (ForResumedState and ForGestureState) from Home <-> Home states (ForLauncherState) by renaming onIconAlignmentRatioChanged() to onIconAlignmentRatioChangedForAppAndHomeTransition (for the former)
- Make sure initial state is properly applied by treating all flags as changed
- onIconAlignmentRatioChangedForStateTransition only runs when launcher is resumed (fixes 208648294)
- Animate taskbar background alpha when going between home and app, separate from icon alignment (bug: 204657916)
- Only copy hotseat's alpha to taskbar when hotseat is originally visible (also bug: 204657916)

Test: Open an app on small screen, open large screen and ensure taskbar stays at the bottom instead of aligning with non-present hotseat (bug: 208648294)
Test: Swipe up and down on home scren, ensure taskbar background never appears and there's no jump between taskbar and hotseat
Change-Id: Iea59965118f2bdbd8ce49279f76fb01fbd61f60b
2021-12-06 17:16:19 -08:00
Tony Wickham 7af54403a3 Remove LauncherState.TASKBAR visible element
It's no longer used, so removing to cleanup code and reduce confusion

Test: no functional change
Fixes: 209512651
Change-Id: Ibd671bde7190df976b5365331731a55a9abdbb35
2021-12-06 15:59:39 -08:00
Becky Qiu d0a9f1502b [DO NOT MERGE] Remove one search flag and code from sc-v2.
Bug: 209501163
Test: manual
Change-Id: Iee1c8276a1f81aa0f54e8a342cfdd3f01d7ab1b7
2021-12-06 15:22:04 -08:00
Tony Wickham f1951ce1f7 Fix taskbar stash misalignment when going from app to overview
Keep taskbar unaligned with hotseat if we're stashing anyway

Test: Swipe up from app with taskbar present to overview, check frame by frame to ensure icons morph directly into the handle instead of above it
Fixes: 208697792
Change-Id: If3238286b3383e75eb71fbd3b97d34bb3b44340b
2021-12-06 15:15:34 -08:00
Tony Wickham 3d206ca917 Merge "Fix taskbar jumping when going home" into sc-v2-dev 2021-12-06 20:15:20 +00:00
Jon Miranda 52ee4ec4aa Merge "Play return to icon animation if user swipes back to All Apps." into sc-v2-dev 2021-12-06 18:17:52 +00:00
Alex Chau 5656154f1a Merge "Add back screenshot button to Launcher3" into sc-v2-dev 2021-12-06 17:37:42 +00:00
Schneider Victor-tulias 6c9dbb8db6 Merge "Update taskbar edu strings for i10n." into sc-v2-dev 2021-12-06 15:30:11 +00:00
András Klöczl f4a161eef3 Merge "Add TAPL tests for two panel workspace" into sc-v2-dev 2021-12-06 14:09:54 +00:00
Winson Chung a21e47c930 Merge "Fix issue with Shell listeners being unbound if SysUI is restarted" into sc-v2-dev 2021-12-04 04:34:27 +00:00
TreeHugger Robot ad890ac5af Merge "Use getMeasuredWidth instead of getWidth in setSplitIconParams" into sc-v2-dev 2021-12-03 20:23:58 +00:00
TreeHugger Robot 3013c7ecf5 Merge "Constraint Snackbar's width to 504dp" into sc-v2-dev 2021-12-03 19:15:22 +00:00
TreeHugger Robot 79b56b0659 Merge "Revert "Align OverviewActionsView for 3 button taskbar"" into sc-v2-dev 2021-12-03 18:40:37 +00:00
Alex Chau 4bdf8c1754 Use getMeasuredWidth instead of getWidth in setSplitIconParams
Fix: 208647202
Test: Enter overview with app pairs, rotate and rotate back, check the task icon
Change-Id: I14914258a2508cf3f399312f4c88574b27a5e9fa
2021-12-03 18:28:38 +00:00
TreeHugger Robot 418185e4e8 Merge "Fix ordering of resource libraries for Quickstep build." into sc-v2-dev 2021-12-03 18:06:39 +00:00
TreeHugger Robot dff64072ff Merge "Remove keepWindowOpaque and have the window always fade out." into sc-v2-dev 2021-12-03 18:06:24 +00:00
Alex Chau dc73072797 Constraint Snackbar's width to 504dp
Fix: 209005185
Test: manual
Change-Id: I512ddb575a9fced4bf2608806aef875fe34304e6
2021-12-03 16:20:42 +00:00
Alex Chau 149acef8d7 Revert "Align OverviewActionsView for 3 button taskbar"
This reverts commit 6e906f3436.

Reason for revert: b/204891006
Bug: 189807374
Change-Id: I1b3f93d44b1691aa3d2cc90222ac93067a5cf6b4
2021-12-03 15:17:51 +00:00
Ben Murdoch fabc873f72 Fix ordering of resource libraries for Quickstep build.
The ordering of depedent resource libraries is important when more
than one library provides a particular resource. In the case
of the Launcher3QuickStepLib target, the most specific resources are in
QuickstepResLib target so it should be the last dependency.

Bug: 208647810
Test: builds, resources overlaid correctly.

Change-Id: I47ac36faae18a8382fe5e8f9c83ac0c2ae4c310f
2021-12-03 14:54:20 +00:00
Alex Chau 1bf0fe1b70 Add back screenshot button to Launcher3
- Also make spacing between buttons always 36dp
- Updated screenshot button image for Launcher3

Fix: 208384949
Test: Start overview in Launcher3WithQuickStep, test screenshot button is working
Change-Id: Ieb60ce134813202c1d14137fff0a131e1f5f8c96
2021-12-03 12:32:29 +00:00
Alex Chau 683b4cd824 Merge "Destroy activity/view references to avoid memory leak" into sc-v2-dev 2021-12-03 12:30:49 +00:00
Alex Chau 402252f4b6 Merge "Align OverviewActionsView for 3 button taskbar" into sc-v2-dev 2021-12-03 12:30:49 +00:00
Winson Chung e4dc13ac72 Fix issue with Shell listeners being unbound if SysUI is restarted
- If SysUI is restarted (ie. during dev or a crash), the components
  registering the shell listeners may not be aware of this, and
  listener callbacks will not be re-registered.  Currently all the
  listeners are managed correctly (bound & later unbound) so we can
  just keep the active listener references to re-register if this
  happens.

Bug: 207142749
Test: Kill SysUI, start some apps and ensure Launcher still shows them
      in recents
Change-Id: I47665180bbff3a12b12686e2ca3063ecd188bb56
2021-12-03 04:38:26 +00:00
Vinit Nayak 573fca80f6 Destroy activity/view references to avoid memory leak
Bug: 204891006
Change-Id: If60ac1716c30ebe68fb6e7457d71f542d3075422
2021-12-02 16:05:52 -08:00
TreeHugger Robot 9c7baac12d Merge "Fix direction of matrix inversion" into sc-v2-dev 2021-12-02 23:52:42 +00:00
TreeHugger Robot 7f54d5cde4 Merge "Add icons for staged split" into sc-v2-dev 2021-12-02 23:00:48 +00:00
Alex Chau b31176c83b Merge "Fix switch access for overview grid" into sc-v2-dev 2021-12-02 22:32:01 +00:00
Vinit Nayak 20cbfa5427 Fix direction of matrix inversion
* "And I would have gotten away with it too
if it wasn't for you meddling [matrices]"

Fixes: 208360236
Change-Id: I1607a19c81830f6a037d2337ee1d9e944096e0ac
2021-12-02 22:08:06 +00:00
Tony Wickham e59a723af3 Fix taskbar jumping when going home
- Set resumed state immediately when finishing recents controller to launcher, otherwise there's a race where we start animating gesture state to 0 before animating resumed state to 1, which causes the jump in the bug

Test: Swipe from app to home 10 times, no jump
Fixes: 203725820
Change-Id: Ie8a1add29902a9961ba4d7861ba5424ab656f1c8
2021-12-02 12:19:32 -08:00
Winson Chung eb4b2d0147 Merge "Fix NPE from null thumbnail data when canceling recents animation" into sc-v2-dev 2021-12-02 19:01:40 +00:00
Tony Wickham 3d2a1a7368 Merge "Remove TaskbarLauncherStateController#setIconAlpha()" into sc-v2-dev 2021-12-02 17:39:08 +00:00
Andras Kloczl c820151a4c Add TAPL tests for two panel workspace
- Add test for icon dragging
- Add test for page pairing
- Add test for empty page removal
- Add dragIcon helper method

Test: TwoPanelWorkspaceTest
Bug: 197631877
Change-Id: I7ce2dd88e183626feac49b34254d00a589473944
2021-12-02 16:44:26 +00:00
Nick Chameyev c5d3a0d891 Do not animate QSB and hotseat when portrait
Disables fold/unfold animation for QSB and hotseat
icons when in portrait orientation. Launcher workspace
icons and widgets are still animated intentionally.
Reuses NaturalOrientationRotationProvider which is currently
used to disable fold/unfold animation in the status bar when
in non-natural orientation.

Bug: 201518277
Test: fold/unfold on launcher in landscape =>
 QSB and hotseat animated;
 rotate screen during fold/unfold animation =>
 translation reset after rotating to portrait,
 animated after returning to landscape;
 rotate after fold/unfold animation => no changes
Change-Id: I8ed405b09f445f554d7638ab44393c90773e0bb6
2021-12-02 14:39:08 +00:00
Schneider Victor-tulias fc846eef41 Update taskbar edu strings for i10n.
Fixes: 200777300
Test: none
Change-Id: I9d6e2575940d2fcdd354c94036662c178f9d6eee
2021-12-01 16:04:33 -08:00