Commit Graph

18115 Commits

Author SHA1 Message Date
TreeHugger Robot b821d5dfee Merge "Not suppressing exceptions in tests." into ub-launcher3-master 2019-01-30 18:27:49 +00:00
TreeHugger Robot d655eb2fe8 Merge "Import translations. DO NOT MERGE" into ub-launcher3-master 2019-01-30 04:19:42 +00:00
Bill Yi 2aeee4ba55 Import translations. DO NOT MERGE
Change-Id: Ic9282c2ed62a6ac88e8e61f309f1dfffdf1e487a
Auto-generated-cl: translation import
2019-01-29 19:35:37 -08:00
vadimt 44d227a5b8 Fixing AOSP TaplTestsLauncher3.testAllAppsFromHome test
On the AOSP target, there are not enough apps to make App Apps
scrollable. Moving the test to QS Tapl tests.

Change-Id: I95e196bafdbd0fee77705554890a7c3cda7ac92a
Tests: the affected test
2019-01-29 17:23:25 -08:00
Tracy Zhou f13380543f Finish recents animation when user long swipes to all apps.
Change-Id: I4b7c419236f3a31f882d8bf5a7f526cb7310215a
Fixes: 123601356
Test: Long swipe to all apps. Release and swipe down to home. Make sure live tile is gone.
2019-01-29 17:19:45 -08:00
Tony Wickham 023f404a12 Make quick switch ("hook") more reliable
- Add max orthogonal displacement to MotionPauseDetector to avoid
  pausing when swiping left or right
- When gesture in ambiguous between swipe up for home or swipe over
  for the new task, base the decision on the faster velocity component
- Disable recents freescroll mode when dispatching motion from the nav
  bar. This way recents handles it naturally and we don't need custom
  logic to snap to the next page at the end of the gesture.
- Fix a bug where you couldn't hook to start a new task when SWIPE_HOME
  was disabled

Bug: 111926330
Change-Id: If63aa2bb32b57c3f401c5df8b3f6f4efec97b1fa
2019-01-29 17:11:12 -08:00
vadimt c5e3f9463d Not suppressing exceptions in tests.
This makes it harder to diagnose problems.

Bug: 117888000
Test: all tests affected by the change
Change-Id: I354e86af0929531653cf59ce1eb6435018c20e1a
2019-01-29 16:52:22 -08:00
Kevin 701b82c838 Move ActivityControlHelper impl to upper level
This CL moves the implementations of ActivityControlHelper from an inner
class to an upper level class in preparation to override the
implementation-specific logic for Go.

Bug: 114136250
Test: Manual test NexusLauncher, Launcher3QuickStepGo
Change-Id: Ic4b004f57cde263414c8dc57fe5c868dabc00dbe
2019-01-29 14:54:34 -08:00
TreeHugger Robot eefa08b8be Merge "Fix grid options provider metadata" into ub-launcher3-master 2019-01-29 22:28:44 +00:00
Santiago Etchebehere 339de9dda9 Fix grid options provider metadata
The actual authority is {packagename}.grid_control.

Bug: 122262084
Change-Id: I5552ccdb818efa49900409035e41505ed2f7687b
2019-01-29 14:15:15 -08:00
vadimt bff4842c23 Removing unnecessarily requiring activity to be a launcher
It can be fallback recents, which breaks fallback recents tests.

See: https://sponge.corp.google.com/target?id=f2aee870-f682-40b7-978a-d3b6ee12f2db&target=com.google.android.apps.nexuslauncher.tests&showTestCases=ALL

Change-Id: Ib1ff1ca3db451104e6a8de58e27255bf5fb41544
Tests: FallbackRecentsTest.goToOverviewFromHome
2019-01-29 13:33:19 -08:00
Kevin 3d5551a18e Split OverviewToAllApps for Go
This CL swaps out the current OverviewToAllApps touch controller with
the Go specific implementation. Moreover, since we only use this class
in landscape, we rename it to LandscapeStatesTouchController to avoid
confusion.

Bug: 114136250
Test: Manual test NexusLauncher, Launcher3QuickstepGo, Go recents
Change-Id: I6025cfe9f400705a4666fd92298a08a0c0ef7202
2019-01-29 13:13:04 -08:00
TreeHugger Robot b3ca6aee2c Merge "Changing min sdk to 25" into ub-launcher3-master 2019-01-29 20:43:01 +00:00
TreeHugger Robot 5aabc55780 Merge "Add springs for recents dismiss animations." into ub-launcher3-master 2019-01-29 20:35:02 +00:00
Jon Miranda 86f6c449a7 Add springs for recents dismiss animations.
Bug: 111698021
Change-Id: If518ba5946ea6fada67f549f2f29e1ab1c89969d
2019-01-29 12:13:57 -08:00
TreeHugger Robot 8d4430a1d7 Merge "Splitting TaplTests into a pure AOSP and QS parts" into ub-launcher3-master 2019-01-29 20:10:51 +00:00
TreeHugger Robot 4f197550f7 Merge "Fixing flakiness of ShortcutsToHomeTest" into ub-launcher3-master 2019-01-29 20:08:50 +00:00
vadimt 446bf0092e Fixing flakiness of ShortcutsToHomeTest
More precisely, an experiment on whether this will help. The theory is
that the current implementation where we long-press an icon for a fixed
period of time sometimes doesn't work because Launcher might start
measuring the press time with some delay.

Now we keep pressed the icon until the menu appears.

Change-Id: I1cead505726a998316a73d81b10160517f17f08f
Tests:ShortcutsToHomeTest.testDragIcon
2019-01-29 11:40:59 -08:00
Sunny Goyal 8c48d8bea6 Changing min sdk to 25
Change-Id: I0d28069967854357ca755bf25dec19d4979bdecf
2019-01-29 11:29:52 -08:00
TreeHugger Robot 584b9fa4bf Merge "Fix ToggleableGlobalSettingsFlag on user builds" into ub-launcher3-master 2019-01-29 19:25:11 +00:00
Tony Wickham 776c7e63d3 Fix ToggleableGlobalSettingsFlag on user builds
TogglableFlags are not initalized if !IS_DEBUG_DEVICE. Thus,
trying to read from the ContentProvider produces a NPE.

Also make ENABLE_TASK_STABILIZER global again now that this
fix is in place.

Bug: 123429711
Change-Id: I252e9b3ef4e802e769865f13b14487a36b8e1f82
2019-01-29 11:01:22 -08:00
vadimt dc2f2dc639 Splitting TaplTests into a pure AOSP and QS parts
This will allow running as many as possible automatic checks on AOSP
launcher and moving most AOSP tests that use TAPL to where they belong
to: Tapl Tests.

Bug: 110103162
Test: Running the test suites
Change-Id: I9192354e6097698d4b942c5682b79664ecc2336d
2019-01-29 10:53:34 -08:00
TreeHugger Robot 9752705e92 Merge "Fix bugs with quickstep springs." into ub-launcher3-master 2019-01-29 18:35:03 +00:00
Sunny Goyal 703ee9f675 Passing proper velocity information when simulating touch events on recents view
Change-Id: I488b8d61c47e49dbdc65b16e2470b171912efc3f
2019-01-28 16:46:48 -08:00
TreeHugger Robot 0428616762 Merge "Adding support for swipe and hold to overview from home screen to all-apps" into ub-launcher3-master 2019-01-29 00:04:59 +00:00
Sunny Goyal 8b2b4e24ee Adding support for swipe and hold to overview from home screen to all-apps
- After the atomic animation ends, overview jumps slightly because the
  normal -> all apps transition puts it at a different position than
  normal -> overview

Bug: 111926330
Change-Id: I6ca359b3ef2fc4d0b6b96229d8bf118bd0db9649
2019-01-28 15:51:19 -08:00
Jon Miranda f82fd49244 Fix bugs with quickstep springs.
* Listeners weren't getting called properly. We add one listener to the
SpringbjectAnimator and then use that to dispatch to the other listeners.

* We fast finish on both double swipe cases to prevent the shelf from
  ending in an invalid state. This causes a visual jump but this can be
  addressed in follow up CL.

Bug: 111698021
Change-Id: Ifeb55da9dd253d062122a8e1577f94044f688641
2019-01-28 15:47:59 -08:00
Sunny Goyal e0c5f5d0ab Fixing jump when swiping up because startDisplacement was getting reset in the middle
Change-Id: I6b8be9505ec2bd22bbc76efe81b6f00231645267
2019-01-28 13:02:57 -08:00
TreeHugger Robot 989732be57 Merge "Unifying the two different state listeners" into ub-launcher3-master 2019-01-28 20:34:32 +00:00
Tony Wickham 07f164dc2e Merge "Swipe up to go home, swipe and hold to go to overview" into ub-launcher3-master 2019-01-28 19:59:54 +00:00
Sunny Goyal 7f45514d15 Unifying the two different state listeners
Bug: 123376689
Change-Id: I61d4865044a1bd27ee78002a4083a686233740b7
2019-01-28 11:56:54 -08:00
TreeHugger Robot 80d03d1fa4 Merge "Move overview component logic from OverviewCommandHelper" into ub-launcher3-master 2019-01-28 19:43:32 +00:00
Tony Wickham 18759647f0 Swipe up to go home, swipe and hold to go to overview
- Pause (swipe and hold) detection based on velocity and acceleration,
  so it feels immediately responsive
- Don't show shelf during swipe; peek when swipe pauses
- Disallow long swipe
- If swiping to go home (we didn't detect a pause), animate window and
  launcher together (not final animation, but mechanism is in place)
- Guarded by SWIPE_HOME flag

Bug: 111926330
Change-Id: Ie4af04517c6688e3d649c2971a1aad197837cb3b
2019-01-28 11:37:33 -08:00
Jonathan Miranda d52b53e8e5 Merge "Add springs when snapping between pages on the workspace." into ub-launcher3-master 2019-01-28 19:31:23 +00:00
bohu 68c6254fb0 Revert "Make ENABLE_TASK_STABILIZER a toggleable via global settings"
BUG: 123429711

This reverts commit e346b2f910.
Reason: launcher crashes in user build

Change-Id: I57315a7969dd70aa615235ed8425d5b2a05545a6
(cherry picked from commit 612bb6be7c)
2019-01-28 04:48:23 +00:00
Kevin 2a9e3a66bc Move overview component logic from OverviewCommandHelper
OverviewCommandHelper previously managed both updating the current
overview component and interfacing inputs to switch to the
overview activity. This CL splits out the former to a separate
class so that the responsibilities are more focused and the code
can be reused more easily.

Test: Manual test NexusLauncher, Launcher3QuickStepGo by switching to
overview
Change-Id: I4e90918703f351d235f3cb0a45079cbb31b753ab
2019-01-25 15:17:36 -08:00
Tracy Zhou 7eebfc5649 Merge "Make bounce animations less aggressive" into ub-launcher3-master 2019-01-25 20:36:23 +00:00
Vadim Tryshev 44ecb9d7cb Fix swiping up to Overview in landscape mode
Bug: 121280703
Change-Id: I9802c6f547a592be891e7c4f5e8db8dadaa0425d
Tests: TaplTests, locally modified to force Landscape
2019-01-25 12:29:42 -08:00
vadimt 3f8591f003 Removing diagnostics
Now that b/117332845 is fixed

Bug: 117332845
Change-Id: If8c137b9c7cc386dfc5b5af4b81a3efbfa33f770
Tests: None
2019-01-25 10:35:53 -08:00
TreeHugger Robot d182943d3d Merge "Updating folder shape when icon shape changes" into ub-launcher3-master 2019-01-25 17:24:13 +00:00
Jon Miranda 71cb80cccb Add springs when snapping between pages on the workspace.
- Behind feature flag QUICKSTEP_SPRINGS
- Springs control settling the page and allow for overscroll for the
  first/last pages

Bug: 111698021
Change-Id: Ib4a9ef59463cc46e31ac0766bf7705612f6c63c1
2019-01-24 21:25:32 -08:00
TreeHugger Robot f530c4032b Merge "Adding meta-data for grid options provider" into ub-launcher3-master 2019-01-25 01:07:44 +00:00
TreeHugger Robot 90048de773 Merge "Disable window corner rounding on some devices" into ub-launcher3-master 2019-01-25 00:31:52 +00:00
Lucas Dupin a2074857dc Disable window corner rounding on some devices
Bug: 122347746
Test: visual; on taimen, marlin and walleye
Change-Id: If6ac1c75297dd25ad40d3ec61537e8793bceceb7
2019-01-24 16:19:49 -08:00
Tracy Zhou c49f3de3bd Make bounce animations less aggressive
Users have reported that both home and shelf bounce animations are pretty aggressive. We should limit the number of times that we show bounce animations for both quickstep and non quickstep users so that they can have a less disturbing experience.

Change-Id: I445fc9c7c6ac8a9c0ef34381fa672bf1b0203737
Fixes: 123356757
Test: Manual test
2019-01-24 15:48:20 -08:00
Sunny Goyal 6dda58a31b Adding meta-data for grid options provider
Bug: 122262084
Change-Id: I4b07f17eb9bad351a48e2d612159fbe2d33cf1dd
2019-01-24 15:40:55 -08:00
TreeHugger Robot f81da5f4ee Merge "Removing querying whether DWB time limit is for a group" into ub-launcher3-master 2019-01-24 23:07:48 +00:00
vadimt d4c45e8104 Removing querying whether DWB time limit is for a group
This API is removed for Q.

Bug: 118319143
Test: Manual
Change-Id: I1605ba14a914bfe018c4a2f6d974afaea7e51e05
2019-01-24 13:52:49 -08:00
Kevin Han 57f88bd0ec Revert "Remove OverviewToAllAppsController for Go"
This reverts commit 792fcc3aec.

Reason for revert: This class actually manages more than just overview to all apps transitions, and Go needs some form of this for landscape transitions state transitions

Change-Id: I073dcc94dda06ff8d87166d2674927df8f2418f5
2019-01-24 20:36:04 +00:00
Kevin 792fcc3aec Remove OverviewToAllAppsController for Go
Go's recents does not support an overview to all apps transition (as
there will be no hotseat and swiping will be used to navigate the view
itself). As a result, we never need the controller, so we don't take in
the class as a source and do not add it as a touch controller.

Bug: 114136250
Test: Manual test Launcher3QuickstepGo, NexusLauncher,
Launcher3IconRecentsGo
Change-Id: I7fff9d1e8727bd978e84462436e37219c57f7af6
2019-01-23 17:12:44 -08:00