Commit Graph

21461 Commits

Author SHA1 Message Date
Hyunyoung Song 7fe8a69085 Merge "Provide up to 3 folder name suggestions to active IME Bug: 144973594" into ub-launcher3-master 2019-11-23 00:48:08 +00:00
Tony Wickham 435b11b95f Don't removePluginListener() unless user is unlocked
This just crashes since we can't access SharedPreferences, and we don't
addPluginListener until onUserUnlocked() anyway.

Change-Id: I705498f859857a52a2cb5735201a652973b26d0b
2019-11-22 16:06:49 -08:00
Hai Zhang f58ba9ca79 Align badging logic with platform IconDrawableFactory.
The current logic in BaseIconFactory is only trying to add the user
badge if the user passed in isn't null and isn't the current user,
then if no such attempt is made, try to add an instant app badge. This
is causing user badge to disappear if the current user is a work
profile. Meanwhile, the badging logic in IconDrawableFactory is to try
to add the instant app badge first, and then always try to add the
user badge.

Bug: 132625654
Test: manually test as in b/128625591
Change-Id: Ia5b456f1f27095d546504266a1a90034105c9ae9
Merged-In: I2241bdb524ca6bc66e545a0ec8433119e0448358
(cherry picked from commit bdb0236125922a3a9b20fbaa8ecd1d2477b48ed5)
2019-11-22 23:40:04 +00:00
Hyunyoung Song b2049196b9 Align badging logic with platform IconDrawableFactory.
The current logic in BaseIconFactory is only trying to add the user
badge if the user passed in isn't null and isn't the current user,
then if no such attempt is made, try to add an instant app badge. This
is causing user badge to disappear if the current user is a work
profile. Meanwhile, the badging logic in IconDrawableFactory is to try
to add the instant app badge first, and then always try to add the
user badge.

Bug: 132625654
Test: manually test as in b/128625591

Change-Id: I2241bdb524ca6bc66e545a0ec8433119e0448358
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2019-11-22 15:21:56 -08:00
Automerger Merge Worker 9d9a3f6293 Merge "Fix quick switch from home biased towards returning home" into ub-launcher3-qt-future-dev am: 75b7b9d35c
Change-Id: I9a8e859c876f311c0ce7df97ca6246238fe958cf
2019-11-22 22:00:01 +00:00
TreeHugger Robot 75b7b9d35c Merge "Fix quick switch from home biased towards returning home" into ub-launcher3-qt-future-dev 2019-11-22 21:45:32 +00:00
TreeHugger Robot 0868d999f1 Merge "Improving error messages when swiping up to home" into ub-launcher3-master 2019-11-22 18:40:56 +00:00
Hyunyoung Song 5fcd8f9647 Provide up to 3 folder name suggestions to active IME
Bug: 144973594

Change-Id: I92078fffd68a1230fd87d2387404c8a2fed55bc0
2019-11-22 08:19:17 +00:00
vadimt 7d6e7add97 Improving error messages when swiping up to home
Change-Id: I7c230d657eacb7a386a906e1f5470a15e1fe5868
2019-11-21 19:12:19 -08:00
Automerger Merge Worker 0cdb388ac2 [automerger skipped] Fix bug where icon remains invisible after returning home. am: a3ea27de39 -s ours
am skip reason: Change-Id I082291ca9b288f57701cc00d61a9b3a84da8b084 with SHA-1 ad7e30f5d7 is in history

Change-Id: Ia0b4a222f49ffab92533873134b358df1780ddf2
2019-11-21 22:58:54 +00:00
TreeHugger Robot 9ccea3961c Merge "Accelerating dragging to workspace by using pause at the end of the gesture" into ub-launcher3-master 2019-11-21 22:30:04 +00:00
Jon Miranda a3ea27de39 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I94f3a066d395f9c3b97dc6ee9fc836e9401650a5
Merged-In: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-21 22:16:36 +00:00
Jonathan Miranda 92d4086fda Merge "Fix bug where icon remains invisible after returning home." into ub-launcher3-master 2019-11-21 22:16:23 +00:00
thiruram 5e1ecf6d73 Adds proto-lite libraries to Launcher3 make files.
Change-Id: Icb2f8fcdb4d5344de835f4702fc01ec80d4a3b84
2019-11-20 21:49:44 +00:00
Jon Miranda ad7e30f5d7 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-20 13:17:51 -08:00
Tony Wickham 94fb4cd3fd Fix quick switch from home biased towards returning home
When flinging up and to the right, we previously always returned
home. Now, if the right velocity is stronger, we quick switch.

Bug: 126596417
Change-Id: I14fa0584399bb90f2e07e0b296fc5932d8224fbf
2019-11-20 13:08:44 -08:00
Tony Wickham fed129305d [automerger skipped] Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-qt-future-dev
am: f3761296a1 -s ours
am skip reason: change_id I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f with SHA1 4df42f85a4 is in history

Change-Id: Ife6d77baef86054445ccbe966c3e880f1c95007c
2019-11-20 11:12:43 -08:00
TreeHugger Robot f3761296a1 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-qt-future-dev 2019-11-20 19:02:45 +00:00
Tony Wickham da8bc42248 [automerger skipped] Merge "Improve quick switch from home by tracking both x and y motion" into ub-launcher3-qt-future-dev
am: ced2347289 -s ours
am skip reason: change_id Id679ad84c08246e205c667a78ed5df00d7276258 with SHA1 37a0970bf5 is in history

Change-Id: I9fc180a21ce82d4088211c144134636f127d1447
2019-11-20 10:54:03 -08:00
Tony Wickham ced2347289 Merge "Improve quick switch from home by tracking both x and y motion" into ub-launcher3-qt-future-dev 2019-11-20 18:46:50 +00:00
Tony Wickham 09c09bba1e Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
Merged-In: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-20 18:05:06 +00:00
TreeHugger Robot 5a2db8c8d4 Merge "Removing a workaround to make NevigationModeSwitchRule pass on CF" into ub-launcher3-master 2019-11-20 18:00:58 +00:00
Tony Wickham e33f3ee3b2 [automerger skipped] Merge "Move shelf peeking anim code to ShelfPeekAnim class" into ub-launcher3-qt-future-dev
am: 70a2a7dcac -s ours
am skip reason: change_id I5ba501b04b3eaf12a20ba1312ef362f9734761c3 with SHA1 85d6f25016 is in history

Change-Id: Ie23add1cbd181cc6d84f00f3f9d7c3a107c5589d
2019-11-20 02:11:08 -08:00
TreeHugger Robot 70a2a7dcac Merge "Move shelf peeking anim code to ShelfPeekAnim class" into ub-launcher3-qt-future-dev 2019-11-20 09:08:56 +00:00
Tony Wickham ff828d2f24 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-master 2019-11-20 05:07:12 +00:00
vadimt 7410808085 Removing a workaround to make NevigationModeSwitchRule pass on CF
Change-Id: I7b7cabc098f17c99406032e186a4ee363273f0a9
2019-11-19 18:04:13 -08:00
Tony Wickham 603c20ad37 Merge "Improve quick switch from home by tracking both x and y motion" into ub-launcher3-master 2019-11-20 00:35:05 +00:00
Jon Miranda 2d250b3fef Fix folder open/close animation when grid size is small.
am: 4744701f60

Change-Id: I34f242fd25b051b96447133f331d2e0e82a5760e
2019-11-19 16:11:30 -08:00
vadimt 83b7a6d8bf Accelerating dragging to workspace by using pause at the end of the
gesture

Change-Id: Ib14b9519e23aa34156dab9eff75cd2609ad57e14
2019-11-19 15:00:29 -08:00
TreeHugger Robot 10bf76941f Merge "Making the default launcher rule outer for the Portrait-Landscape one" into ub-launcher3-master 2019-11-19 22:51:54 +00:00
Jon Miranda 4744701f60 Fix folder open/close animation when grid size is small.
The issue was that the scaled folder size was smaller than the clip size.
To ensure that the folder size is always larger than the clip size, we
instead scale the contents of the folder instead of the folder itself.

Bug: 143703075
Change-Id: I6eadcc487148fe7e2b7dd9f0ff94a9205048b992
2019-11-19 14:42:48 -08:00
Vadim Tryshev 8bdd83ec1b Merge "Staring swipe-to-all-apps gesture from above bottom gesture area" into ub-launcher3-master 2019-11-19 21:49:20 +00:00
vadimt 4d627f09c0 Staring swipe-to-all-apps gesture from above bottom gesture area
Bug: 139682945
Change-Id: I2fe8929c1dea8448c23394afd6f9d711b73f2562
2019-11-19 21:48:55 +00:00
vadimt f9e559275d Making the default launcher rule outer for the Portrait-Landscape one
Portrait-Landscape uses Launcher activity and needs it to be set up
correctly.

Change-Id: I13c9712647b3e45a259039d7968bb95cfe8158ef
2019-11-19 13:36:29 -08:00
TreeHugger Robot f982b0dcc8 Merge "[a11y] fix the issue where launcher announces item added to homescreen before it does" into ub-launcher3-master 2019-11-19 07:29:44 +00:00
Samuel Fufa a9e9444070 Merge "Report app pin/unpin to AppPredictor" into ub-launcher3-master 2019-11-19 01:18:15 +00:00
TreeHugger Robot 23ac34a42c Merge "When scrolling in All apps, scroll to last clickable row" into ub-launcher3-master 2019-11-19 00:01:10 +00:00
Winson Chung ea91205f66 Merge "Fix two small thumbnail leaks" into ub-launcher3-master 2019-11-18 18:41:49 +00:00
Samuel Fufa 4031d65171 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev
am: 9353b00616

Change-Id: I37fab57d0c01b413ca05049326ca519d6d74323e
2019-11-18 10:32:02 -08:00
Samuel Fufa 9353b00616 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev 2019-11-18 18:19:14 +00:00
Samuel Fufa 7a8be030aa Report app pin/unpin to AppPredictor
Test: Manual
Bug: 142753423
Change-Id: I380e58f31ed508d812d0bf8dfc35905a752dc029
2019-11-18 10:14:53 -08:00
Tracy Zhou 897813aa34 Merge "Check if returned surface params are null before adding them for surface transform" into ub-launcher3-master 2019-11-15 21:45:25 +00:00
vadimt 73cd121122 When scrolling in All apps, scroll to last clickable row
Not the last row. This fixes tests broken after some assumption broke in
platform at an unknown moment.

Since the gesture distance became smaller in some cases, the speed of
the gesture became slower, and on some devices, the scroll gesture
triggers icon dragging.

To prevent this, I reduced the number of steps in the gesture to 10, but
added a slow-down at the end of the gesture to avoid inertia.

Also made some names and calculations clearer.

Bug: 144180777
Change-Id: Ie6c5776606ecff64d553fa836bdb3d90f32c5d9e
2019-11-15 13:40:29 -08:00
Tracy Zhou fdf954a353 Check if returned surface params are null before adding them for surface transform
We call finish recents animation before app switch animation finishes. When we finish, the live tile params are not cleared up.

This change takes care of
- clean up recents animation targets when it's finished
- do a sanity check on live tile surface params before adding them to the surface transform array

Fixes: 143889142
Test: Swipe up to Overview in live tile mode, switch to a different task, and make sure it doesn't crash anymore
Change-Id: I089cf0a97744461d1fec4d0c97e0c3c6c1049ae3
2019-11-15 13:06:36 -08:00
Winson Chung 9b5f4aa48d Fix two small thumbnail leaks
- Even though the object wrapper is used within the same process, the
  call to start the fallback recents activity means that the system
  still ends up holding a reference to a copy of the intent and its
  extras, including the reference to the wrapper and the thumbnail it
  references, until the activity is destroyed (or next restarted).
  We need to clear the actual object strong ref after it's used when
  handling the new intent.
- The running task can have an associated thumbnail, so we should also
  clear the tmp running task ref when we leave overview.

Change-Id: Icdc0b1989b13927d112949797752615014856970
2019-11-15 11:31:15 -08:00
TreeHugger Robot 1dca644311 Merge "Disabling FallbackRecents tests" into ub-launcher3-master 2019-11-15 16:50:02 +00:00
Pinyao Ting 96df2cb8b3 [automerger skipped] Merge "fix custom shortcut test" into ub-launcher3-qt-future-dev
am: f7b75392fc -s ours
am skip reason: change_id I296452faea67568b39a35968bb813dc4e51a51fc with SHA1 44677f7e88 is in history

Change-Id: I880b94cbc3f5dfcd98f8886c454657bba466885e
2019-11-14 18:16:26 -08:00
Pinyao Ting f7b75392fc Merge "fix custom shortcut test" into ub-launcher3-qt-future-dev 2019-11-15 01:55:40 +00:00
Pinyao Ting 838f4393b6 fix custom shortcut test
Bug: 143725213
Change-Id: I296452faea67568b39a35968bb813dc4e51a51fc
Merged-In: I296452faea67568b39a35968bb813dc4e51a51fc
2019-11-15 01:55:13 +00:00
vadimt cbc9bffd7e Disabling FallbackRecents tests
Even though they don't block presubmit, the fact that they are failing:
1. Causes sheriffs no not notice other issues;
2. Would block switching to 24hr fix-it policy and Quarterdeck.

Bug: 143488140
Change-Id: I95e3e15b69e0487946919f3f6889e286a1fae141
2019-11-14 17:23:52 -08:00